* [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization @ 2017-09-20 5:39 Michal Kalderon [not found] ` <1505885986-5873-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Michal Kalderon @ 2017-09-20 5:39 UTC (permalink / raw) To: michal.kalderon-YGCgFSpz5w/QT0dZR+AlfA, dledford-H+wXaHxf7aLQT0dZR+AlfA, leon-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Michal Kalderon, Ariel Elior Initialize the rdma_type (iWARP or RoCE) which is set according to device configuration in qed. Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP device") Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> --- This patch applies cleanly on k.o/for-next-merged Changes from V0: - Added Fixes in commit comment. --- drivers/infiniband/hw/qedr/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index ca93171..1afc267 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -870,6 +870,7 @@ static struct qedr_dev *qedr_add(struct qed_dev *cdev, struct pci_dev *pdev, goto init_err; dev->user_dpm_enabled = dev_info.user_dpm_enabled; + dev->rdma_type = dev_info.rdma_type; dev->num_hwfns = dev_info.common.num_hwfns; dev->rdma_ctx = dev->ops->rdma_get_rdma_ctx(cdev); -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1505885986-5873-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <1505885986-5873-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> @ 2017-09-27 13:27 ` Doug Ledford [not found] ` <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Doug Ledford @ 2017-09-27 13:27 UTC (permalink / raw) To: Michal Kalderon, leon-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ariel Elior On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > Initialize the rdma_type (iWARP or RoCE) which is set according to > device configuration in qed. > > Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP > device") > > Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > > --- > This patch applies cleanly on k.o/for-next-merged > > Changes from V0: > - Added Fixes in commit comment. Sorry, I was wrong in my email to the previous posting of this patch. I had pulled this v1 patch from patchworks, not the original patch, and so the Fixes: line was yours. Patchworks did not add the Fixes: line to the v0 patch when I downloaded it just now. That being said, I still can't build with this patch ;-) -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2017-09-27 16:18 ` Kalderon, Michal [not found] ` <CY1PR0701MB20126E3E86A45619079DFCAC88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-09-29 15:22 ` Doug Ledford 1 sibling, 1 reply; 12+ messages in thread From: Kalderon, Michal @ 2017-09-27 16:18 UTC (permalink / raw) To: Doug Ledford, leon-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sent: Wednesday, September 27, 2017 4:27 PM >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: >> Initialize the rdma_type (iWARP or RoCE) which is set according to >> device configuration in qed. >> >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP >> device") >> >> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> >> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> >> >> --- >> This patch applies cleanly on k.o/for-next-merged >> >> Changes from V0: >> - Added Fixes in commit comment. > >Sorry, I was wrong in my email to the previous posting of this patch. >I had pulled this v1 patch from patchworks, not the original patch, and >so the Fixes: line was yours. Patchworks did not add the Fixes: line >to the v0 patch when I downloaded it just now. >That being said, I still can't build with this patch ;-) Are you building against the rdma-next branch ? The patch requires the iWARP series, originally this was tested against for-next-merged, what's the error you're getting ? thanks, Michal -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CY1PR0701MB20126E3E86A45619079DFCAC88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <CY1PR0701MB20126E3E86A45619079DFCAC88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> @ 2017-09-27 16:53 ` Leon Romanovsky [not found] ` <20170927165339.GI2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Leon Romanovsky @ 2017-09-27 16:53 UTC (permalink / raw) To: Kalderon, Michal Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Attachment #1: Type: text/plain, Size: 1905 bytes --] On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: > From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > Sent: Wednesday, September 27, 2017 4:27 PM > > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > >> Initialize the rdma_type (iWARP or RoCE) which is set according to > >> device configuration in qed. > >> > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP > >> device") > >> > >> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > >> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > >> > >> --- > >> This patch applies cleanly on k.o/for-next-merged > >> > >> Changes from V0: > >> - Added Fixes in commit comment. > > > >Sorry, I was wrong in my email to the previous posting of this patch. > >I had pulled this v1 patch from patchworks, not the original patch, and > >so the Fixes: line was yours. Patchworks did not add the Fixes: line > >to the v0 patch when I downloaded it just now. > > >That being said, I still can't build with this patch ;-) > Are you building against the rdma-next branch ? > The patch requires the iWARP series, originally this was tested against for-next-merged, > what's the error you're getting ? On rdma-next: drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’: drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’? dev->rdma_type = dev_info.rdma_type; ^~~~~~~~~ rdma_ctx make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1 > > thanks, > Michal > > -- > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20170927165339.GI2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <20170927165339.GI2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-09-27 16:56 ` Leon Romanovsky [not found] ` <20170927165610.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Leon Romanovsky @ 2017-09-27 16:56 UTC (permalink / raw) To: Kalderon, Michal Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Attachment #1: Type: text/plain, Size: 2246 bytes --] On Wed, Sep 27, 2017 at 07:53:39PM +0300, Leon Romanovsky wrote: > On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: > > From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > Sent: Wednesday, September 27, 2017 4:27 PM > > > > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > > >> Initialize the rdma_type (iWARP or RoCE) which is set according to > > >> device configuration in qed. > > >> > > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP > > >> device") > > >> > > >> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > > >> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > > >> > > >> --- > > >> This patch applies cleanly on k.o/for-next-merged > > >> > > >> Changes from V0: > > >> - Added Fixes in commit comment. > > > > > >Sorry, I was wrong in my email to the previous posting of this patch. > > >I had pulled this v1 patch from patchworks, not the original patch, and > > >so the Fixes: line was yours. Patchworks did not add the Fixes: line > > >to the v0 patch when I downloaded it just now. > > > > >That being said, I still can't build with this patch ;-) > > Are you building against the rdma-next branch ? > > The patch requires the iWARP series, originally this was tested against for-next-merged, > > what's the error you're getting ? > > On rdma-next: > drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’: > drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’? > dev->rdma_type = dev_info.rdma_type; > ^~~~~~~~~ > rdma_ctx > make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1 My config: ➜ linux-rdma git:(rdma-next) grep QED .config CONFIG_QED=m CONFIG_QED_LL2=y CONFIG_QED_SRIOV=y CONFIG_QEDE=m CONFIG_QED_RDMA=y CONFIG_INFINIBAND_QEDR=m > > > > > > thanks, > > Michal > > > > -- > > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > GPG KeyID: B826A3330E572FDD > > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20170927165610.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <20170927165610.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-09-27 20:33 ` Kalderon, Michal [not found] ` <CY1PR0701MB2012A41A0744D17AD3CD10DB88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Kalderon, Michal @ 2017-09-27 20:33 UTC (permalink / raw) To: Leon Romanovsky Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel From: Leon Romanovsky <leon@kernel.org> Sent: Wednesday, September 27, 2017 7:56 PM On Wed, Sep 27, 2017 at 07:53:39PM +0300, Leon Romanovsky wrote: >> On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: >> > From: Doug Ledford <dledford@redhat.com> >> > Sent: Wednesday, September 27, 2017 4:27 PM >> > >> > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: >> > >> Initialize the rdma_type (iWARP or RoCE) which is set according to >> > >> device configuration in qed. >> > >> >> > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP >> > >> device") >> > >> >> > >> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> >> > >> Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> >> > >> >> > >> --- >> > >> This patch applies cleanly on k.o/for-next-merged >> > >> >> > >> Changes from V0: >> > >> - Added Fixes in commit comment. >> > > >> > >Sorry, I was wrong in my email to the previous posting of this patch. >> > >I had pulled this v1 patch from patchworks, not the original patch, and >> > >so the Fixes: line was yours. Patchworks did not add the Fixes: line >> > >to the v0 patch when I downloaded it just now. >> > >> > >That being said, I still can't build with this patch ;-) >> > Are you building against the rdma-next branch ? >> > The patch requires the iWARP series, originally this was tested against for-next-merged, >> > what's the error you're getting ? >> >> On rdma-next: >> drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’: >> drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’? >> dev->rdma_type = dev_info.rdma_type; >> ^~~~~~~~~ >> rdma_ctx >> make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1 > >My config: > >➜ linux-rdma git:(rdma-next) grep QED .config >CONFIG_QED=m >CONFIG_QED_LL2=y >CONFIG_QED_SRIOV=y >CONFIG_QEDE=m >CONFIG_QED_RDMA=y >CONFIG_INFINIBAND_QEDR=m Thanks Leon for helping out with this. Unfortunately i'm not seeing this. The rdma_type field was added with the following patch: https://kernel.googlesource.com/pub/scm/linux/kernel/git/dledford/rdma/+/e6a38c54faf38498170e227c82ea25cb8bc1ae71 When running git log on the k.o/for-next I see the patch (last in list below), applying this patch on top of rdma-next works for me and compiles cleanly. 2e2f2d0 RDMA/qedr: Fix rdma_type initialization 1848757 Merge branches 'hns' and 'misc' into k.o/for-next 931bc0d IB: Move PCI dependency from root KConfig to HW's KConfigs 7ae6f2a Merge branch 'qedr' into k.o/for-next bd491d2 RDMA/qedr: fix build error without ipv6 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" 69ad0e7 RDMA/qedr: Add support for iWARP in user space e411e05 RDMA/qedr: Add iWARP connection management functions de0089e RDMA/qedr: Add iWARP connection management qp related callbacks fb1a22b RDMA/qedr: Add support for read with invalidate, supported in iWARP f5b1b17 RDMA/qedr: Add iWARP support in existing verbs e6a38c5 RDMA/qedr: Add support for registering an iWARP device am i missing something ? thanks, Michal ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CY1PR0701MB2012A41A0744D17AD3CD10DB88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <CY1PR0701MB2012A41A0744D17AD3CD10DB88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> @ 2017-09-28 3:27 ` Leon Romanovsky [not found] ` <20170928032725.GO2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Leon Romanovsky @ 2017-09-28 3:27 UTC (permalink / raw) To: Kalderon, Michal Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Attachment #1: Type: text/plain, Size: 4567 bytes --] On Wed, Sep 27, 2017 at 08:33:38PM +0000, Kalderon, Michal wrote: > From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Sent: Wednesday, September 27, 2017 7:56 PM > On Wed, Sep 27, 2017 at 07:53:39PM +0300, Leon Romanovsky wrote: > >> On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: > >> > From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > >> > Sent: Wednesday, September 27, 2017 4:27 PM > >> > > >> > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > >> > >> Initialize the rdma_type (iWARP or RoCE) which is set according to > >> > >> device configuration in qed. > >> > >> > >> > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP > >> > >> device") > >> > >> > >> > >> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > >> > >> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > >> > >> > >> > >> --- > >> > >> This patch applies cleanly on k.o/for-next-merged > >> > >> > >> > >> Changes from V0: > >> > >> - Added Fixes in commit comment. > >> > > > >> > >Sorry, I was wrong in my email to the previous posting of this patch. > >> > >I had pulled this v1 patch from patchworks, not the original patch, and > >> > >so the Fixes: line was yours. Patchworks did not add the Fixes: line > >> > >to the v0 patch when I downloaded it just now. > >> > > >> > >That being said, I still can't build with this patch ;-) > >> > Are you building against the rdma-next branch ? > >> > The patch requires the iWARP series, originally this was tested against for-next-merged, > >> > what's the error you're getting ? > >> > >> On rdma-next: > >> drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’: > >> drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’? > >> dev->rdma_type = dev_info.rdma_type; > >> ^~~~~~~~~ > >> rdma_ctx > >> make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1 > > > >My config: > > > >➜ linux-rdma git:(rdma-next) grep QED .config > >CONFIG_QED=m > >CONFIG_QED_LL2=y > >CONFIG_QED_SRIOV=y > >CONFIG_QEDE=m > >CONFIG_QED_RDMA=y > >CONFIG_INFINIBAND_QEDR=m > > Thanks Leon for helping out with this. Unfortunately i'm not seeing this. > The rdma_type field was added with the following patch: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/dledford/rdma/+/e6a38c54faf38498170e227c82ea25cb8bc1ae71 > > When running git log on the k.o/for-next I see the patch (last in list below), > applying this patch on top of rdma-next works for me and compiles cleanly. > > 2e2f2d0 RDMA/qedr: Fix rdma_type initialization > 1848757 Merge branches 'hns' and 'misc' into k.o/for-next > 931bc0d IB: Move PCI dependency from root KConfig to HW's KConfigs > 7ae6f2a Merge branch 'qedr' into k.o/for-next > bd491d2 RDMA/qedr: fix build error without ipv6 > 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() > 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" > 69ad0e7 RDMA/qedr: Add support for iWARP in user space > e411e05 RDMA/qedr: Add iWARP connection management functions > de0089e RDMA/qedr: Add iWARP connection management qp related callbacks > fb1a22b RDMA/qedr: Add support for read with invalidate, supported in iWARP > f5b1b17 RDMA/qedr: Add iWARP support in existing verbs > e6a38c5 RDMA/qedr: Add support for registering an iWARP device > > am i missing something ? I refreshed my branches now and it worked, but your git log history looks strange. Where did you see the commit 1848757 and 931bc0d? https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git/log/?h=k.o/for-next Age Commit message (Expand) Author Files Lines 3 days Merge branch 'qedr' into k.o/for-nextfor-nextk.o/for-next Doug Ledford 11 -91/+1208 3 days Merge tag 'v4.14-rc2' into k.o/for-next Doug Ledford 12044 -388475/+631018 3 days Linux 4.14-rc2HEADmaster Linus Torvalds 1 -1/+1 ➜ linux-rdma git:(iwarp-compile) git log --oneline f3506957237b (HEAD -> iwarp-compile) RDMA/qedr: Fix rdma_type initialization 7ae6f2a3d552 (rdma/k.o/for-next, grdma/k.o/for-next) Merge branch 'qedr' into k.o/for-next 0d9c2ff1c9f7 Merge tag 'v4.14-rc2' into k.o/for-next e19b205be43d (tag: v4.14-rc2, rdma/master, origin/master, ml/master, grdma/master, grdma/hns, backup/master, master) Linux 4.14-rc2 Thanks > thanks, > Michal > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20170928032725.GO2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* RE: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <20170928032725.GO2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-09-28 6:22 ` Kalderon, Michal [not found] ` <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Kalderon, Michal @ 2017-09-28 6:22 UTC (permalink / raw) To: Leon Romanovsky, Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 5257 bytes --] > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Thursday, September 28, 2017 6:27 AM > On Wed, Sep 27, 2017 at 08:33:38PM +0000, Kalderon, Michal wrote: > > From: Leon Romanovsky <leon@kernel.org> > > Sent: Wednesday, September 27, 2017 7:56 PM On Wed, Sep 27, 2017 at > > 07:53:39PM +0300, Leon Romanovsky wrote: > > >> On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: > > >> > From: Doug Ledford <dledford@redhat.com> > > >> > Sent: Wednesday, September 27, 2017 4:27 PM > > >> > > > >> > >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > > >> > >> Initialize the rdma_type (iWARP or RoCE) which is set > > >> > >> according to device configuration in qed. > > >> > >> > > >> > >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an > > >> > >> iWARP > > >> > >> device") > > >> > >> > > >> > >> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com> > > >> > >> Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com> > > >> > >> > > >> > >> --- > > >> > >> This patch applies cleanly on k.o/for-next-merged > > >> > >> > > >> > >> Changes from V0: > > >> > >> - Added Fixes in commit comment. > > >> > > > > >> > >Sorry, I was wrong in my email to the previous posting of this patch. > > >> > >I had pulled this v1 patch from patchworks, not the original > > >> > >patch, and so the Fixes: line was yours. Patchworks did not add > > >> > >the Fixes: line to the v0 patch when I downloaded it just now. > > >> > > > >> > >That being said, I still can't build with this patch ;-) > > >> > Are you building against the rdma-next branch ? > > >> > The patch requires the iWARP series, originally this was tested > > >> > against for-next-merged, what's the error you're getting ? > > >> > > >> On rdma-next: > > >> drivers/infiniband/hw/qedr/main.c: In function âqedr_addâ: > > >> drivers/infiniband/hw/qedr/main.c:780:7: error: âstruct qedr_devâ has > no member named ârdma_typeâ; did you mean ârdma_ctxâ? > > >> dev->rdma_type = dev_info.rdma_type; > > >> ^~~~~~~~~ > > >> rdma_ctx > > >> make[4]: *** [scripts/Makefile.build:311: > > >> drivers/infiniband/hw/qedr/main.o] Error 1 > > > > > >My config: > > > > > >â linux-rdma git:(rdma-next) grep QED .config CONFIG_QED=m > > >CONFIG_QED_LL2=y CONFIG_QED_SRIOV=y CONFIG_QEDE=m > CONFIG_QED_RDMA=y > > >CONFIG_INFINIBAND_QEDR=m > > > > Thanks Leon for helping out with this. Unfortunately i'm not seeing this. > > The rdma_type field was added with the following patch: > > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/dledford/rdma > > /+/e6a38c54faf38498170e227c82ea25cb8bc1ae71 > > > > When running git log on the k.o/for-next I see the patch (last in list > > below), applying this patch on top of rdma-next works for me and > compiles cleanly. > > > > 2e2f2d0 RDMA/qedr: Fix rdma_type initialization > > 1848757 Merge branches 'hns' and 'misc' into k.o/for-next 931bc0d IB: > > Move PCI dependency from root KConfig to HW's KConfigs 7ae6f2a Merge > > branch 'qedr' into k.o/for-next > > bd491d2 RDMA/qedr: fix build error without ipv6 > > 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() > > 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" > > 69ad0e7 RDMA/qedr: Add support for iWARP in user space > > e411e05 RDMA/qedr: Add iWARP connection management functions > de0089e > > RDMA/qedr: Add iWARP connection management qp related callbacks > > fb1a22b RDMA/qedr: Add support for read with invalidate, supported in > > iWARP > > f5b1b17 RDMA/qedr: Add iWARP support in existing verbs > > e6a38c5 RDMA/qedr: Add support for registering an iWARP device > > > > am i missing something ? > > I refreshed my branches now and it worked, but your git log history looks > strange. Where did you see the commit 1848757 and 931bc0d? git://github.com/dledford/linux.git git log --oneline -- drivers/infiniband/hw/qedr https://github.com/dledford/linux/commit/1848757c3d8bff3addf881c8bcc2b85e25ccf25e I was under the assumption a patch goes to github before k.o - is this not the case ? Thanks again, Doug - are you still seeing issues with this patch ? Thanks, Michal > > https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git/log/?h=k > .o/for-next > Age Commit message (Expand) Author Files Lines > 3 days Merge branch 'qedr' into k.o/for-nextfor-nextk.o/for-next Doug > Ledford 11 -91/+1208 > 3 days Merge tag 'v4.14-rc2' into k.o/for-next Doug Ledford 12044 - > 388475/+631018 > 3 days Linux 4.14-rc2HEADmaster Linus Torvalds 1 -1/+1 > > â linux-rdma git:(iwarp-compile) git log --oneline f3506957237b (HEAD -> > iwarp-compile) RDMA/qedr: Fix rdma_type initialization > 7ae6f2a3d552 (rdma/k.o/for-next, grdma/k.o/for-next) Merge branch 'qedr' > into k.o/for-next > 0d9c2ff1c9f7 Merge tag 'v4.14-rc2' into k.o/for-next e19b205be43d (tag: > v4.14-rc2, rdma/master, origin/master, ml/master, grdma/master, > grdma/hns, backup/master, master) Linux 4.14-rc2 > > Thanks > > > thanks, > > Michal > > N§²æìr¸yúèØb²X¬¶Ç§vØ^)Þº{.nÇ+·¥{±Ù{ayº\x1dÊÚë,j\a¢f£¢·h»öì\x17/oSc¾Ú³9uÀ¦æåÈ&jw¨®\x03(éÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þàþf£¢·h§~m ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>]
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> @ 2017-09-28 6:49 ` Leon Romanovsky [not found] ` <20170928064955.GP2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-09-28 14:05 ` Doug Ledford 1 sibling, 1 reply; 12+ messages in thread From: Leon Romanovsky @ 2017-09-28 6:49 UTC (permalink / raw) To: Kalderon, Michal Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Attachment #1: Type: text/plain, Size: 1679 bytes --] On Thu, Sep 28, 2017 at 06:22:59AM +0000, Kalderon, Michal wrote: > > > > > > When running git log on the k.o/for-next I see the patch (last in list > > > below), applying this patch on top of rdma-next works for me and > > compiles cleanly. > > > > > > 2e2f2d0 RDMA/qedr: Fix rdma_type initialization > > > 1848757 Merge branches 'hns' and 'misc' into k.o/for-next 931bc0d IB: > > > Move PCI dependency from root KConfig to HW's KConfigs 7ae6f2a Merge > > > branch 'qedr' into k.o/for-next > > > bd491d2 RDMA/qedr: fix build error without ipv6 > > > 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() > > > 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" > > > 69ad0e7 RDMA/qedr: Add support for iWARP in user space > > > e411e05 RDMA/qedr: Add iWARP connection management functions > > de0089e > > > RDMA/qedr: Add iWARP connection management qp related callbacks > > > fb1a22b RDMA/qedr: Add support for read with invalidate, supported in > > > iWARP > > > f5b1b17 RDMA/qedr: Add iWARP support in existing verbs > > > e6a38c5 RDMA/qedr: Add support for registering an iWARP device > > > > > > am i missing something ? > > > > I refreshed my branches now and it worked, but your git log history looks > > strange. Where did you see the commit 1848757 and 931bc0d? > > git://github.com/dledford/linux.git > git log --oneline -- drivers/infiniband/hw/qedr > https://github.com/dledford/linux/commit/1848757c3d8bff3addf881c8bcc2b85e25ccf25e > > I was under the assumption a patch goes to github before k.o - is this not the case ? Repo on github is Doug's private repository, while it is much safer to stick with one official on kernel.org. Thanks [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20170928064955.GP2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* RE: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <20170928064955.GP2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-09-28 6:51 ` Kalderon, Michal 0 siblings, 0 replies; 12+ messages in thread From: Kalderon, Michal @ 2017-09-28 6:51 UTC (permalink / raw) To: Leon Romanovsky Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel > From: Leon Romanovsky [mailto:leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] > Sent: Thursday, September 28, 2017 9:50 AM > > On Thu, Sep 28, 2017 at 06:22:59AM +0000, Kalderon, Michal wrote: > > > > > > > > When running git log on the k.o/for-next I see the patch (last in > > > > list below), applying this patch on top of rdma-next works for me > > > > and > > > compiles cleanly. > > > > > > > > 2e2f2d0 RDMA/qedr: Fix rdma_type initialization > > > > 1848757 Merge branches 'hns' and 'misc' into k.o/for-next 931bc0d IB: > > > > Move PCI dependency from root KConfig to HW's KConfigs 7ae6f2a > > > > Merge branch 'qedr' into k.o/for-next > > > > bd491d2 RDMA/qedr: fix build error without ipv6 > > > > 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() > > > > 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" > > > > 69ad0e7 RDMA/qedr: Add support for iWARP in user space > > > > e411e05 RDMA/qedr: Add iWARP connection management functions > > > de0089e > > > > RDMA/qedr: Add iWARP connection management qp related callbacks > > > > fb1a22b RDMA/qedr: Add support for read with invalidate, supported > > > > in iWARP > > > > f5b1b17 RDMA/qedr: Add iWARP support in existing verbs > > > > e6a38c5 RDMA/qedr: Add support for registering an iWARP device > > > > > > > > am i missing something ? > > > > > > I refreshed my branches now and it worked, but your git log history > > > looks strange. Where did you see the commit 1848757 and 931bc0d? > > > > git://github.com/dledford/linux.git > > git log --oneline -- drivers/infiniband/hw/qedr > > > https://github.com/dledford/linux/commit/1848757c3d8bff3addf881c8bcc2b > > 85e25ccf25e > > > > I was under the assumption a patch goes to github before k.o - is this not > the case ? > > Repo on github is Doug's private repository, while it is much safer to stick > with one official on kernel.org. > > Thanks Ok, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-09-28 6:49 ` Leon Romanovsky @ 2017-09-28 14:05 ` Doug Ledford 1 sibling, 0 replies; 12+ messages in thread From: Doug Ledford @ 2017-09-28 14:05 UTC (permalink / raw) To: Kalderon, Michal, Leon Romanovsky Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel [-- Attachment #1.1: Type: text/plain, Size: 5861 bytes --] On 9/28/2017 2:22 AM, Kalderon, Michal wrote: >> From: Leon Romanovsky [mailto:leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] >> Sent: Thursday, September 28, 2017 6:27 AM >> On Wed, Sep 27, 2017 at 08:33:38PM +0000, Kalderon, Michal wrote: >>> From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >>> Sent: Wednesday, September 27, 2017 7:56 PM On Wed, Sep 27, 2017 at >>> 07:53:39PM +0300, Leon Romanovsky wrote: >>>>> On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote: >>>>>> From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>>>>> Sent: Wednesday, September 27, 2017 4:27 PM >>>>>> >>>>>>> On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: >>>>>>>> Initialize the rdma_type (iWARP or RoCE) which is set >>>>>>>> according to device configuration in qed. >>>>>>>> >>>>>>>> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an >>>>>>>> iWARP >>>>>>>> device") >>>>>>>> >>>>>>>> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> >>>>>>>> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> >>>>>>>> >>>>>>>> --- >>>>>>>> This patch applies cleanly on k.o/for-next-merged >>>>>>>> >>>>>>>> Changes from V0: >>>>>>>> - Added Fixes in commit comment. >>>>>>> >>>>>>> Sorry, I was wrong in my email to the previous posting of this patch. >>>>>>> I had pulled this v1 patch from patchworks, not the original >>>>>>> patch, and so the Fixes: line was yours. Patchworks did not add >>>>>>> the Fixes: line to the v0 patch when I downloaded it just now. >>>>>> >>>>>>> That being said, I still can't build with this patch ;-) >>>>>> Are you building against the rdma-next branch ? >>>>>> The patch requires the iWARP series, originally this was tested >>>>>> against for-next-merged, what's the error you're getting ? >>>>> >>>>> On rdma-next: >>>>> drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’: >>>>> drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has >> no member named ‘rdma_type’; did you mean ‘rdma_ctx’? >>>>> dev->rdma_type = dev_info.rdma_type; >>>>> ^~~~~~~~~ >>>>> rdma_ctx >>>>> make[4]: *** [scripts/Makefile.build:311: >>>>> drivers/infiniband/hw/qedr/main.o] Error 1 >>>> >>>> My config: >>>> >>>> ➜ linux-rdma git:(rdma-next) grep QED .config CONFIG_QED=m >>>> CONFIG_QED_LL2=y CONFIG_QED_SRIOV=y CONFIG_QEDE=m >> CONFIG_QED_RDMA=y >>>> CONFIG_INFINIBAND_QEDR=m >>> >>> Thanks Leon for helping out with this. Unfortunately i'm not seeing this. >>> The rdma_type field was added with the following patch: >>> >> https://kernel.googlesource.com/pub/scm/linux/kernel/git/dledford/rdma >>> /+/e6a38c54faf38498170e227c82ea25cb8bc1ae71 >>> >>> When running git log on the k.o/for-next I see the patch (last in list >>> below), applying this patch on top of rdma-next works for me and >> compiles cleanly. >>> >>> 2e2f2d0 RDMA/qedr: Fix rdma_type initialization >>> 1848757 Merge branches 'hns' and 'misc' into k.o/for-next 931bc0d IB: >>> Move PCI dependency from root KConfig to HW's KConfigs 7ae6f2a Merge >>> branch 'qedr' into k.o/for-next >>> bd491d2 RDMA/qedr: fix build error without ipv6 >>> 89fd257 RDMA/qedr: Missing error code in qedr_init_user_queue() >>> 847cb1a RDMA/qedr: fix spelling mistake: "invlaid" -> "invalid" >>> 69ad0e7 RDMA/qedr: Add support for iWARP in user space >>> e411e05 RDMA/qedr: Add iWARP connection management functions >> de0089e >>> RDMA/qedr: Add iWARP connection management qp related callbacks >>> fb1a22b RDMA/qedr: Add support for read with invalidate, supported in >>> iWARP >>> f5b1b17 RDMA/qedr: Add iWARP support in existing verbs >>> e6a38c5 RDMA/qedr: Add support for registering an iWARP device >>> >>> am i missing something ? >> >> I refreshed my branches now and it worked, but your git log history looks >> strange. Where did you see the commit 1848757 and 931bc0d? > > git://github.com/dledford/linux.git > git log --oneline -- drivers/infiniband/hw/qedr > https://github.com/dledford/linux/commit/1848757c3d8bff3addf881c8bcc2b85e25ccf25e > > I was under the assumption a patch goes to github before k.o - is this not the case ? It does. I always send things to github first, wait for 0day testing results, then send it to k.o if it passes. However, what is important here, is that if it *doesn't* pass 0day testing, then I will rebase the branch to fix the broken patch in some cases. Once a patch series lands on k.o, if it's broken, we will either revert or incrementally patch things. > Thanks again, > > Doug - are you still seeing issues with this patch ? I'll recheck today. > Thanks, > Michal > >> >> https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git/log/?h=k >> .o/for-next >> Age Commit message (Expand) Author Files Lines >> 3 days Merge branch 'qedr' into k.o/for-nextfor-nextk.o/for-next Doug >> Ledford 11 -91/+1208 >> 3 days Merge tag 'v4.14-rc2' into k.o/for-next Doug Ledford 12044 - >> 388475/+631018 >> 3 days Linux 4.14-rc2HEADmaster Linus Torvalds 1 -1/+1 >> >> ➜ linux-rdma git:(iwarp-compile) git log --oneline f3506957237b (HEAD -> >> iwarp-compile) RDMA/qedr: Fix rdma_type initialization >> 7ae6f2a3d552 (rdma/k.o/for-next, grdma/k.o/for-next) Merge branch 'qedr' >> into k.o/for-next >> 0d9c2ff1c9f7 Merge tag 'v4.14-rc2' into k.o/for-next e19b205be43d (tag: >> v4.14-rc2, rdma/master, origin/master, ml/master, grdma/master, >> grdma/hns, backup/master, master) Linux 4.14-rc2 >> >> Thanks >> >>> thanks, >>> Michal >>> -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 884 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization [not found] ` <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-09-27 16:18 ` Kalderon, Michal @ 2017-09-29 15:22 ` Doug Ledford 1 sibling, 0 replies; 12+ messages in thread From: Doug Ledford @ 2017-09-29 15:22 UTC (permalink / raw) To: Michal Kalderon, leon-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ariel Elior On Wed, 2017-09-27 at 09:27 -0400, Doug Ledford wrote: > On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote: > > Initialize the rdma_type (iWARP or RoCE) which is set according to > > device configuration in qed. > > > > Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an > > iWARP > > device") > > > > Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > > Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > > > > --- > > This patch applies cleanly on k.o/for-next-merged > > > > Changes from V0: > > - Added Fixes in commit comment. > > Sorry, I was wrong in my email to the previous posting of this > patch. > I had pulled this v1 patch from patchworks, not the original patch, > and > so the Fixes: line was yours. Patchworks did not add the Fixes: line > to the v0 patch when I downloaded it just now. > > That being said, I still can't build with this patch ;-) OK, the build failure was my fault. As this was a minor patch, I had lumped it into a bundle I labeled as "misc". That by itself is fine, but I then applied that to a clean for-next head of v4.14-rc2, without the merge of the qedr branch, and so the build failed. Putting this into a branch with the qedr patches already merged resolves the issue. So, thanks, applied. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-09-29 15:22 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-20 5:39 [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization Michal Kalderon [not found] ` <1505885986-5873-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> 2017-09-27 13:27 ` Doug Ledford [not found] ` <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-09-27 16:18 ` Kalderon, Michal [not found] ` <CY1PR0701MB20126E3E86A45619079DFCAC88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-09-27 16:53 ` Leon Romanovsky [not found] ` <20170927165339.GI2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-09-27 16:56 ` Leon Romanovsky [not found] ` <20170927165610.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-09-27 20:33 ` Kalderon, Michal [not found] ` <CY1PR0701MB2012A41A0744D17AD3CD10DB88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-09-28 3:27 ` Leon Romanovsky [not found] ` <20170928032725.GO2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-09-28 6:22 ` Kalderon, Michal [not found] ` <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-09-28 6:49 ` Leon Romanovsky [not found] ` <20170928064955.GP2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-09-28 6:51 ` Kalderon, Michal 2017-09-28 14:05 ` Doug Ledford 2017-09-29 15:22 ` Doug Ledford
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).