* [PATCH] infiniband: ulp: Remove unnecessary struct declaration
@ 2021-04-15 9:21 Wan Jiabing
2021-04-15 9:47 ` Christoph Lameter
2021-04-20 19:09 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-04-15 9:21 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe, Kamal Heib, Alaa Hleihel,
Wan Jiabing, Valentine Fatiev, Christoph Lameter, linux-rdma,
linux-kernel
Cc: kael_w
struct ipoib_cm_tx is defined at 245th line.
And the definition is independent on the MACRO.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index 179ff1d068e5..d255aa69ba6d 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -677,8 +677,6 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc);
void ipoib_cm_handle_tx_wc(struct net_device *dev, struct ib_wc *wc);
#else
-struct ipoib_cm_tx;
-
#define ipoib_max_conn_qp 0
static inline int ipoib_cm_admin_enabled(struct net_device *dev)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration
2021-04-15 9:21 [PATCH] infiniband: ulp: Remove unnecessary struct declaration Wan Jiabing
@ 2021-04-15 9:47 ` Christoph Lameter
2021-04-20 19:09 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2021-04-15 9:47 UTC (permalink / raw)
To: Wan Jiabing
Cc: Doug Ledford, Jason Gunthorpe, Kamal Heib, Alaa Hleihel,
Valentine Fatiev, linux-rdma, linux-kernel, kael_w
On Thu, 15 Apr 2021, Wan Jiabing wrote:
> struct ipoib_cm_tx is defined at 245th line.
> And the definition is independent on the MACRO.
> The declaration here is unnecessary. Remove it.
Correct.
Reviewed-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration
2021-04-15 9:21 [PATCH] infiniband: ulp: Remove unnecessary struct declaration Wan Jiabing
2021-04-15 9:47 ` Christoph Lameter
@ 2021-04-20 19:09 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-04-20 19:09 UTC (permalink / raw)
To: Wan Jiabing
Cc: Doug Ledford, Kamal Heib, Alaa Hleihel, Valentine Fatiev,
Christoph Lameter, linux-rdma, linux-kernel, kael_w
On Thu, Apr 15, 2021 at 05:21:16PM +0800, Wan Jiabing wrote:
> struct ipoib_cm_tx is defined at 245th line.
> And the definition is independent on the MACRO.
> The declaration here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> Reviewed-by: Christoph Lameter <cl@linux.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-20 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 9:21 [PATCH] infiniband: ulp: Remove unnecessary struct declaration Wan Jiabing
2021-04-15 9:47 ` Christoph Lameter
2021-04-20 19:09 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).