* [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
@ 2019-01-22 15:25 ` Biju Das
2019-01-22 17:13 ` Laurent Pinchart
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
` (3 subsequent siblings)
4 siblings, 1 reply; 19+ messages in thread
From: Biju Das @ 2019-01-22 15:25 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
The internal LVDS encoder now has DT bindings separate from the DU. Port
the device tree over to the new model.
Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver")
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 36 ++++++++++++++++++++++++++++++------
1 file changed, 30 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 24e6c2b..de981d6 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1660,15 +1660,12 @@
du: display@feb00000 {
compatible = "renesas,du-r8a7743";
- reg = <0 0xfeb00000 0 0x40000>,
- <0 0xfeb90000 0 0x1c>;
- reg-names = "du", "lvds.0";
+ reg = <0 0xfeb00000 0 0x40000>;
interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 724>,
- <&cpg CPG_MOD 723>,
- <&cpg CPG_MOD 726>;
- clock-names = "du.0", "du.1", "lvds.0";
+ <&cpg CPG_MOD 723>;
+ clock-names = "du.0", "du.1";
status = "disabled";
ports {
@@ -1683,6 +1680,33 @@
port@1 {
reg = <1>;
du_out_lvds0: endpoint {
+ remote-endpoint = <&lvds0_in>;
+ };
+ };
+ };
+ };
+
+ lvds0: lvds@feb90000 {
+ compatible = "renesas,r8a7743-lvds";
+ reg = <0 0xfeb90000 0 0x1c>;
+ clocks = <&cpg CPG_MOD 726>;
+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+ resets = <&cpg 726>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ lvds0_in: endpoint {
+ remote-endpoint = <&du_out_lvds0>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ lvds0_out: endpoint {
};
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings
2019-01-22 15:25 ` [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings Biju Das
@ 2019-01-22 17:13 ` Laurent Pinchart
2019-01-23 9:01 ` Simon Horman
0 siblings, 1 reply; 19+ messages in thread
From: Laurent Pinchart @ 2019-01-22 17:13 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Simon Horman, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:45PM +0000, Biju Das wrote:
> The internal LVDS encoder now has DT bindings separate from the DU. Port
> the device tree over to the new model.
>
> Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver")
Sorry for the breakage. The DT and DU series raced each other, but I
should have still caught it.
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I expect Simon to pick this up.
> ---
> arch/arm/boot/dts/r8a7743.dtsi | 36 ++++++++++++++++++++++++++++++------
> 1 file changed, 30 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 24e6c2b..de981d6 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1660,15 +1660,12 @@
>
> du: display@feb00000 {
> compatible = "renesas,du-r8a7743";
> - reg = <0 0xfeb00000 0 0x40000>,
> - <0 0xfeb90000 0 0x1c>;
> - reg-names = "du", "lvds.0";
> + reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 726>;
> - clock-names = "du.0", "du.1", "lvds.0";
> + <&cpg CPG_MOD 723>;
> + clock-names = "du.0", "du.1";
> status = "disabled";
>
> ports {
> @@ -1683,6 +1680,33 @@
> port@1 {
> reg = <1>;
> du_out_lvds0: endpoint {
> + remote-endpoint = <&lvds0_in>;
> + };
> + };
> + };
> + };
> +
> + lvds0: lvds@feb90000 {
> + compatible = "renesas,r8a7743-lvds";
> + reg = <0 0xfeb90000 0 0x1c>;
> + clocks = <&cpg CPG_MOD 726>;
> + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> + resets = <&cpg 726>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + lvds0_in: endpoint {
> + remote-endpoint = <&du_out_lvds0>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + lvds0_out: endpoint {
> };
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings
2019-01-22 17:13 ` Laurent Pinchart
@ 2019-01-23 9:01 ` Simon Horman
0 siblings, 0 replies; 19+ messages in thread
From: Simon Horman @ 2019-01-23 9:01 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
On Tue, Jan 22, 2019 at 07:13:25PM +0200, Laurent Pinchart wrote:
> Hi Biju,
>
> Thank you for the patch.
>
> On Tue, Jan 22, 2019 at 03:25:45PM +0000, Biju Das wrote:
> > The internal LVDS encoder now has DT bindings separate from the DU. Port
> > the device tree over to the new model.
> >
> > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver")
>
> Sorry for the breakage. The DT and DU series raced each other, but I
> should have still caught it.
>
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I expect Simon to pick this up.
Thanks, applied as a fix for v5.0 as the fixes tag indicates the breakage
occurred in v4.17.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
2019-01-22 15:25 ` [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings Biju Das
@ 2019-01-22 15:25 ` Biju Das
2019-01-22 15:44 ` Laurent Pinchart
2019-01-30 16:39 ` Rob Herring
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
` (2 subsequent siblings)
4 siblings, 2 replies; 19+ messages in thread
From: Biju Das @ 2019-01-22 15:25 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Document the RZ/G1N (R8A7744) LVDS bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
index 27a054e..900a884 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
@@ -8,6 +8,7 @@ Required properties:
- compatible : Shall contain one of
- "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
+ - "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
- "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
- "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
- "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
@ 2019-01-22 15:44 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
2019-01-30 16:39 ` Rob Herring
2019-01-30 16:39 ` Rob Herring
1 sibling, 2 replies; 19+ messages in thread
From: Laurent Pinchart @ 2019-01-22 15:44 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:46PM +0000, Biju Das wrote:
> Document the RZ/G1N (R8A7744) LVDS bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 27a054e..900a884 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -8,6 +8,7 @@ Required properties:
>
> - compatible : Shall contain one of
> - "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
> + - "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
> - "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
> - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
> - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-22 15:44 ` Laurent Pinchart
@ 2019-01-23 8:59 ` Simon Horman
2019-01-30 16:39 ` Rob Herring
1 sibling, 0 replies; 19+ messages in thread
From: Simon Horman @ 2019-01-23 8:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Jan 22, 2019 at 05:44:28PM +0200, Laurent Pinchart wrote:
> Hi Biju,
>
> Thank you for the patch.
>
> On Tue, Jan 22, 2019 at 03:25:46PM +0000, Biju Das wrote:
> > Document the RZ/G1N (R8A7744) LVDS bindings.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and taken in my tree.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > index 27a054e..900a884 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > @@ -8,6 +8,7 @@ Required properties:
> >
> > - compatible : Shall contain one of
> > - "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
> > + - "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
> > - "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
> > - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
> > - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-22 15:44 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
@ 2019-01-30 16:39 ` Rob Herring
2019-02-01 15:16 ` Laurent Pinchart
1 sibling, 1 reply; 19+ messages in thread
From: Rob Herring @ 2019-01-30 16:39 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Biju Das, David Airlie, Daniel Vetter, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
On Tue, Jan 22, 2019 at 05:44:28PM +0200, Laurent Pinchart wrote:
> Hi Biju,
>
> Thank you for the patch.
>
> On Tue, Jan 22, 2019 at 03:25:46PM +0000, Biju Das wrote:
> > Document the RZ/G1N (R8A7744) LVDS bindings.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and taken in my tree.
But not in linux-next? Or you did some $subject fixups which breaks my
detecting that. :(
Rob
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-30 16:39 ` Rob Herring
@ 2019-02-01 15:16 ` Laurent Pinchart
0 siblings, 0 replies; 19+ messages in thread
From: Laurent Pinchart @ 2019-02-01 15:16 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, David Airlie, Daniel Vetter, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Rob,
On Wed, Jan 30, 2019 at 10:39:10AM -0600, Rob Herring wrote:
> On Tue, Jan 22, 2019 at 05:44:28PM +0200, Laurent Pinchart wrote:
> > On Tue, Jan 22, 2019 at 03:25:46PM +0000, Biju Das wrote:
> >> Document the RZ/G1N (R8A7744) LVDS bindings.
> >>
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > and taken in my tree.
>
> But not in linux-next? Or you did some $subject fixups which breaks my
> detecting that. :(
My tree isn't part of linux-next. I'll send a pull reques to Dave very
soon.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
2019-01-22 15:44 ` Laurent Pinchart
@ 2019-01-30 16:39 ` Rob Herring
1 sibling, 0 replies; 19+ messages in thread
From: Rob Herring @ 2019-01-30 16:39 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Mark Rutland, Biju Das,
Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc,
devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
On Tue, 22 Jan 2019 15:25:46 +0000, Biju Das wrote:
> Document the RZ/G1N (R8A7744) LVDS bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
2019-01-22 15:25 ` [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings Biju Das
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
@ 2019-01-22 15:25 ` Biju Das
2019-01-22 15:45 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support Biju Das
2019-01-22 15:25 ` [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support Biju Das
4 siblings, 2 replies; 19+ messages in thread
From: Biju Das @ 2019-01-22 15:25 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
The LVDS encoders on RZ/G1N SoC is similar to RZ/G1M. Add support for
RZ/G1N (R8A7744) SoC to the LVDS encoder driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 96d749a..caea2c5 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
static const struct of_device_id rcar_lvds_of_table[] = {
{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
+ { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
@ 2019-01-22 15:45 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
1 sibling, 0 replies; 19+ messages in thread
From: Laurent Pinchart @ 2019-01-22 15:45 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:47PM +0000, Biju Das wrote:
> The LVDS encoders on RZ/G1N SoC is similar to RZ/G1M. Add support for
> RZ/G1N (R8A7744) SoC to the LVDS encoder driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 96d749a..caea2c5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
>
> static const struct of_device_id rcar_lvds_of_table[] = {
> { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> + { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
> { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
> { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> --
> 2.7.4
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
2019-01-22 15:45 ` Laurent Pinchart
@ 2019-01-23 8:59 ` Simon Horman
1 sibling, 0 replies; 19+ messages in thread
From: Simon Horman @ 2019-01-23 8:59 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Jan 22, 2019 at 03:25:47PM +0000, Biju Das wrote:
> The LVDS encoders on RZ/G1N SoC is similar to RZ/G1M. Add support for
> RZ/G1N (R8A7744) SoC to the LVDS encoder driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 96d749a..caea2c5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
>
> static const struct of_device_id rcar_lvds_of_table[] = {
> { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> + { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
> { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
> { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
` (2 preceding siblings ...)
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
@ 2019-01-22 15:25 ` Biju Das
2019-01-22 17:07 ` Laurent Pinchart
2019-01-22 15:25 ` [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support Biju Das
4 siblings, 1 reply; 19+ messages in thread
From: Biju Das @ 2019-01-22 15:25 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Add du node to r8a7744 SoC DT. Boards that want to enable the DU
need to specify the output topology.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
arch/arm/boot/dts/r8a7744.dtsi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
index 8d25a0a..83804aa 100644
--- a/arch/arm/boot/dts/r8a7744.dtsi
+++ b/arch/arm/boot/dts/r8a7744.dtsi
@@ -1645,8 +1645,14 @@
};
du: display@feb00000 {
- reg = <0 0xfeb00000 0 0x40000>,
- <0 0xfeb90000 0 0x1c>;
+ compatible = "renesas,du-r8a7744";
+ reg = <0 0xfeb00000 0 0x40000>;
+ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 724>,
+ <&cpg CPG_MOD 723>;
+ clock-names = "du.0", "du.1";
+ status = "disabled";
ports {
#address-cells = <1>;
@@ -1663,7 +1669,6 @@
};
};
};
- /* placeholder */
};
prr: chipid@ff000044 {
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support
2019-01-22 15:25 ` [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support Biju Das
@ 2019-01-22 17:07 ` Laurent Pinchart
2019-01-23 9:02 ` Simon Horman
0 siblings, 1 reply; 19+ messages in thread
From: Laurent Pinchart @ 2019-01-22 17:07 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:48PM +0000, Biju Das wrote:
> Add du node to r8a7744 SoC DT. Boards that want to enable the DU
> need to specify the output topology.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I expect Simon to pick this up.
> ---
> arch/arm/boot/dts/r8a7744.dtsi | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
> index 8d25a0a..83804aa 100644
> --- a/arch/arm/boot/dts/r8a7744.dtsi
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -1645,8 +1645,14 @@
> };
>
> du: display@feb00000 {
> - reg = <0 0xfeb00000 0 0x40000>,
> - <0 0xfeb90000 0 0x1c>;
> + compatible = "renesas,du-r8a7744";
> + reg = <0 0xfeb00000 0 0x40000>;
> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>;
> + clock-names = "du.0", "du.1";
> + status = "disabled";
>
> ports {
> #address-cells = <1>;
> @@ -1663,7 +1669,6 @@
> };
> };
> };
> - /* placeholder */
> };
>
> prr: chipid@ff000044 {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support
2019-01-22 17:07 ` Laurent Pinchart
@ 2019-01-23 9:02 ` Simon Horman
0 siblings, 0 replies; 19+ messages in thread
From: Simon Horman @ 2019-01-23 9:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
Kieran Bingham, dri-devel, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Jan 22, 2019 at 07:07:51PM +0200, Laurent Pinchart wrote:
> Hi Biju,
>
> Thank you for the patch.
>
> On Tue, Jan 22, 2019 at 03:25:48PM +0000, Biju Das wrote:
> > Add du node to r8a7744 SoC DT. Boards that want to enable the DU
> > need to specify the output topology.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I expect Simon to pick this up.
Thanks, applied for v5.1.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
` (3 preceding siblings ...)
2019-01-22 15:25 ` [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support Biju Das
@ 2019-01-22 15:25 ` Biju Das
2019-01-22 17:14 ` Laurent Pinchart
4 siblings, 1 reply; 19+ messages in thread
From: Biju Das @ 2019-01-22 15:25 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Add LVDS encoder node to r8a7744 SoC DT.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
arch/arm/boot/dts/r8a7744.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
index 83804aa..fa74a26 100644
--- a/arch/arm/boot/dts/r8a7744.dtsi
+++ b/arch/arm/boot/dts/r8a7744.dtsi
@@ -1666,6 +1666,33 @@
port@1 {
reg = <1>;
du_out_lvds0: endpoint {
+ remote-endpoint = <&lvds0_in>;
+ };
+ };
+ };
+ };
+
+ lvds0: lvds@feb90000 {
+ compatible = "renesas,r8a7744-lvds";
+ reg = <0 0xfeb90000 0 0x1c>;
+ clocks = <&cpg CPG_MOD 726>;
+ power-domains = <&sysc R8A7744_PD_ALWAYS_ON>;
+ resets = <&cpg 726>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ lvds0_in: endpoint {
+ remote-endpoint = <&du_out_lvds0>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ lvds0_out: endpoint {
};
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support
2019-01-22 15:25 ` [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support Biju Das
@ 2019-01-22 17:14 ` Laurent Pinchart
2019-01-23 9:03 ` Simon Horman
0 siblings, 1 reply; 19+ messages in thread
From: Laurent Pinchart @ 2019-01-22 17:14 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Simon Horman, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:49PM +0000, Biju Das wrote:
> Add LVDS encoder node to r8a7744 SoC DT.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I expect Simon to pick this up.
> ---
> arch/arm/boot/dts/r8a7744.dtsi | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
> index 83804aa..fa74a26 100644
> --- a/arch/arm/boot/dts/r8a7744.dtsi
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -1666,6 +1666,33 @@
> port@1 {
> reg = <1>;
> du_out_lvds0: endpoint {
> + remote-endpoint = <&lvds0_in>;
> + };
> + };
> + };
> + };
> +
> + lvds0: lvds@feb90000 {
> + compatible = "renesas,r8a7744-lvds";
> + reg = <0 0xfeb90000 0 0x1c>;
> + clocks = <&cpg CPG_MOD 726>;
> + power-domains = <&sysc R8A7744_PD_ALWAYS_ON>;
> + resets = <&cpg 726>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + lvds0_in: endpoint {
> + remote-endpoint = <&du_out_lvds0>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + lvds0_out: endpoint {
> };
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support
2019-01-22 17:14 ` Laurent Pinchart
@ 2019-01-23 9:03 ` Simon Horman
0 siblings, 0 replies; 19+ messages in thread
From: Simon Horman @ 2019-01-23 9:03 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
On Tue, Jan 22, 2019 at 07:14:11PM +0200, Laurent Pinchart wrote:
> Hi Biju,
>
> Thank you for the patch.
>
> On Tue, Jan 22, 2019 at 03:25:49PM +0000, Biju Das wrote:
> > Add LVDS encoder node to r8a7744 SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I expect Simon to pick this up.
Thanks, applied for v5.1.
^ permalink raw reply [flat|nested] 19+ messages in thread