Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] media: fdp1: Support M3N and E3 platforms
@ 2019-05-15 15:39 Kieran Bingham
  2019-05-16 10:36 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Kieran Bingham @ 2019-05-15 15:39 UTC (permalink / raw)
  To: linux-media, linux-renesas-soc, Mauro Carvalho Chehab
  Cc: Laurent Pinchart, Kieran Bingham

New Gen3 R-Car platforms incorporate the FDP1 with an updated version
register. No code change is required to support these targets, but they
will currently report an error stating that the device can not be
identified.

Update the driver to match against the new device types.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/media/platform/rcar_fdp1.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
index 6bda1eee9170..4f103be215d3 100644
--- a/drivers/media/platform/rcar_fdp1.c
+++ b/drivers/media/platform/rcar_fdp1.c
@@ -257,6 +257,8 @@ MODULE_PARM_DESC(debug, "activate debug info");
 #define FD1_IP_H3_ES1			0x02010101
 #define FD1_IP_M3W			0x02010202
 #define FD1_IP_H3			0x02010203
+#define FD1_IP_M3N			0x02010204
+#define FD1_IP_E3			0x02010205
 
 /* LUTs */
 #define FD1_LUT_DIF_ADJ			0x1000
@@ -2365,6 +2367,12 @@ static int fdp1_probe(struct platform_device *pdev)
 	case FD1_IP_H3:
 		dprintk(fdp1, "FDP1 Version R-Car H3\n");
 		break;
+	case FD1_IP_M3N:
+		dprintk(fdp1, "FDP1 Version R-Car M3N\n");
+		break;
+	case FD1_IP_E3:
+		dprintk(fdp1, "FDP1 Version R-Car E3\n");
+		break;
 	default:
 		dev_err(fdp1->dev, "FDP1 Unidentifiable (0x%08x)\n",
 				hw_version);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: fdp1: Support M3N and E3 platforms
  2019-05-15 15:39 [PATCH] media: fdp1: Support M3N and E3 platforms Kieran Bingham
@ 2019-05-16 10:36 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2019-05-16 10:36 UTC (permalink / raw)
  To: Kieran Bingham; +Cc: linux-media, linux-renesas-soc, Mauro Carvalho Chehab

Hi Kieran,

Thank you for the patch.

On Wed, May 15, 2019 at 04:39:12PM +0100, Kieran Bingham wrote:
> New Gen3 R-Car platforms incorporate the FDP1 with an updated version
> register. No code change is required to support these targets, but they
> will currently report an error stating that the device can not be
> identified.
> 
> Update the driver to match against the new device types.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/media/platform/rcar_fdp1.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 6bda1eee9170..4f103be215d3 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -257,6 +257,8 @@ MODULE_PARM_DESC(debug, "activate debug info");
>  #define FD1_IP_H3_ES1			0x02010101
>  #define FD1_IP_M3W			0x02010202
>  #define FD1_IP_H3			0x02010203
> +#define FD1_IP_M3N			0x02010204
> +#define FD1_IP_E3			0x02010205
>  
>  /* LUTs */
>  #define FD1_LUT_DIF_ADJ			0x1000
> @@ -2365,6 +2367,12 @@ static int fdp1_probe(struct platform_device *pdev)
>  	case FD1_IP_H3:
>  		dprintk(fdp1, "FDP1 Version R-Car H3\n");
>  		break;
> +	case FD1_IP_M3N:
> +		dprintk(fdp1, "FDP1 Version R-Car M3N\n");
> +		break;
> +	case FD1_IP_E3:
> +		dprintk(fdp1, "FDP1 Version R-Car E3\n");
> +		break;
>  	default:
>  		dev_err(fdp1->dev, "FDP1 Unidentifiable (0x%08x)\n",
>  				hw_version);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 15:39 [PATCH] media: fdp1: Support M3N and E3 platforms Kieran Bingham
2019-05-16 10:36 ` Laurent Pinchart

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox