From: Rob Herring <robh@kernel.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Felipe Balbi <balbi@kernel.org>,
Simon Horman <horms@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH v6 7/7] arm64: dts: renesas: r8a774c0-cat874: Enable usb role switch support
Date: Fri, 24 May 2019 16:50:50 -0500 [thread overview]
Message-ID: <20190524215050.GA23538@bogus> (raw)
In-Reply-To: <1557922152-16449-8-git-send-email-biju.das@bp.renesas.com>
On Wed, May 15, 2019 at 01:09:12PM +0100, Biju Das wrote:
> This patch enables TI HD3SS3220 device and support usb role switch
> for the CAT 874 platform.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> V5-->V6
> * No change
> V4-->V5
> * No change
> V3-->V4
> * No change
> V2-->V3
> * Used "renesas,usb-role-switch" instead of generic "usb-role-switch"
> property
> V1-->V2
> * New patch
> ---
> arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 39 +++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index b9ae7db..124ed58 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -85,6 +85,34 @@
> clock-frequency = <48000000>;
> };
>
> +&i2c0 {
> + status = "okay";
> + clock-frequency = <100000>;
> +
> + hd3ss3220@47 {
> + compatible = "ti,hd3ss3220";
> + reg = <0x47>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + };
> +
> + port {
port should be a child of 'connector' node. It should also be port #1 if
this is a SuperSpeed controller. Port #0 is HS.
As there are multiple ports possible, there should be a 'ports' node
too.
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hd3ss3220_ep: endpoint@0 {
> + reg = <0>;
Don't need reg when there is only 1. Build your dtb with W=1 as that
will tell you this.
> + remote-endpoint = <&usb3peri_role_switch>;
> + };
> + };
> + };
> +};
> +
> &i2c1 {
> pinctrl-0 = <&i2c1_pins>;
> pinctrl-names = "default";
> @@ -175,6 +203,17 @@
> &usb3_peri0 {
> companion = <&xhci0>;
> status = "okay";
> + usb-role-switch;
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + usb3peri_role_switch: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&hd3ss3220_ep>;
> + };
> + };
> };
>
> &xhci0 {
> --
> 2.7.4
>
prev parent reply other threads:[~2019-05-24 21:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 12:09 [PATCH v6 0/7] Add USB3.0 and TI HD3SS3220 driver support Biju Das
2019-05-15 12:09 ` [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das
2019-05-15 16:09 ` Sergei Shtylyov
2019-05-21 9:42 ` Biju Das
2019-05-21 8:03 ` Yoshihiro Shimoda
2019-05-21 8:08 ` Kuninori Morimoto
2019-05-22 10:59 ` Biju Das
2019-05-23 5:18 ` Yoshihiro Shimoda
2019-05-23 8:56 ` Biju Das
2019-05-15 12:09 ` [PATCH v6 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Biju Das
2019-05-21 8:27 ` Yoshihiro Shimoda
2019-05-28 7:25 ` Biju Das
2019-05-15 12:09 ` [PATCH v6 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das
2019-05-15 12:09 ` [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role switch support Biju Das
2019-05-16 3:16 ` Chunfeng Yun
2019-05-16 8:00 ` Biju Das
2019-05-21 5:49 ` Yoshihiro Shimoda
2019-05-21 7:10 ` Biju Das
2019-05-21 7:34 ` Yoshihiro Shimoda
2019-05-15 12:09 ` [PATCH v6 5/7] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das
2019-05-15 12:09 ` [PATCH v6 6/7] arm64: dts: renesas: r8a774c0-cat874: Enable USB3.0 host/peripheral device node Biju Das
2019-05-15 12:09 ` [PATCH v6 7/7] arm64: dts: renesas: r8a774c0-cat874: Enable usb role switch support Biju Das
2019-05-24 21:50 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524215050.GA23538@bogus \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=balbi@kernel.org \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).