linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	"xu_shunji@hoperun.com" <xu_shunji@hoperun.com>
Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
Date: Wed, 19 Jun 2019 14:18:08 +0200	[thread overview]
Message-ID: <20190619121808.hnqoeihjch6silcd@verge.net.au> (raw)
In-Reply-To: <TY1PR01MB1770F9972F006B57917A0731C0E50@TY1PR01MB1770.jpnprd01.prod.outlook.com>

On Wed, Jun 19, 2019 at 08:16:43AM +0000, Fabrizio Castro wrote:
> Hello Geert,
> 
> Thank you for your feedback
> 
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > Sent: 19 June 2019 08:34
> > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> > 
> > Hi Fabrizio,
> > 
> > On Tue, Jun 18, 2019 at 5:56 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > > > Sent: 18 June 2019 16:10
> > > > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> > > >
> > > > On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > > > > common device tree.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > > @@ -17,6 +17,30 @@
> > > > >                 stdout-path = "serial0:115200n8";
> > > > >         };
> > > > >
> > > > > +       leds {
> > > > > +               compatible = "gpio-leds";
> > > > > +
> > > > > +               led0 {
> > > > > +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> > > > > +                       label = "LED0";
> > > >
> > > > There's no need for a label property, if it matches the node name
> > > > (applies to all four LEDs).
> > >
> > > I could have used the actual names on the schematic, but then I realised that
> > > would not have been too helpful due to the corresponding switch names:
> > > LED0 - GP6_11 - SW2202 - LED2201
> > > LED1 - GP6_12 - SW2201 - LED2202
> > > LED2 - GP6_13 - SW2203 - LED2203
> > > LED3 - GP0_00 - N/A - LED2402
> > > The first 3 LEDs are found next to the micro USB connector for the debug console,
> > > the forth LED is found next to the WiFi and BT LEDs.
> > >
> > > I thought that using "LEDn" as labels would put a remark on the
> > > "desired ordering" of the LEDs (even though there is no actual
> > > requirement for that), but as you pointed out it's probably a bit
> > > confusing? Do you think I should take the label out?
> > 
> > If the LEDs don't have nice labels on the PCB, I would drop the label
> > properties.
> 
> Will do. Simon, do you want me to send an incremental patch for this (this patch
> is on devel branch already) or would you rather I sent a v2?

Please send an incremental patch, thanks.

  reply	other threads:[~2019-06-19 12:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 13:14 [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support Fabrizio Castro
2019-06-17  9:33 ` Simon Horman
2019-06-18 10:40   ` Simon Horman
2019-06-18 15:10 ` Geert Uytterhoeven
2019-06-18 15:56   ` Fabrizio Castro
2019-06-19  7:33     ` Geert Uytterhoeven
2019-06-19  8:16       ` Fabrizio Castro
2019-06-19 12:18         ` Simon Horman [this message]
2019-06-19 14:11           ` Fabrizio Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619121808.hnqoeihjch6silcd@verge.net.au \
    --to=horms@verge.net.au \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=xu_shunji@hoperun.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).