linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Herring <robh+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Prabhakar <prabhakar.csengg@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v3 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver
Date: Thu, 22 Jul 2021 04:34:15 +0800	[thread overview]
Message-ID: <202107220431.yxFduKDb-lkp@intel.com> (raw)
In-Reply-To: <20210721191558.22484-3-prabhakar.mahadev-lad.rj@bp.renesas.com>

[-- Attachment #1: Type: text/plain, Size: 2778 bytes --]

Hi Lad,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 2734d6c1b1a089fb593ef6a23d4b70903526fe0c]

url:    https://github.com/0day-ci/linux/commits/Lad-Prabhakar/pin-and-gpio-controller-driver-for-Renesas-RZ-G2L/20210722-031725
base:   2734d6c1b1a089fb593ef6a23d4b70903526fe0c
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8735b74e6bbde5d76a49d014d4d1e1d901f7f370
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lad-Prabhakar/pin-and-gpio-controller-driver-for-Renesas-RZ-G2L/20210722-031725
        git checkout 8735b74e6bbde5d76a49d014d4d1e1d901f7f370
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function 'rzg2l_pinctrl_set_mux':
>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:185:16: warning: variable 'data' set but not used [-Wunused-but-set-variable]
     185 |  unsigned long data;
         |                ^~~~


vim +/data +185 drivers/pinctrl/renesas/pinctrl-rzg2l.c

   176	
   177	static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,
   178					 unsigned int func_selector,
   179					 unsigned int group_selector)
   180	{
   181		struct rzg2l_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
   182		struct function_desc *func;
   183		unsigned int i, *psel_val;
   184		struct group_desc *group;
 > 185		unsigned long data;
   186		int *pins;
   187	
   188		func = pinmux_generic_get_function(pctldev, func_selector);
   189		if (!func)
   190			return -EINVAL;
   191		group = pinctrl_generic_get_group(pctldev, group_selector);
   192		if (!group)
   193			return -EINVAL;
   194	
   195		psel_val = func->data;
   196		pins = group->pins;
   197		data = (unsigned long)group->data;
   198	
   199		for (i = 0; i < group->num_pins; i++) {
   200			dev_dbg(pctrl->dev, "port:%u pin: %u PSEL:%u\n",
   201				RZG2L_PIN_ID_TO_PORT(pins[i]), RZG2L_PIN_ID_TO_PIN(pins[i]),
   202				psel_val[i]);
   203			rzg2l_pinctrl_set_pfc_mode(pctrl, RZG2L_PIN_ID_TO_PORT(pins[i]),
   204						   RZG2L_PIN_ID_TO_PIN(pins[i]), psel_val[i]);
   205		}
   206	
   207		return 0;
   208	};
   209	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60078 bytes --]

  reply	other threads:[~2021-07-21 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 19:15 [PATCH v3 0/4] pin and gpio controller driver for Renesas RZ/G2L Lad Prabhakar
2021-07-21 19:15 ` [PATCH v3 1/4] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Add DT bindings for RZ/G2L pinctrl Lad Prabhakar
2021-07-22 14:37   ` Rob Herring
2021-07-27  9:26     ` Lad, Prabhakar
2021-07-27 14:42       ` Rob Herring
2021-07-27 14:43   ` Rob Herring
2021-07-21 19:15 ` [PATCH v3 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver Lad Prabhakar
2021-07-21 20:34   ` kernel test robot [this message]
2021-07-26 13:25   ` Geert Uytterhoeven
2021-07-26 13:34     ` Andy Shevchenko
2021-07-26 16:03       ` Lad, Prabhakar
2021-07-26 16:02     ` Lad, Prabhakar
2021-07-21 19:15 ` [PATCH v3 3/4] arm64: dts: renesas: r9a07g044: Add pinctrl node Lad Prabhakar
2021-07-21 19:15 ` [PATCH v3 4/4] arm64: dts: renesas: rzg2l-smarc: Add scif0 pins Lad Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202107220431.yxFduKDb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kbuild-all@lists.01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v3 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).