* [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
@ 2020-07-22 3:28 Gustavo A. R. Silva
2020-07-31 9:08 ` Yoshihiro Shimoda
2020-09-07 14:18 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-22 3:28 UTC (permalink / raw)
To: Geert Uytterhoeven, Marek Vasut, Yoshihiro Shimoda,
Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas
Cc: linux-pci, linux-renesas-soc, linux-kernel, Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v2:
- Update URL. Use proper URL to Linux v5.7 documentation.
- Add Geert's Reviewed-by tag.
- Update changelog text.
drivers/pci/controller/pci-rcar-gen2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
index 326171cb1a97..2ec7093a7588 100644
--- a/drivers/pci/controller/pci-rcar-gen2.c
+++ b/drivers/pci/controller/pci-rcar-gen2.c
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
pr_warn("unknown window size %ld - defaulting to 256M\n",
priv->window_size);
priv->window_size = SZ_256M;
- /* fall-through */
+ fallthrough;
case SZ_256M:
val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
2020-07-22 3:28 [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-07-31 9:08 ` Yoshihiro Shimoda
2020-09-07 14:18 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2020-07-31 9:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Geert Uytterhoeven, Marek Vasut,
Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas
Cc: linux-pci, linux-renesas-soc, linux-kernel, Gustavo A. R. Silva
Hi,
> From: Gustavo A. R. Silva, Sent: Wednesday, July 22, 2020 12:29 PM
>
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1]
> https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
2020-07-22 3:28 [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-31 9:08 ` Yoshihiro Shimoda
@ 2020-09-07 14:18 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-07 14:18 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Geert Uytterhoeven, Marek Vasut, Yoshihiro Shimoda, Rob Herring,
Bjorn Helgaas, linux-pci, linux-renesas-soc, linux-kernel,
Gustavo A. R. Silva
On Tue, Jul 21, 2020 at 10:28:51PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
> - Update URL. Use proper URL to Linux v5.7 documentation.
> - Add Geert's Reviewed-by tag.
> - Update changelog text.
>
> drivers/pci/controller/pci-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/rcar, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 326171cb1a97..2ec7093a7588 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
> pr_warn("unknown window size %ld - defaulting to 256M\n",
> priv->window_size);
> priv->window_size = SZ_256M;
> - /* fall-through */
> + fallthrough;
> case SZ_256M:
> val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
> break;
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-07 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 3:28 [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-31 9:08 ` Yoshihiro Shimoda
2020-09-07 14:18 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).