From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: Add support for hardware trip points
Date: Thu, 7 Jul 2022 14:37:24 +0200 [thread overview]
Message-ID: <b92b3011-15b9-9390-5804-feb0650e255b@linaro.org> (raw)
In-Reply-To: <Ysa033e3BnH+wVBM@oden.dyn.berto.se>
On 07/07/2022 12:26, Niklas Söderlund wrote:
> Hi Daniel,
>
> On 2022-07-07 11:55:55 +0200, Daniel Lezcano wrote:
>
>> Thanks for double checking and confirming. I've a patch removing this code,
>> no need to send one. I'll submit it along with other changes around this.
>> Perhaps, I'll try a revert before, it would make more sense.
>
> Thanks.
>
> To be clear I don't think we should revert commit 47cf09e0f4fc5120
> ("thermal/drivers/rcar_gen3_thermal: Add support for hardware trip
> points"). Only remove the 4 lines it adds to rcar_gen3_thermal_resume()
> as they are redundant. Does this match your view of the revert?
Yes
>> Do you think the 'revert' should be backported ?
>
> I have no strong opinion, I think it's a matter of risk :-)
>
> There is no real harm in writing the trip points to hardware twice
> during resume. On the other hand if we *know* the thermal core in the
> backported kernel will always call set_trips() after the device is
> resumed, then there is no harm in removing it.
Yes, I agree.
Thanks for your feedback
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-07-07 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 9:18 [PATCH v2 0/2] thermal: rcar_gen3_thermal: Add support for trip points Niklas Söderlund
2021-08-04 9:18 ` [PATCH v2 1/2] thermal: rcar_gen3_thermal: Add support for hardware " Niklas Söderlund
2022-07-06 11:13 ` Daniel Lezcano
2022-07-07 9:51 ` Niklas Söderlund
2022-07-07 9:55 ` Daniel Lezcano
2022-07-07 10:26 ` Niklas Söderlund
2022-07-07 12:37 ` Daniel Lezcano [this message]
2021-08-04 9:18 ` [PATCH v2 2/2] thermal: rcar_gen3_thermal: Store TSC id as unsigned int Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92b3011-15b9-9390-5804-feb0650e255b@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).