From: Logan Gunthorpe <logang@deltatee.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Arnd Bergmann <arnd@arndb.de>,
linux-sh@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-riscv@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 2/2] mm/sparse: add common helper to mark all memblocks present
Date: Wed, 7 Nov 2018 13:19:08 -0700 [thread overview]
Message-ID: <724be9bb-59b6-33f3-7b59-3ca644d59bf7@deltatee.com> (raw)
Message-ID: <20181107201908.gGcaz0tuI7yMOl7W7fLpH-_d6XAA4oFGccDtlvDrXX8@z> (raw)
In-Reply-To: <20181107121207.62cb37cf58484b7cc80a8fd8@linux-foundation.org>
On 2018-11-07 1:12 p.m., Andrew Morton wrote:
>> +void __init memblocks_present(void)
>> +{
>> + struct memblock_region *reg;
>> +
>> + for_each_memblock(memory, reg) {
>> + memory_present(memblock_get_region_node(reg),
>> + memblock_region_memory_base_pfn(reg),
>> + memblock_region_memory_end_pfn(reg));
>> + }
>> +}
>> +
>
> I don't like the name much. To me, memblocks_present means "are
> memblocks present" whereas this actually means "memblocks are present".
> But whatever. A little covering comment which describes what this
> does and why it does it would be nice.
The same argument can be made about the existing memory_present()
function and I think it's worth keeping the naming consistent. I'll add
a comment and resend shortly.
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
>
> I can grab both patches and shall sneak them into 4.20-rcX, but feel
> free to merge them into some git tree if you'd prefer. If I see them
> turn up in linux-next I shall drop my copy.
Sounds good, thanks.
Logan
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-07 20:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 17:38 [PATCH 0/2] Introduce common code for risc-v sparsemem support Logan Gunthorpe
2018-11-07 17:38 ` Logan Gunthorpe
2018-11-07 17:38 ` [PATCH 1/2] mm: Introduce common STRUCT_PAGE_MAX_SHIFT define Logan Gunthorpe
2018-11-07 17:38 ` Logan Gunthorpe
2018-11-07 20:11 ` Andrew Morton
2018-11-07 20:11 ` Andrew Morton
2018-11-07 17:38 ` [PATCH 2/2] mm/sparse: add common helper to mark all memblocks present Logan Gunthorpe
2018-11-07 17:38 ` Logan Gunthorpe
2018-11-07 20:12 ` Andrew Morton
2018-11-07 20:12 ` Andrew Morton
2018-11-07 20:19 ` Logan Gunthorpe [this message]
2018-11-07 20:19 ` Logan Gunthorpe
2018-11-07 20:26 ` Thomas Gleixner
2018-11-07 20:26 ` Thomas Gleixner
2018-11-07 20:36 ` Logan Gunthorpe
2018-11-07 20:36 ` Logan Gunthorpe
2018-11-07 20:38 ` Andrew Morton
2018-11-07 20:38 ` Andrew Morton
2018-11-07 20:56 ` Thomas Gleixner
2018-11-07 20:56 ` Thomas Gleixner
2018-12-06 17:40 ` Logan Gunthorpe
2018-12-07 19:56 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724be9bb-59b6-33f3-7b59-3ca644d59bf7@deltatee.com \
--to=logang@deltatee.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=palmer@sifive.com \
--cc=sbates@raithlin.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).