From: quentin.schulz@bootlin.com (Quentin Schulz) To: linux-riscv@lists.infradead.org Subject: [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config Date: Tue, 20 Nov 2018 15:17:05 +0100 [thread overview] Message-ID: <20181120141705.44odry44hhdy3cge@qschulz> (raw) In-Reply-To: <mvm5zwrn8zu.fsf@suse.de> Hi Andreas, On Tue, Nov 20, 2018 at 03:01:25PM +0100, Andreas Schwab wrote: > On Nov 20 2018, Quentin Schulz <quentin.schulz@bootlin.com> wrote: > > > You also need to prefix your patch with [PATCH net-next] instead of only > > [PATCH]. This is specific to the net subsystem. > > Why next? This is a bug fix that needs to go in now, not next. > Indeed. Use [PATCH net] then. Please refer to https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt > > Use scripts/get_maintainer.pl on your patch to get the people to put in > > Cc and in To. > > The same people as the original patch the added the bug. Why would it > be different now? > First, people may have changed mail addresses (especially maintainers) and that is picked by get_maintainer. Second, other people may have worked on this driver since the patch was introduced and they might want to know about this change too and have their word on it. This is what happened with this driver. Gustavo and Heiner sent patches since then and they have already been merged. This is also part of the contribution process which is defined here: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html You have not answered my question yet. Does this fix your issue, yes or no? Quentin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20181120/8b0ae393/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Schulz <quentin.schulz@bootlin.com> To: Andreas Schwab <schwab@suse.de> Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, allan.nielsen@microchip.com, thomas.petazzoni@bootlin.com, linux-riscv@lists.infradead.org, davem@davemloft.net Subject: Re: [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config Date: Tue, 20 Nov 2018 15:17:05 +0100 [thread overview] Message-ID: <20181120141705.44odry44hhdy3cge@qschulz> (raw) Message-ID: <20181120141705.jkolB9BEfED91zB80wphy-UMkP-X13Vtv9Ozl9c2Qnc@z> (raw) In-Reply-To: <mvm5zwrn8zu.fsf@suse.de> [-- Attachment #1.1: Type: text/plain, Size: 1309 bytes --] Hi Andreas, On Tue, Nov 20, 2018 at 03:01:25PM +0100, Andreas Schwab wrote: > On Nov 20 2018, Quentin Schulz <quentin.schulz@bootlin.com> wrote: > > > You also need to prefix your patch with [PATCH net-next] instead of only > > [PATCH]. This is specific to the net subsystem. > > Why next? This is a bug fix that needs to go in now, not next. > Indeed. Use [PATCH net] then. Please refer to https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt > > Use scripts/get_maintainer.pl on your patch to get the people to put in > > Cc and in To. > > The same people as the original patch the added the bug. Why would it > be different now? > First, people may have changed mail addresses (especially maintainers) and that is picked by get_maintainer. Second, other people may have worked on this driver since the patch was introduced and they might want to know about this change too and have their word on it. This is what happened with this driver. Gustavo and Heiner sent patches since then and they have already been merged. This is also part of the contribution process which is defined here: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html You have not answered my question yet. Does this fix your issue, yes or no? Quentin [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-20 14:17 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20181008100728.24959-1-quentin.schulz@bootlin.com> [not found] ` <20181008100728.24959-2-quentin.schulz@bootlin.com> 2018-11-19 14:57 ` [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions Andreas Schwab 2018-11-19 14:57 ` Andreas Schwab 2018-11-19 15:10 ` Andrew Lunn 2018-11-19 15:10 ` Andrew Lunn 2018-11-19 15:13 ` Andreas Schwab 2018-11-19 15:13 ` Andreas Schwab 2018-11-19 15:28 ` Andrew Lunn 2018-11-19 15:28 ` Andrew Lunn 2018-11-19 15:40 ` Alexandre Belloni 2018-11-19 15:40 ` Alexandre Belloni 2018-11-19 15:50 ` Andreas Schwab 2018-11-19 15:50 ` Andreas Schwab 2018-11-19 16:12 ` Andrew Lunn 2018-11-19 16:12 ` Andrew Lunn 2018-11-19 16:14 ` Andreas Schwab 2018-11-19 16:14 ` Andreas Schwab 2018-11-19 16:25 ` Andrew Lunn 2018-11-19 16:25 ` Andrew Lunn 2018-11-19 16:32 ` Andreas Schwab 2018-11-19 16:32 ` Andreas Schwab 2018-11-19 16:44 ` Andrew Lunn 2018-11-19 16:44 ` Andrew Lunn 2018-11-20 11:39 ` Andreas Schwab 2018-11-20 11:39 ` Andreas Schwab 2018-11-20 13:20 ` Quentin Schulz 2018-11-20 13:20 ` Quentin Schulz 2018-11-20 13:48 ` [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config Andreas Schwab 2018-11-20 13:48 ` Andreas Schwab 2018-11-20 13:55 ` Quentin Schulz 2018-11-20 13:55 ` Quentin Schulz 2018-11-20 14:01 ` Andreas Schwab 2018-11-20 14:01 ` Andreas Schwab 2018-11-20 14:17 ` Quentin Schulz [this message] 2018-11-20 14:17 ` Quentin Schulz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181120141705.44odry44hhdy3cge@qschulz \ --to=quentin.schulz@bootlin.com \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).