Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
@ 2019-05-13 21:30 Paul Walmsley
  2019-05-19 21:25 ` Pavel Machek
  2019-05-21 18:34 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Walmsley @ 2019-05-13 21:30 UTC (permalink / raw)
  To: sboyd, mturquette, pavel
  Cc: linux-riscv, Paul Walmsley, Paul Walmsley, linux-kernel, linux-clk

Restrict Kconfig scope for SiFive clock and reset IP block drivers
such that they won't appear on most configurations that are unlikely
to support them.  This is based on a suggestion from Pavel Machek
<pavel@ucw.cz>.  Ideally this should be dependent on
CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
exist, add dependencies on RISCV or COMPILE_TEST for now.

Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Reported-by: Pavel Machek <pavel@ucw.cz>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
---
This second version incorporates non-functional changes requested
by Stephen Boyd <sboyd@kernel.org>.

 drivers/clk/sifive/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
index 8db4a3eb4782..f3b4eb9cb0f5 100644
--- a/drivers/clk/sifive/Kconfig
+++ b/drivers/clk/sifive/Kconfig
@@ -2,6 +2,7 @@
 
 menuconfig CLK_SIFIVE
 	bool "SiFive SoC driver support"
+	depends on RISCV || COMPILE_TEST
 	help
 	  SoC drivers for SiFive Linux-capable SoCs.
 
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
  2019-05-13 21:30 [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
@ 2019-05-19 21:25 ` Pavel Machek
  2019-05-21 18:34 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2019-05-19 21:25 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: Paul Walmsley, sboyd, mturquette, linux-kernel, linux-riscv, linux-clk

[-- Attachment #1.1: Type: text/plain, Size: 1492 bytes --]

On Mon 2019-05-13 14:30:04, Paul Walmsley wrote:
> Restrict Kconfig scope for SiFive clock and reset IP block drivers
> such that they won't appear on most configurations that are unlikely
> to support them.  This is based on a suggestion from Pavel Machek
> <pavel@ucw.cz>.  Ideally this should be dependent on
> CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
> exist, add dependencies on RISCV or COMPILE_TEST for now.
> 
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>

Thanks for doing this.

Acked-by: Pavel Machek <pavel@ucw.cz>
									Pavel

> ---
> This second version incorporates non-functional changes requested
> by Stephen Boyd <sboyd@kernel.org>.
> 
>  drivers/clk/sifive/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
> index 8db4a3eb4782..f3b4eb9cb0f5 100644
> --- a/drivers/clk/sifive/Kconfig
> +++ b/drivers/clk/sifive/Kconfig
> @@ -2,6 +2,7 @@
>  
>  menuconfig CLK_SIFIVE
>  	bool "SiFive SoC driver support"
> +	depends on RISCV || COMPILE_TEST
>  	help
>  	  SoC drivers for SiFive Linux-capable SoCs.
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
  2019-05-13 21:30 [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
  2019-05-19 21:25 ` Pavel Machek
@ 2019-05-21 18:34 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-05-21 18:34 UTC (permalink / raw)
  To: Paul Walmsley, mturquette, pavel
  Cc: linux-riscv, Paul Walmsley, Paul Walmsley, linux-kernel, linux-clk

Quoting Paul Walmsley (2019-05-13 14:30:04)
> Restrict Kconfig scope for SiFive clock and reset IP block drivers
> such that they won't appear on most configurations that are unlikely
> to support them.  This is based on a suggestion from Pavel Machek
> <pavel@ucw.cz>.  Ideally this should be dependent on
> CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
> exist, add dependencies on RISCV or COMPILE_TEST for now.
> 
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> ---

Applied to clk-fixes


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 21:30 [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
2019-05-19 21:25 ` Pavel Machek
2019-05-21 18:34 ` Stephen Boyd

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox