* [PATCH] riscv: Fix udelay in RV32.
@ 2019-05-28 9:26 Nick Hu
2019-05-30 4:09 ` Palmer Dabbelt
2019-05-30 5:52 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Nick Hu @ 2019-05-28 9:26 UTC (permalink / raw)
To: greentime, palmer, linux-riscv, linux-kernel; +Cc: green.hu, Nick Hu
In RV32, udelay would delay the wrong cycle.
When it shifts right "UDELAY_SHITFT" bits, it
either delays 0 cycle or 1 cycle. It only works
correctly in RV64. Because the 'ucycles' always
needs to be 64 bits variable.
Signed-off-by: Nick Hu <nickhu@andestech.com>
---
arch/riscv/lib/delay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
index dce8ae24c6d3..da847f49fb74 100644
--- a/arch/riscv/lib/delay.c
+++ b/arch/riscv/lib/delay.c
@@ -88,7 +88,7 @@ EXPORT_SYMBOL(__delay);
void udelay(unsigned long usecs)
{
- unsigned long ucycles = usecs * lpj_fine * UDELAY_MULT;
+ unsigned long long ucycles = (unsigned long long)usecs * lpj_fine * UDELAY_MULT;
if (unlikely(usecs > MAX_UDELAY_US)) {
__delay((u64)usecs * riscv_timebase / 1000000ULL);
--
2.17.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: Fix udelay in RV32.
2019-05-28 9:26 [PATCH] riscv: Fix udelay in RV32 Nick Hu
@ 2019-05-30 4:09 ` Palmer Dabbelt
2019-05-30 5:52 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2019-05-30 4:09 UTC (permalink / raw)
To: nickhu; +Cc: green.hu, linux-riscv, linux-kernel, nickhu, greentime
On Tue, 28 May 2019 02:26:49 PDT (-0700), nickhu@andestech.com wrote:
> In RV32, udelay would delay the wrong cycle.
> When it shifts right "UDELAY_SHITFT" bits, it
> either delays 0 cycle or 1 cycle. It only works
> correctly in RV64. Because the 'ucycles' always
> needs to be 64 bits variable.
>
> Signed-off-by: Nick Hu <nickhu@andestech.com>
> ---
> arch/riscv/lib/delay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
> index dce8ae24c6d3..da847f49fb74 100644
> --- a/arch/riscv/lib/delay.c
> +++ b/arch/riscv/lib/delay.c
> @@ -88,7 +88,7 @@ EXPORT_SYMBOL(__delay);
>
> void udelay(unsigned long usecs)
> {
> - unsigned long ucycles = usecs * lpj_fine * UDELAY_MULT;
> + unsigned long long ucycles = (unsigned long long)usecs * lpj_fine * UDELAY_MULT;
>
> if (unlikely(usecs > MAX_UDELAY_US)) {
> __delay((u64)usecs * riscv_timebase / 1000000ULL);
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: Fix udelay in RV32.
2019-05-28 9:26 [PATCH] riscv: Fix udelay in RV32 Nick Hu
2019-05-30 4:09 ` Palmer Dabbelt
@ 2019-05-30 5:52 ` Christoph Hellwig
2019-05-30 6:32 ` Nick Hu
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-05-30 5:52 UTC (permalink / raw)
To: Nick Hu; +Cc: linux-riscv, palmer, linux-kernel, green.hu, greentime
On Tue, May 28, 2019 at 05:26:49PM +0800, Nick Hu wrote:
> In RV32, udelay would delay the wrong cycle.
> When it shifts right "UDELAY_SHITFT" bits, it
> either delays 0 cycle or 1 cycle. It only works
> correctly in RV64. Because the 'ucycles' always
> needs to be 64 bits variable.
Please use up all your ~72 chars per line in the commit log.
> diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
> index dce8ae24c6d3..da847f49fb74 100644
> --- a/arch/riscv/lib/delay.c
> +++ b/arch/riscv/lib/delay.c
> @@ -88,7 +88,7 @@ EXPORT_SYMBOL(__delay);
>
> void udelay(unsigned long usecs)
> {
> - unsigned long ucycles = usecs * lpj_fine * UDELAY_MULT;
> + unsigned long long ucycles = (unsigned long long)usecs * lpj_fine * UDELAY_MULT;
And this creates a way too long line. Pleaase use u64 instead of
unsigned long long to clarify the intention while also fixing the long
lines.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: Fix udelay in RV32.
2019-05-30 5:52 ` Christoph Hellwig
@ 2019-05-30 6:32 ` Nick Hu
0 siblings, 0 replies; 4+ messages in thread
From: Nick Hu @ 2019-05-30 6:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: linux-riscv, palmer, linux-kernel,
Greentime Ying-Han Hu(胡英漢),
green.hu
On Thu, May 30, 2019 at 01:52:58PM +0800, Christoph Hellwig wrote:
> On Tue, May 28, 2019 at 05:26:49PM +0800, Nick Hu wrote:
> > In RV32, udelay would delay the wrong cycle.
> > When it shifts right "UDELAY_SHITFT" bits, it
> > either delays 0 cycle or 1 cycle. It only works
> > correctly in RV64. Because the 'ucycles' always
> > needs to be 64 bits variable.
>
> Please use up all your ~72 chars per line in the commit log.
>
OK, Thanks!
> > diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
> > index dce8ae24c6d3..da847f49fb74 100644
> > --- a/arch/riscv/lib/delay.c
> > +++ b/arch/riscv/lib/delay.c
> > @@ -88,7 +88,7 @@ EXPORT_SYMBOL(__delay);
> >
> > void udelay(unsigned long usecs)
> > {
> > - unsigned long ucycles = usecs * lpj_fine * UDELAY_MULT;
> > + unsigned long long ucycles = (unsigned long long)usecs * lpj_fine * UDELAY_MULT;
>
> And this creates a way too long line. Pleaase use u64 instead of
> unsigned long long to clarify the intention while also fixing the long
> lines.
>
Sure, I will fix it and send another patch. Thanks.
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-30 6:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 9:26 [PATCH] riscv: Fix udelay in RV32 Nick Hu
2019-05-30 4:09 ` Palmer Dabbelt
2019-05-30 5:52 ` Christoph Hellwig
2019-05-30 6:32 ` Nick Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).