From: Rob Herring <robh@kernel.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"atish.patra@wdc.com" <atish.patra@wdc.com>,
"maz@kernel.org" <maz@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
Sagar Kadam <sagar.kadam@sifive.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Paul Walmsley \( Sifive\)" <paul.walmsley@sifive.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"bmeng.cn@gmail.com" <bmeng.cn@gmail.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Sachin Ghadi <sachin.ghadi@sifive.com>
Subject: Re: [PATCH 2/4] gpio: sifive: Add DT documentation for SiFive GPIO
Date: Mon, 18 Nov 2019 10:53:45 -0600 [thread overview]
Message-ID: <20191118165345.GA3935@bogus> (raw)
In-Reply-To: <1573560684-48104-3-git-send-email-yash.shah@sifive.com>
On Tue, Nov 12, 2019 at 12:12:06PM +0000, Yash Shah wrote:
> DT documentation for GPIO controller added.
>
> Signed-off-by: Wesley W. Terpstra <wesley@sifive.com>
> [Atish: Compatible string update]
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> .../devicetree/bindings/gpio/gpio-sifive.txt | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sifive.txt
Please make this a schema. See
Documentation/devicetree/writing-schema.rst.
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sifive.txt b/Documentation/devicetree/bindings/gpio/gpio-sifive.txt
> new file mode 100644
> index 0000000..d3416d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sifive.txt
> @@ -0,0 +1,33 @@
> +SiFive GPIO controller bindings
> +
> +Required properties:
> +- compatible: Should be "sifive,<chip>-gpio" and "sifive,gpio<version>".
> + Supported compatible strings are: "sifive,fu540-c000-gpio" for the SiFive
> + GPIO v0 as integrated onto the SiFive FU540 chip, and "sifive,gpio0" for the
> + SiFive GPIO v0 IP block with no chip integration tweaks.
> + Please refer to sifive-blocks-ip-versioning.txt for details.
> +- reg: Physical base address and length of the controller's registers.
> +- clocks: Should contain a clock identifier for the GPIO's parent clock.
> +- #gpio-cells : Should be 2
> + - The first cell is the GPIO offset number.
> + - The second cell indicates the polarity of the GPIO
> +- gpio-controller : Marks the device node as a GPIO controller.
> +- interrupt-controller: Marks the device node as an interrupt controller.
> +- #interrupt-cells : Should be 2.
> + - The first cell is the GPIO offset number within the GPIO controller.
> + - The second cell is the edge/level to use for interrupt generation.
> +- interrupts: Specify the interrupts, one per GPIO
How many GPIOs?
> +
> +Example:
> +
> +gpio: gpio@10060000 {
> + compatible = "sifive,fu540-c000-gpio","sifive,gpio0";
space ^
> + interrupt-parent = <&plic>;
> + interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
> + reg = <0x0 0x10060000 0x0 0x1000>;
> + clocks = <&tlclk>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +};
> --
> 2.7.4
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-11-18 16:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 12:11 [PATCH 0/4] GPIO & Hierarchy IRQ support for HiFive Unleashed Yash Shah
2019-11-12 12:11 ` [PATCH 1/4] irqchip: sifive: Support hierarchy irq domain Yash Shah
2019-11-12 12:43 ` Marc Zyngier
2019-11-18 7:14 ` Yash Shah
2019-11-12 12:12 ` [PATCH 2/4] gpio: sifive: Add DT documentation for SiFive GPIO Yash Shah
2019-11-18 16:53 ` Rob Herring [this message]
2019-11-12 12:12 ` [PATCH 3/4] gpio: sifive: Add GPIO driver for SiFive SoCs Yash Shah
2019-11-12 12:58 ` Marc Zyngier
2019-11-18 7:50 ` Yash Shah
2019-11-13 13:10 ` Bartosz Golaszewski
2019-11-18 10:03 ` Yash Shah
2019-11-18 10:15 ` Bartosz Golaszewski
2019-11-19 15:02 ` Linus Walleij
2019-11-19 16:41 ` Bartosz Golaszewski
2019-11-22 12:28 ` Linus Walleij
2019-11-22 12:39 ` Bartosz Golaszewski
2019-11-25 4:54 ` Yash Shah
2019-11-12 12:12 ` [PATCH 4/4] riscv: dts: Add DT support for SiFive FU540 GPIO driver Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118165345.GA3935@bogus \
--to=robh@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=bmeng.cn@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sachin.ghadi@sifive.com \
--cc=sagar.kadam@sifive.com \
--cc=tglx@linutronix.de \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).