From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
<ionela.voinescu@arm.com>, <pierre.gondois@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path
Date: Thu, 14 Jul 2022 16:10:36 +0000 [thread overview]
Message-ID: <50b3316b-aed0-2ef1-a7ff-69aa3991d7e4@microchip.com> (raw)
In-Reply-To: <20220714160016.honjpzg35ccq4fto@bogus>
On 14/07/2022 17:00, Sudeep Holla wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Jul 14, 2022 at 03:27:09PM +0000, Conor.Dooley@microchip.com wrote:
>> On 14/07/2022 16:01, Sudeep Holla wrote:
>>>
>>> Interesting, need to check if it is not in atomic context on arm64.
>>> Wonder if some configs are disabled and making this bug hidden. Let me
>>> check.
>>>
>
> OK, it turns I didn't have necessary config options enabled. Enabling
> them, I did see the BUG splat and changing allocation to GFP_ATOMIC
> fixed the same. Can you try that please so that you can test if other
> things are fine.
>
>>> One possible solution is to add GFP_ATOMIC to the allocation but I want
>>> to make sure if it is legal to be in atomic context when calling
>>> update_siblings_masks.
>>>
>
> So I take is as legal and needs to be fixed to push my patch.
>
With the GFP_ATOMIC, behaviour is the same as before for me.
Therefore, with the following diff & for RISC-V/DT:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index 65d566ff24c4..4b5cd08c5a65 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -356,7 +356,7 @@ int detect_cache_attributes(unsigned int cpu)
return -ENOENT;
per_cpu_cacheinfo(cpu) = kcalloc(cache_leaves(cpu),
- sizeof(struct cacheinfo), GFP_KERNEL);
+ sizeof(struct cacheinfo), GFP_ATOMIC);
if (per_cpu_cacheinfo(cpu) == NULL) {
cache_leaves(cpu) = 0;
return -ENOMEM;
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-14 16:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:33 [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path Sudeep Holla
2022-07-13 14:03 ` Greg Kroah-Hartman
2022-07-13 14:18 ` Sudeep Holla
2022-07-13 16:04 ` Conor.Dooley
2022-07-14 14:17 ` Conor.Dooley
2022-07-14 15:01 ` Sudeep Holla
2022-07-14 15:27 ` Conor.Dooley
2022-07-14 16:00 ` Sudeep Holla
2022-07-14 16:10 ` Conor.Dooley [this message]
2022-07-15 9:11 ` Sudeep Holla
2022-07-15 9:16 ` Conor.Dooley
2022-07-15 14:04 ` Conor.Dooley
2022-07-15 15:41 ` Sudeep Holla
2022-07-14 17:52 ` Ionela Voinescu
2022-07-18 17:41 ` Guenter Roeck
2022-07-18 17:57 ` Conor.Dooley
2022-07-19 10:29 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b3316b-aed0-2ef1-a7ff-69aa3991d7e4@microchip.com \
--to=conor.dooley@microchip.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pierre.gondois@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).