From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>, <linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <vincent.guittot@linaro.org>,
<dietmar.eggemann@arm.com>, <ionela.voinescu@arm.com>,
<pierre.gondois@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path
Date: Wed, 13 Jul 2022 16:04:39 +0000 [thread overview]
Message-ID: <56f0c3a4-74cd-098a-7bdb-88480be366c2@microchip.com> (raw)
In-Reply-To: <20220713133344.1201247-1-sudeep.holla@arm.com>
On 13/07/2022 14:33, Sudeep Holla wrote:
> Hi Conor,
>
> Ionela reported an issue with the CPU hotplug and as a fix I need to
> move the call to detect_cache_attributes() which I had thought to keep
> it there from first but for no reason had moved it to init_cpu_topology().
>
> Wonder if this fixes the -ENOMEM on RISC-V as this one is called on the
> cpu in the secondary CPUs init path while init_cpu_topology executed
> detect_cache_attributes() for all possible CPUs much earlier. I think
> this might help as the percpu memory might be initialised in this case.
>
> Anyways give this a try, also test the CPU hotplug and check if nothing
> is broken on RISC-V. We noticed this bug only on one platform while
Coll, will give it a go tomorrow probably. I have a swiotlb issue that's
broken my boot to find first :/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-13 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:33 [PATCH -next] arch_topology: Fix cache attributes detection in the CPU hotplug path Sudeep Holla
2022-07-13 14:03 ` Greg Kroah-Hartman
2022-07-13 14:18 ` Sudeep Holla
2022-07-13 16:04 ` Conor.Dooley [this message]
2022-07-14 14:17 ` Conor.Dooley
2022-07-14 15:01 ` Sudeep Holla
2022-07-14 15:27 ` Conor.Dooley
2022-07-14 16:00 ` Sudeep Holla
2022-07-14 16:10 ` Conor.Dooley
2022-07-15 9:11 ` Sudeep Holla
2022-07-15 9:16 ` Conor.Dooley
2022-07-15 14:04 ` Conor.Dooley
2022-07-15 15:41 ` Sudeep Holla
2022-07-14 17:52 ` Ionela Voinescu
2022-07-18 17:41 ` Guenter Roeck
2022-07-18 17:57 ` Conor.Dooley
2022-07-19 10:29 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f0c3a4-74cd-098a-7bdb-88480be366c2@microchip.com \
--to=conor.dooley@microchip.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pierre.gondois@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).