Linux-RISC-V Archive on lore.kernel.org
 help / Atom feed
* [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
@ 2018-11-26  6:08 anup
  2018-11-26  6:08 ` Anup Patel
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: anup @ 2018-11-26  6:08 UTC (permalink / raw)
  To: linux-riscv

The objcopy only emits loadable sections when creating flat kernel
Image. To have minimal possible size of flat kernel Image, we should
have all non-loadable sections after loadable sections.

Currently, execption table section (loadable section) is after BSS
section (non-loadable section) in the RISC-V vmlinux.lds.S. This
is not optimal for having minimal flat kernel Image size hence this
patch makes BSS section as the last section in RISC-V vmlinux.lds.S.

In addition, we make BSS section aligned to 16byte instead of PAGE
aligned which further reduces flat kernel Image size by few KBs.

The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
7991740 bytes with this patch applied using GCC 8.2.0. In summary,
this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.

Signed-off-by: Anup Patel <anup@brainfault.org>
---
 arch/riscv/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
index 65df1dfdc303..cc99eed44931 100644
--- a/arch/riscv/kernel/vmlinux.lds.S
+++ b/arch/riscv/kernel/vmlinux.lds.S
@@ -74,8 +74,6 @@ SECTIONS
 		*(.sbss*)
 	}
 
-	BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
-
 	EXCEPTION_TABLE(0x10)
 	NOTES
 
@@ -83,6 +81,8 @@ SECTIONS
 		*(.rel.dyn*)
 	}
 
+	BSS_SECTION(0x10, 0x10, 0x10)
+
 	_end = .;
 
 	STABS_DEBUG
-- 
2.17.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-11-26  6:08 [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S anup
@ 2018-11-26  6:08 ` Anup Patel
  2018-11-29  7:36 ` bmeng.cn
  2018-12-17  9:36 ` Anup Patel
  2 siblings, 0 replies; 9+ messages in thread
From: Anup Patel @ 2018-11-26  6:08 UTC (permalink / raw)
  To: Palmer Dabbelt, Albert Ou
  Cc: Christoph Hellwig, Atish Patra, linux-riscv, linux-kernel, Anup Patel

The objcopy only emits loadable sections when creating flat kernel
Image. To have minimal possible size of flat kernel Image, we should
have all non-loadable sections after loadable sections.

Currently, execption table section (loadable section) is after BSS
section (non-loadable section) in the RISC-V vmlinux.lds.S. This
is not optimal for having minimal flat kernel Image size hence this
patch makes BSS section as the last section in RISC-V vmlinux.lds.S.

In addition, we make BSS section aligned to 16byte instead of PAGE
aligned which further reduces flat kernel Image size by few KBs.

The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
7991740 bytes with this patch applied using GCC 8.2.0. In summary,
this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.

Signed-off-by: Anup Patel <anup@brainfault.org>
---
 arch/riscv/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
index 65df1dfdc303..cc99eed44931 100644
--- a/arch/riscv/kernel/vmlinux.lds.S
+++ b/arch/riscv/kernel/vmlinux.lds.S
@@ -74,8 +74,6 @@ SECTIONS
 		*(.sbss*)
 	}
 
-	BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
-
 	EXCEPTION_TABLE(0x10)
 	NOTES
 
@@ -83,6 +81,8 @@ SECTIONS
 		*(.rel.dyn*)
 	}
 
+	BSS_SECTION(0x10, 0x10, 0x10)
+
 	_end = .;
 
 	STABS_DEBUG
-- 
2.17.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-11-26  6:08 [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S anup
  2018-11-26  6:08 ` Anup Patel
@ 2018-11-29  7:36 ` bmeng.cn
  2018-11-29  7:36   ` Bin Meng
  2018-12-17  9:36 ` Anup Patel
  2 siblings, 1 reply; 9+ messages in thread
From: bmeng.cn @ 2018-11-29  7:36 UTC (permalink / raw)
  To: linux-riscv

On Mon, Nov 26, 2018 at 2:12 PM Anup Patel <anup@brainfault.org> wrote:
>
> The objcopy only emits loadable sections when creating flat kernel
> Image. To have minimal possible size of flat kernel Image, we should
> have all non-loadable sections after loadable sections.
>
> Currently, execption table section (loadable section) is after BSS
> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> is not optimal for having minimal flat kernel Image size hence this
> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
>
> In addition, we make BSS section aligned to 16byte instead of PAGE
> aligned which further reduces flat kernel Image size by few KBs.
>
> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-11-29  7:36 ` bmeng.cn
@ 2018-11-29  7:36   ` Bin Meng
  0 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2018-11-29  7:36 UTC (permalink / raw)
  To: Anup Patel; +Cc: aou, palmer, linux-kernel, hch, atish.patra, linux-riscv

On Mon, Nov 26, 2018 at 2:12 PM Anup Patel <anup@brainfault.org> wrote:
>
> The objcopy only emits loadable sections when creating flat kernel
> Image. To have minimal possible size of flat kernel Image, we should
> have all non-loadable sections after loadable sections.
>
> Currently, execption table section (loadable section) is after BSS
> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> is not optimal for having minimal flat kernel Image size hence this
> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
>
> In addition, we make BSS section aligned to 16byte instead of PAGE
> aligned which further reduces flat kernel Image size by few KBs.
>
> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-11-26  6:08 [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S anup
  2018-11-26  6:08 ` Anup Patel
  2018-11-29  7:36 ` bmeng.cn
@ 2018-12-17  9:36 ` Anup Patel
  2018-12-17 12:59   ` Nick Kossifidis
  2018-12-20 20:40   ` Palmer Dabbelt
  2 siblings, 2 replies; 9+ messages in thread
From: Anup Patel @ 2018-12-17  9:36 UTC (permalink / raw)
  To: Palmer Dabbelt, Albert Ou
  Cc: Christoph Hellwig, Atish Patra, linux-riscv,
	linux-kernel@vger.kernel.org List

On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org> wrote:
>
> The objcopy only emits loadable sections when creating flat kernel
> Image. To have minimal possible size of flat kernel Image, we should
> have all non-loadable sections after loadable sections.
>
> Currently, execption table section (loadable section) is after BSS
> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> is not optimal for having minimal flat kernel Image size hence this
> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
>
> In addition, we make BSS section aligned to 16byte instead of PAGE
> aligned which further reduces flat kernel Image size by few KBs.
>
> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
> index 65df1dfdc303..cc99eed44931 100644
> --- a/arch/riscv/kernel/vmlinux.lds.S
> +++ b/arch/riscv/kernel/vmlinux.lds.S
> @@ -74,8 +74,6 @@ SECTIONS
>                 *(.sbss*)
>         }
>
> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> -
>         EXCEPTION_TABLE(0x10)
>         NOTES
>
> @@ -83,6 +81,8 @@ SECTIONS
>                 *(.rel.dyn*)
>         }
>
> +       BSS_SECTION(0x10, 0x10, 0x10)
> +
>         _end = .;
>
>         STABS_DEBUG
> --
> 2.17.1
>

Hi All,

Any comment on this patch?

Regards,
Anup

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-12-17  9:36 ` Anup Patel
@ 2018-12-17 12:59   ` Nick Kossifidis
  2018-12-18  8:23     ` Anup Patel
  2018-12-20 20:40   ` Palmer Dabbelt
  1 sibling, 1 reply; 9+ messages in thread
From: Nick Kossifidis @ 2018-12-17 12:59 UTC (permalink / raw)
  To: Anup Patel
  Cc: Albert Ou, Palmer Dabbelt, linux-kernel@vger.kernel.org List,
	Christoph Hellwig, Atish Patra, linux-riscv

Στις 2018-12-17 11:36, Anup Patel έγραψε:
> On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org> 
> wrote:
>> 
>> The objcopy only emits loadable sections when creating flat kernel
>> Image. To have minimal possible size of flat kernel Image, we should
>> have all non-loadable sections after loadable sections.
>> 
>> Currently, execption table section (loadable section) is after BSS
>> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
>> is not optimal for having minimal flat kernel Image size hence this
>> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
>> 
>> In addition, we make BSS section aligned to 16byte instead of PAGE
>> aligned which further reduces flat kernel Image size by few KBs.
>> 
>> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
>> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
>> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
>> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
>> 
>> Signed-off-by: Anup Patel <anup@brainfault.org>
>> ---
>>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/riscv/kernel/vmlinux.lds.S 
>> b/arch/riscv/kernel/vmlinux.lds.S
>> index 65df1dfdc303..cc99eed44931 100644
>> --- a/arch/riscv/kernel/vmlinux.lds.S
>> +++ b/arch/riscv/kernel/vmlinux.lds.S
>> @@ -74,8 +74,6 @@ SECTIONS
>>                 *(.sbss*)
>>         }
>> 
>> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
>> -
>>         EXCEPTION_TABLE(0x10)
>>         NOTES
>> 
>> @@ -83,6 +81,8 @@ SECTIONS
>>                 *(.rel.dyn*)
>>         }
>> 
>> +       BSS_SECTION(0x10, 0x10, 0x10)
>> +
>>         _end = .;
>> 
>>         STABS_DEBUG
>> --
>> 2.17.1
>> 
> 
> Hi All,
> 
> Any comment on this patch?
> 
> Regards,
> Anup
> 

Just a note on coding style, you should be using a macro instead of 0x10 
so that those who read the code can understand what it is and also a few 
comments since searching through the commit logs to understand why you 
used it isn't optimal.

Regards,
Nick


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-12-17 12:59   ` Nick Kossifidis
@ 2018-12-18  8:23     ` Anup Patel
  0 siblings, 0 replies; 9+ messages in thread
From: Anup Patel @ 2018-12-18  8:23 UTC (permalink / raw)
  To: Nick Kossifidis
  Cc: Albert Ou, Palmer Dabbelt, linux-kernel@vger.kernel.org List,
	Christoph Hellwig, Atish Patra, linux-riscv

On Mon, Dec 17, 2018 at 6:29 PM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> Στις 2018-12-17 11:36, Anup Patel έγραψε:
> > On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org>
> > wrote:
> >>
> >> The objcopy only emits loadable sections when creating flat kernel
> >> Image. To have minimal possible size of flat kernel Image, we should
> >> have all non-loadable sections after loadable sections.
> >>
> >> Currently, execption table section (loadable section) is after BSS
> >> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> >> is not optimal for having minimal flat kernel Image size hence this
> >> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
> >>
> >> In addition, we make BSS section aligned to 16byte instead of PAGE
> >> aligned which further reduces flat kernel Image size by few KBs.
> >>
> >> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> >> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> >> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> >> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/riscv/kernel/vmlinux.lds.S
> >> b/arch/riscv/kernel/vmlinux.lds.S
> >> index 65df1dfdc303..cc99eed44931 100644
> >> --- a/arch/riscv/kernel/vmlinux.lds.S
> >> +++ b/arch/riscv/kernel/vmlinux.lds.S
> >> @@ -74,8 +74,6 @@ SECTIONS
> >>                 *(.sbss*)
> >>         }
> >>
> >> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> >> -
> >>         EXCEPTION_TABLE(0x10)
> >>         NOTES
> >>
> >> @@ -83,6 +81,8 @@ SECTIONS
> >>                 *(.rel.dyn*)
> >>         }
> >>
> >> +       BSS_SECTION(0x10, 0x10, 0x10)
> >> +
> >>         _end = .;
> >>
> >>         STABS_DEBUG
> >> --
> >> 2.17.1
> >>
> >
> > Hi All,
> >
> > Any comment on this patch?
> >
> > Regards,
> > Anup
> >
>
> Just a note on coding style, you should be using a macro instead of 0x10
> so that those who read the code can understand what it is and also a few
> comments since searching through the commit logs to understand why you
> used it isn't optimal.

RISC-V can support 32bit, 64bit and 128bit machine-word sizes.

The 0x10 number is the machine-word size in bytes for 128bit
RISC-V CPU (i.e. maximum machine-word size).

I will add a macro MAX_BYTES_PER_LONG in vmlinux.lds.S and
use it in-place of 0x10

Regards,
Anup

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-12-17  9:36 ` Anup Patel
  2018-12-17 12:59   ` Nick Kossifidis
@ 2018-12-20 20:40   ` Palmer Dabbelt
  2018-12-23 14:58     ` Anup Patel
  1 sibling, 1 reply; 9+ messages in thread
From: Palmer Dabbelt @ 2018-12-20 20:40 UTC (permalink / raw)
  To: anup; +Cc: Christoph Hellwig, atish.patra, linux-riscv, aou, linux-kernel

On Mon, 17 Dec 2018 01:36:45 PST (-0800), anup@brainfault.org wrote:
> On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org> wrote:
>>
>> The objcopy only emits loadable sections when creating flat kernel
>> Image. To have minimal possible size of flat kernel Image, we should
>> have all non-loadable sections after loadable sections.
>>
>> Currently, execption table section (loadable section) is after BSS
>> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
>> is not optimal for having minimal flat kernel Image size hence this
>> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
>>
>> In addition, we make BSS section aligned to 16byte instead of PAGE
>> aligned which further reduces flat kernel Image size by few KBs.
>>
>> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
>> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
>> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
>> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
>>
>> Signed-off-by: Anup Patel <anup@brainfault.org>
>> ---
>>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
>> index 65df1dfdc303..cc99eed44931 100644
>> --- a/arch/riscv/kernel/vmlinux.lds.S
>> +++ b/arch/riscv/kernel/vmlinux.lds.S
>> @@ -74,8 +74,6 @@ SECTIONS
>>                 *(.sbss*)
>>         }
>>
>> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
>> -
>>         EXCEPTION_TABLE(0x10)
>>         NOTES
>>
>> @@ -83,6 +81,8 @@ SECTIONS
>>                 *(.rel.dyn*)
>>         }
>>
>> +       BSS_SECTION(0x10, 0x10, 0x10)
>> +
>>         _end = .;
>>
>>         STABS_DEBUG
>> --
>> 2.17.1
>>
>
> Hi All,
>
> Any comment on this patch?

Sorry, I haven't had a chance to look at it yet.  Aside from the macro issue 
mentioned by Nick it seems OK.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
  2018-12-20 20:40   ` Palmer Dabbelt
@ 2018-12-23 14:58     ` Anup Patel
  0 siblings, 0 replies; 9+ messages in thread
From: Anup Patel @ 2018-12-23 14:58 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: Christoph Hellwig, Atish Patra, linux-riscv, Albert Ou,
	linux-kernel@vger.kernel.org List

On Fri, Dec 21, 2018 at 2:10 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Mon, 17 Dec 2018 01:36:45 PST (-0800), anup@brainfault.org wrote:
> > On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org> wrote:
> >>
> >> The objcopy only emits loadable sections when creating flat kernel
> >> Image. To have minimal possible size of flat kernel Image, we should
> >> have all non-loadable sections after loadable sections.
> >>
> >> Currently, execption table section (loadable section) is after BSS
> >> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> >> is not optimal for having minimal flat kernel Image size hence this
> >> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
> >>
> >> In addition, we make BSS section aligned to 16byte instead of PAGE
> >> aligned which further reduces flat kernel Image size by few KBs.
> >>
> >> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> >> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> >> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> >> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
> >> index 65df1dfdc303..cc99eed44931 100644
> >> --- a/arch/riscv/kernel/vmlinux.lds.S
> >> +++ b/arch/riscv/kernel/vmlinux.lds.S
> >> @@ -74,8 +74,6 @@ SECTIONS
> >>                 *(.sbss*)
> >>         }
> >>
> >> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> >> -
> >>         EXCEPTION_TABLE(0x10)
> >>         NOTES
> >>
> >> @@ -83,6 +81,8 @@ SECTIONS
> >>                 *(.rel.dyn*)
> >>         }
> >>
> >> +       BSS_SECTION(0x10, 0x10, 0x10)
> >> +
> >>         _end = .;
> >>
> >>         STABS_DEBUG
> >> --
> >> 2.17.1
> >>
> >
> > Hi All,
> >
> > Any comment on this patch?
>
> Sorry, I haven't had a chance to look at it yet.  Aside from the macro issue
> mentioned by Nick it seems OK.

I have send v2 to address Nick's comment.

Regards,
Anup

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26  6:08 [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S anup
2018-11-26  6:08 ` Anup Patel
2018-11-29  7:36 ` bmeng.cn
2018-11-29  7:36   ` Bin Meng
2018-12-17  9:36 ` Anup Patel
2018-12-17 12:59   ` Nick Kossifidis
2018-12-18  8:23     ` Anup Patel
2018-12-20 20:40   ` Palmer Dabbelt
2018-12-23 14:58     ` Anup Patel

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox