From: Guo Ren <guoren@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
peterz@infradead.org, luto@kernel.org,
conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org,
lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org,
apatel@ventanamicro.com, atishp@atishpatra.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
mark.rutland@arm.com, zouyipeng@huawei.com,
bigeasy@linutronix.de, David.Laight@aculab.com,
chenzhongjin@huawei.com, greentime.hu@sifive.com,
andy.chiu@sifive.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Guo Ren <guoren@linux.alibaba.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH -next V8 04/14] riscv: ptrace: Remove duplicate operation
Date: Tue, 6 Dec 2022 12:41:07 +0800 [thread overview]
Message-ID: <CAJF2gTRqnuYVHKoB_7GCK_JwvUK0gYUs9eOAzXL-CKWQ-AuO+Q@mail.gmail.com> (raw)
In-Reply-To: <87bkoi9otu.fsf@all.your.base.are.belong.to.us>
On Mon, Dec 5, 2022 at 5:34 PM Björn Töpel <bjorn@kernel.org> wrote:
>
> guoren@kernel.org writes:
>
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > The TIF_SYSCALL_TRACE is controlled by a common code, see
> > kernel/ptrace.c and include/linux/thread.h.
>
> ^^^ thread_info.h
> >
> > clear_task_syscall_work(child, SYSCALL_TRACE);
> >
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@kernel.org>
> > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
> > ---
> > arch/riscv/kernel/ptrace.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
> > index 2ae8280ae475..44f4b1ca315d 100644
> > --- a/arch/riscv/kernel/ptrace.c
> > +++ b/arch/riscv/kernel/ptrace.c
> > @@ -212,7 +212,6 @@ unsigned long regs_get_kernel_stack_nth(struct pt_regs *regs, unsigned int n)
> >
> > void ptrace_disable(struct task_struct *child)
> > {
> > - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
> > }
> >
> > long arch_ptrace(struct task_struct *child, long request,
>
> This patch is also not neccesary for the series, but should be a
> separate cleanup.
Maybe I would deprecate this patch because the generic entry would
delete the whole ptrace_disable().
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-06 4:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 7:50 [PATCH -next V8 00/14] riscv: Add GENERIC_ENTRY support and related features guoren
2022-11-03 7:50 ` [PATCH -next V8 01/14] compiler_types.h: Add __noinstr_section() for noinstr guoren
2022-12-05 9:12 ` Björn Töpel
2022-11-03 7:50 ` [PATCH -next V8 02/14] riscv: elf_kexec: Fixup compile warning guoren
2022-12-05 9:13 ` Björn Töpel
2022-12-06 4:39 ` Guo Ren
2022-11-03 7:50 ` [PATCH -next V8 03/14] riscv: compat_syscall_table: " guoren
2022-12-05 9:13 ` Björn Töpel
2022-11-03 7:50 ` [PATCH -next V8 04/14] riscv: ptrace: Remove duplicate operation guoren
2022-12-05 9:34 ` Björn Töpel
2022-12-06 4:41 ` Guo Ren [this message]
2022-11-03 7:50 ` [PATCH -next V8 05/14] riscv: traps: Add noinstr to prevent instrumentation inserted guoren
2022-11-03 7:50 ` [PATCH -next V8 06/14] riscv: convert to generic entry guoren
2022-11-27 16:25 ` Ben Hutchings
2022-11-28 2:42 ` Guo Ren
2022-12-05 10:49 ` Björn Töpel
2022-12-06 6:39 ` Guo Ren
2022-11-03 7:50 ` [PATCH -next V8 07/14] riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren
2022-11-03 7:50 ` [PATCH -next V8 08/14] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren
2022-11-03 7:50 ` [PATCH -next V8 09/14] riscv: Add config of thread stack size guoren
2022-11-03 7:50 ` [PATCH -next V8 10/14] riscv: Typo fixup for addi -> andi in comment guoren
2022-12-05 9:18 ` Björn Töpel
2022-11-03 7:50 ` [PATCH -next V8 11/14] riscv: Add support for STACKLEAK gcc plugin guoren
2022-11-03 7:50 ` [PATCH -next V8 12/14] riscv: remove extra level wrappers of trace_hardirqs_{on,off} guoren
2022-11-03 7:50 ` [PATCH -next V8 13/14] riscv: consolidate ret_from_kernel_thread into ret_from_fork guoren
2022-11-03 7:50 ` [PATCH -next V8 14/14] riscv: entry: consolidate general regs saving/restoring guoren
2022-11-23 15:26 ` [PATCH -next V8 00/14] riscv: Add GENERIC_ENTRY support and related features Jisheng Zhang
2022-12-05 9:46 ` Björn Töpel
2022-12-06 6:12 ` Guo Ren
2022-12-06 7:03 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTRqnuYVHKoB_7GCK_JwvUK0gYUs9eOAzXL-CKWQ-AuO+Q@mail.gmail.com \
--to=guoren@kernel.org \
--cc=David.Laight@aculab.com \
--cc=andy.chiu@sifive.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=bigeasy@linutronix.de \
--cc=bjorn@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenzhongjin@huawei.com \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=greentime.hu@sifive.com \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=lazyparser@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).