From: Paul Walmsley <paul.walmsley@sifive.com>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"tiny.windzz@gmail.com" <tiny.windzz@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johan@kernel.org" <johan@kernel.org>,
Anup Patel <Anup.Patel@wdc.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"gary@garyguo.net" <gary@garyguo.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"info@metux.net" <info@metux.net>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"allison@lohutok.net" <allison@lohutok.net>
Subject: Re: [PATCH v3 3/5] RISC-V: Fix unsupported isa string info.
Date: Tue, 6 Aug 2019 18:26:08 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1908061818360.13971@viisi.sifive.com> (raw)
In-Reply-To: <1e23ef1face9d323fda4b756811f922caa5f7689.camel@wdc.com>
On Wed, 7 Aug 2019, Atish Patra wrote:
> On Tue, 2019-08-06 at 16:27 -0700, Paul Walmsley wrote:
>
> > Seems like the "su" should be dropped from mandatory_ext. What do you
> > think?
> >
>
> Yup. As DT binding only mention imafdc, mandatory extensions should
> contain only that and just consider "su" extensions are considered as
> implicit as we are running Linux.
Discussing this with Andrew and Palmer, it looks like "su" is currently
non-compliant. Section 22.6 of the user-level specification states that
the "s" character indicates that a longer standard supervisor extension
name will follow. So far I don't think any of these have been defined.
> Do you think QEMU DT should be updated to reflect that ?
Yes.
> > There's no Kconfig option by this name, and we're requiring
> > compressed
>
> Sorry. This was a typo. It should have been CONFIG_RISCV_ISA_C.
>
> > instruction support as part of the RISC-V Linux baseline. Could you
> > share the rationale behind this?
>
> I think I added this check at the config file. Looking at the Kconfig,
> RISCV_ISA_C is always enabled. So we can drop this.
OK great. Do you want to resend an updated patch, or would you like me to
fix it up here?
I'll also send a patch to drop CONFIG_RISCV_ISA_C.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-07 1:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 0:58 [PATCH v3 0/5] Miscellaneous fixes Atish Patra
2019-08-01 0:58 ` [PATCH v3 1/5] RISC-V: Remove per cpu clocksource Atish Patra
2019-08-01 0:58 ` [PATCH v3 2/5] RISC-V: Add riscv_isa reprensenting ISA features common across CPUs Atish Patra
2019-08-01 0:58 ` [PATCH v3 3/5] RISC-V: Fix unsupported isa string info Atish Patra
2019-08-06 23:27 ` Paul Walmsley
2019-08-07 1:13 ` Atish Patra
2019-08-07 1:26 ` Paul Walmsley [this message]
2019-08-07 15:37 ` Palmer Dabbelt
2019-08-07 17:31 ` Atish Patra
2019-08-07 17:42 ` Palmer Dabbelt
2019-08-01 0:58 ` [PATCH v3 4/5] RISC-V: Export few kernel symbols Atish Patra
2019-08-01 15:56 ` Christoph Hellwig
2019-08-01 23:04 ` Atish Patra
2019-08-01 0:58 ` [PATCH v3 5/5] dt-bindings: Update the riscv,isa string description Atish Patra
2019-08-01 15:50 ` [PATCH v3 5/5] dt-bindings: Update the riscv, isa " Rob Herring
2019-08-01 23:07 ` [PATCH v3 5/5] dt-bindings: Update the riscv,isa " Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1908061818360.13971@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).