[PATCH v2] drm/of: Consider the state in which the ep is disabled

[PATCH v2] drm/of: Consider the state in which the ep is disabled

[Sandy Huang]

don't mask possible_crtcs if remote-point is disabled.

Signed-off-by: Sandy Huang <hjc@rock-chips.com>
---
 drivers/gpu/drm/drm_of.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index fdb05fbf72a0..565f05f5f11b 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
 	uint32_t possible_crtcs = 0;
 
 	for_each_endpoint_of_node(port, ep) {
+		if (!of_device_is_available(ep))
+			continue;
+
 		remote_port = of_graph_get_remote_port(ep);
 		if (!remote_port) {
 			of_node_put(ep);
-- 
2.17.1

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Heiko Stübner]

Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
> don't mask possible_crtcs if remote-point is disabled.
> 
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I guess this could've benefitted from a "changelog":

changes in v2:
- drop additional of_node_put, as ep will be put with the next
  iteration of for_each_endpoint_of_node()


> ---
>  drivers/gpu/drm/drm_of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>  	uint32_t possible_crtcs = 0;
>  
>  	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>  		remote_port = of_graph_get_remote_port(ep);
>  		if (!remote_port) {
>  			of_node_put(ep);
> 

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Heiko Stübner]

Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
> don't mask possible_crtcs if remote-point is disabled.
> 
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

changes in v2:
- drop additional of_node_put, as ep will be put with the next
  iteration of for_each_endpoint_of_node()


As this touches a pretty central function is there something
to keep in mind in regards to other DRM drivers?
[question for the broader audience ;-) ]

Heiko

> ---
>  drivers/gpu/drm/drm_of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>  	uint32_t possible_crtcs = 0;
>  
>  	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>  		remote_port = of_graph_get_remote_port(ep);
>  		if (!remote_port) {
>  			of_node_put(ep);
> 

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Huang Jiachai]

ping...

在 2020/7/23 3:01, Heiko Stübner 写道:
> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>> don't mask possible_crtcs if remote-point is disabled.
>>
>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> changes in v2:
> - drop additional of_node_put, as ep will be put with the next
>    iteration of for_each_endpoint_of_node()
>
>
> As this touches a pretty central function is there something
> to keep in mind in regards to other DRM drivers?
> [question for the broader audience ;-) ]
>
> Heiko
>
>> ---
>>   drivers/gpu/drm/drm_of.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>> index fdb05fbf72a0..565f05f5f11b 100644
>> --- a/drivers/gpu/drm/drm_of.c
>> +++ b/drivers/gpu/drm/drm_of.c
>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>>   	uint32_t possible_crtcs = 0;
>>   
>>   	for_each_endpoint_of_node(port, ep) {
>> +		if (!of_device_is_available(ep))
>> +			continue;
>> +
>>   		remote_port = of_graph_get_remote_port(ep);
>>   		if (!remote_port) {
>>   			of_node_put(ep);
>>
>
>
>
>
>
-- 
Best Regard

黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
       No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel：+86 0591-87884919  8690
E-mail：hjc@rock-chips.com




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Huang Jiachai]

Hi David Airlie，

     Please help to confirm whether this modification is reasonable when 
you are free, thanks.


在 2020/8/13 14:31, Huang Jiachai 写道:
> ping...
>
> 在 2020/7/23 3:01, Heiko Stübner 写道:
>> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> changes in v2:
>> - drop additional of_node_put, as ep will be put with the next
>>    iteration of for_each_endpoint_of_node()
>>
>>
>> As this touches a pretty central function is there something
>> to keep in mind in regards to other DRM drivers?
>> [question for the broader audience ;-) ]
>>
>> Heiko
>>
>>> ---
>>>   drivers/gpu/drm/drm_of.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct 
>>> drm_device *dev,
>>>       uint32_t possible_crtcs = 0;
>>>         for_each_endpoint_of_node(port, ep) {
>>> +        if (!of_device_is_available(ep))
>>> +            continue;
>>> +
>>>           remote_port = of_graph_get_remote_port(ep);
>>>           if (!remote_port) {
>>>               of_node_put(ep);
>>>
>>
>>
>>
>>
>>
-- 
Best Regard

黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
       No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel：+86 0591-87884919  8690
E-mail：hjc@rock-chips.com




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Kever Yang]

Hi Maintainers,

     Does this patch ready to merge?

On 2020/7/7 下午7:25, Sandy Huang wrote:
> don't mask possible_crtcs if remote-point is disabled.
>
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> ---
>   drivers/gpu/drm/drm_of.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>   	uint32_t possible_crtcs = 0;
>   
>   	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>   		remote_port = of_graph_get_remote_port(ep);
>   		if (!remote_port) {
>   			of_node_put(ep);

Looks good to me.


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Daniel Vetter]

On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> Hi Maintainers,
> 
>     Does this patch ready to merge?

Would maybe be good to get some acks from other drivers using this, then
Sandy can push to drm-misc-next.
-Daniel
> 
> On 2020/7/7 下午7:25, Sandy Huang wrote:
> > don't mask possible_crtcs if remote-point is disabled.
> > 
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > ---
> >   drivers/gpu/drm/drm_of.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..565f05f5f11b 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> >   	uint32_t possible_crtcs = 0;
> >   	for_each_endpoint_of_node(port, ep) {
> > +		if (!of_device_is_available(ep))
> > +			continue;
> > +
> >   		remote_port = of_graph_get_remote_port(ep);
> >   		if (!remote_port) {
> >   			of_node_put(ep);
> 
> Looks good to me.
> 
> 
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Kever Yang]

Hi Daniel,

On 2020/10/15 下午11:23, Daniel Vetter wrote:
> On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
>> Hi Maintainers,
>>
>>      Does this patch ready to merge?
> Would maybe be good to get some acks from other drivers using this, then
> Sandy can push to drm-misc-next.

Thanks for your reply, I can understand more 'acks' will be better, but 
there is no comments object to this patch

or any 'NAK' common for more then 3 months, maintainers should move to 
next step.


Thanks,

- Kever

> -Daniel
>> On 2020/7/7 下午7:25, Sandy Huang wrote:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>>> ---
>>>    drivers/gpu/drm/drm_of.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>>>    	uint32_t possible_crtcs = 0;
>>>    	for_each_endpoint_of_node(port, ep) {
>>> +		if (!of_device_is_available(ep))
>>> +			continue;
>>> +
>>>    		remote_port = of_graph_get_remote_port(ep);
>>>    		if (!remote_port) {
>>>    			of_node_put(ep);
>> Looks good to me.
>>
>>
>> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

[Daniel Vetter]

On Mon, Oct 19, 2020 at 11:43:53AM +0800, Kever Yang wrote:
> Hi Daniel,
> 
> On 2020/10/15 下午11:23, Daniel Vetter wrote:
> > On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> > > Hi Maintainers,
> > > 
> > >      Does this patch ready to merge?
> > Would maybe be good to get some acks from other drivers using this, then
> > Sandy can push to drm-misc-next.
> 
> Thanks for your reply, I can understand more 'acks' will be better, but
> there is no comments object to this patch
> 
> or any 'NAK' common for more then 3 months, maintainers should move to next
> step.

I expect you to poke relevant driver maintainers directly for these acks.
That was the purpose of my mail. All communication going through
maintainers, being exclusively orchestrated by maintainers, just doesn't
scale. So not an option for a big subsystem like drivers/gpu.

Hope that makes it clear.

For merging Sandy has commit rights to drm-misc, so that's not the
problem.

Cheers, Daniel

> 
> 
> Thanks,
> 
> - Kever
> 
> > -Daniel
> > > On 2020/7/7 下午7:25, Sandy Huang wrote:
> > > > don't mask possible_crtcs if remote-point is disabled.
> > > > 
> > > > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > > > ---
> > > >    drivers/gpu/drm/drm_of.c | 3 +++
> > > >    1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > > > index fdb05fbf72a0..565f05f5f11b 100644
> > > > --- a/drivers/gpu/drm/drm_of.c
> > > > +++ b/drivers/gpu/drm/drm_of.c
> > > > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> > > >    	uint32_t possible_crtcs = 0;
> > > >    	for_each_endpoint_of_node(port, ep) {
> > > > +		if (!of_device_is_available(ep))
> > > > +			continue;
> > > > +
> > > >    		remote_port = of_graph_get_remote_port(ep);
> > > >    		if (!remote_port) {
> > > >    			of_node_put(ep);
> > > Looks good to me.
> > > 
> > > 
> > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip