From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Paul Thomas <pthomas8589@gmail.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
dunc.mcphie@gmail.com, Anders Roxell <anders.roxell@linaro.org>
Subject: Re: poor cyclictest results with 5.0 series rt for arm64
Date: Thu, 15 Aug 2019 17:15:15 +0200 [thread overview]
Message-ID: <20190815151515.p2tch5qz653h2unm@linutronix.de> (raw)
In-Reply-To: <CAD56B7d-nCs9am2Dh6LkawjL66V6Hmvw6XuCrzrfqU86csrFoQ@mail.gmail.com>
On 2019-08-15 11:12:35 [-0400], Paul Thomas wrote:
> > so it seems to works but I *think* that at 610.156813 shouldn't be there
> > and it should switch to cyclictest. But if it is the broken irq-exit
> > path then this should fix it:
> >
> > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> > index 63c6960262861..27a16c2711981 100644
> > --- a/arch/arm64/kernel/entry.S
> > +++ b/arch/arm64/kernel/entry.S
> > @@ -649,13 +649,7 @@ alternative_if ARM64_HAS_IRQ_PRIO_MASKING
> > alternative_else_nop_endif
> >
> > cbz x24, 1f // (need_resched + count) == 0
> > - cbnz w24, 2f // count != 0
> > -
> > - ldr w24, [tsk, #TSK_TI_PREEMPT_LAZY] // get preempt lazy count
> > - cbnz w24, 2f // preempt lazy count != 0
> > -
> > - ldr x0, [tsk, #TSK_TI_FLAGS] // get flags
> > - tbz x0, #TIF_NEED_RESCHED_LAZY, 2f // needs rescheduling?
> > + b 2f // count != 0
> > 1:
> > bl preempt_schedule_irq // irq en/disable is done inside
> > 2:
> This doesn't look like it's against 5.2.y-rt or 5.0.y-rt? I don't see
> a (need_resched + count) == 0 line?
That was the previous patch I've sent you.
> -Paul
Sebastian
next prev parent reply other threads:[~2019-08-15 15:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 11:18 poor cyclictest results with 5.0 series rt for arm64 Paul Thomas
[not found] ` <CAD56B7c2=95r7r-6tr0Mby8jSeuQPDNSd4LELnUw1LVRn9Rqew@mail.gmail.com>
2019-07-12 11:32 ` Paul Thomas
2019-07-16 20:24 ` Thomas Gleixner
2019-07-16 21:50 ` Paul Thomas
2019-07-16 23:14 ` Thomas Gleixner
2019-07-17 0:44 ` Paul Thomas
2019-07-17 8:03 ` Thomas Gleixner
2019-07-17 8:10 ` Thomas Gleixner
2019-07-17 9:02 ` Thomas Gleixner
2019-07-17 10:21 ` Thomas Gleixner
2019-07-17 22:28 ` Paul Thomas
2019-08-13 9:53 ` Sebastian Andrzej Siewior
2019-08-13 18:02 ` Paul Thomas
2019-08-14 11:26 ` Sebastian Andrzej Siewior
2019-08-14 16:17 ` [PATCH RT] arm64: preempt: Check preemption level before looking at lazy-preempt Sebastian Andrzej Siewior
2019-08-14 16:17 ` [PATCH RT] x86: " Sebastian Andrzej Siewior
2019-08-14 17:04 ` poor cyclictest results with 5.0 series rt for arm64 Paul Thomas
2019-08-15 8:29 ` Sebastian Andrzej Siewior
2019-08-15 12:33 ` John Ogness
2019-08-15 13:30 ` Paul Thomas
2019-08-15 13:42 ` Sebastian Andrzej Siewior
2019-08-15 13:52 ` Paul Thomas
2019-08-15 14:19 ` Sebastian Andrzej Siewior
2019-08-15 15:12 ` Paul Thomas
2019-08-15 15:15 ` Sebastian Andrzej Siewior [this message]
2019-08-15 15:31 ` Paul Thomas
2019-08-15 18:00 ` Paul Thomas
2019-08-15 18:57 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815151515.p2tch5qz653h2unm@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anders.roxell@linaro.org \
--cc=dunc.mcphie@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=pthomas8589@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).