From: Uladzislau Rezki <urezki@gmail.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node
Date: Thu, 3 Oct 2019 13:55:36 +0200 [thread overview]
Message-ID: <20191003115536.GA15745@pc636> (raw)
In-Reply-To: <20191003090906.1261-1-dwagner@suse.de>
On Thu, Oct 03, 2019 at 11:09:06AM +0200, Daniel Wagner wrote:
> Replace preempt_enable() and preempt_disable() with the vmap_area_lock
> spin_lock instead. Calling spin_lock() with preempt disabled is
> illegal for -rt. Furthermore, enabling preemption inside the
> spin_lock() doesn't really make sense.
>
> Fixes: 82dd23e84be3 ("mm/vmalloc.c: preload a CPU with one object for
> split purpose")
> Cc: Uladzislau Rezki (Sony) <urezki@gmail.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> mm/vmalloc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 08c134aa7ff3..0d1175673583 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1091,11 +1091,11 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> * Even if it fails we do not really care about that. Just proceed
> * as it is. "overflow" path will refill the cache we allocate from.
> */
> - preempt_disable();
> + spin_lock(&vmap_area_lock);
> if (!__this_cpu_read(ne_fit_preload_node)) {
> - preempt_enable();
> + spin_unlock(&vmap_area_lock);
> pva = kmem_cache_alloc_node(vmap_area_cachep, GFP_KERNEL, node);
> - preempt_disable();
> + spin_lock(&vmap_area_lock);
>
> if (__this_cpu_cmpxchg(ne_fit_preload_node, NULL, pva)) {
> if (pva)
> @@ -1103,9 +1103,6 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> }
> }
>
> - spin_lock(&vmap_area_lock);
> - preempt_enable();
> -
> /*
> * If an allocation fails, the "vend" address is
> * returned. Therefore trigger the overflow path.
> --
> 2.16.4
>
Some background. The idea was to avoid of touching several times
vmap_area_lock, therefore there are preempt_disable()/preempt_enable()
instead, in order to stay on the same CPU.
When it comes to PREEMPT_RT it is a problem, so
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
--
Vlad Rezki
next prev parent reply other threads:[~2019-10-03 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:09 [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node Daniel Wagner
2019-10-03 11:55 ` Uladzislau Rezki [this message]
2019-10-04 15:37 ` Sebastian Andrzej Siewior
2019-10-04 16:20 ` Uladzislau Rezki
2019-10-04 16:30 ` Sebastian Andrzej Siewior
2019-10-04 17:04 ` Uladzislau Rezki
2019-10-04 17:45 ` Sebastian Andrzej Siewior
2019-10-07 8:30 ` Daniel Wagner
2019-10-07 10:56 ` Sebastian Andrzej Siewior
2019-10-07 16:23 ` Uladzislau Rezki
2019-10-07 16:34 ` Daniel Wagner
2019-10-07 16:56 ` Uladzislau Rezki
2019-10-07 17:22 ` Daniel Wagner
2019-10-07 17:36 ` Sebastian Andrzej Siewior
2019-10-07 21:44 ` Uladzislau Rezki
2019-10-08 16:04 ` Uladzislau Rezki
2019-10-09 6:05 ` Daniel Wagner
2019-10-09 9:47 ` Uladzislau Rezki
2019-10-07 8:27 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003115536.GA15745@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).