From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Daniel Wagner <dwagner@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node
Date: Fri, 4 Oct 2019 18:30:42 +0200 [thread overview]
Message-ID: <20191004163042.jpiau6dlxqylbpfh@linutronix.de> (raw)
In-Reply-To: <20191004162041.GA30806@pc636>
On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote:
> On Fri, Oct 04, 2019 at 05:37:28PM +0200, Sebastian Andrzej Siewior wrote:
> > If you post something that is related to PREEMPT_RT please keep tglx and
> > me in Cc.
> >
> > On 2019-10-03 11:09:06 [+0200], Daniel Wagner wrote:
> > > Replace preempt_enable() and preempt_disable() with the vmap_area_lock
> > > spin_lock instead. Calling spin_lock() with preempt disabled is
> > > illegal for -rt. Furthermore, enabling preemption inside the
> >
> > Looking at it again, I have reasonable doubt that this
> > preempt_disable() is needed.
> >
> The intention was to preload a current CPU with one extra object in
> non-atomic context, thus to use GFP_KERNEL permissive parameters. I.e.
> that allows us to avoid any allocation(if we stay on the same CPU)
> when we are in atomic context do splitting.
You could have been migrated to another CPU before the first
preempt_disable(). You could have been migrated to another CPU while
memory has been allocated.
I don't really see the point of that preempt_disable() besides keeping
debug code quiet.
> If we have migrate_disable/enable, then, i think preempt_enable/disable
> should be replaced by it and not the way how it has been proposed
> in the patch.
I don't think this patch is appropriate for upstream.
Sebastian
next prev parent reply other threads:[~2019-10-04 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:09 [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node Daniel Wagner
2019-10-03 11:55 ` Uladzislau Rezki
2019-10-04 15:37 ` Sebastian Andrzej Siewior
2019-10-04 16:20 ` Uladzislau Rezki
2019-10-04 16:30 ` Sebastian Andrzej Siewior [this message]
2019-10-04 17:04 ` Uladzislau Rezki
2019-10-04 17:45 ` Sebastian Andrzej Siewior
2019-10-07 8:30 ` Daniel Wagner
2019-10-07 10:56 ` Sebastian Andrzej Siewior
2019-10-07 16:23 ` Uladzislau Rezki
2019-10-07 16:34 ` Daniel Wagner
2019-10-07 16:56 ` Uladzislau Rezki
2019-10-07 17:22 ` Daniel Wagner
2019-10-07 17:36 ` Sebastian Andrzej Siewior
2019-10-07 21:44 ` Uladzislau Rezki
2019-10-08 16:04 ` Uladzislau Rezki
2019-10-09 6:05 ` Daniel Wagner
2019-10-09 9:47 ` Uladzislau Rezki
2019-10-07 8:27 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004163042.jpiau6dlxqylbpfh@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).