From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Jonathan Corbet <corbet@lwn.net>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>, Lee Jones <lee.jones@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, netdev@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH v10 3/6] MIPS: PCI: Fix fake subdevice ID for IOC3
Date: Tue, 15 Oct 2019 14:09:48 +0200 [thread overview]
Message-ID: <20191015120953.2597-4-tbogendoerfer@suse.de> (raw)
In-Reply-To: <20191015120953.2597-1-tbogendoerfer@suse.de>
Generation of fake subdevice ID had vendor and device ID swapped.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
arch/mips/pci/pci-xtalk-bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/pci/pci-xtalk-bridge.c b/arch/mips/pci/pci-xtalk-bridge.c
index dcf6117a17c3..d1d5f54c2632 100644
--- a/arch/mips/pci/pci-xtalk-bridge.c
+++ b/arch/mips/pci/pci-xtalk-bridge.c
@@ -437,7 +437,7 @@ static int bridge_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
return irq;
}
-#define IOC3_SID(sid) (PCI_VENDOR_ID_SGI << 16 | (sid))
+#define IOC3_SID(sid) (PCI_VENDOR_ID_SGI | ((sid) << 16))
static void bridge_setup_ip27_baseio6g(struct bridge_controller *bc)
{
--
2.16.4
next prev parent reply other threads:[~2019-10-15 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 12:09 [PATCH v10 0/6] Use MFD framework for SGI IOC3 drivers Thomas Bogendoerfer
2019-10-15 12:09 ` [PATCH v10 1/6] nvmem: core: add nvmem_device_find Thomas Bogendoerfer
2019-10-15 12:09 ` [PATCH v10 2/6] MIPS: PCI: use information from 1-wire PROM for IOC3 detection Thomas Bogendoerfer
2019-10-15 12:09 ` Thomas Bogendoerfer [this message]
2019-10-15 12:09 ` [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip Thomas Bogendoerfer
2019-10-15 19:23 ` Jakub Kicinski
2019-10-16 6:18 ` Lee Jones
2019-10-16 17:23 ` Thomas Bogendoerfer
2019-10-16 17:38 ` Jakub Kicinski
2019-10-17 7:14 ` Lee Jones
2019-10-17 10:19 ` Thomas Bogendoerfer
2019-10-15 12:09 ` [PATCH v10 5/6] MIPS: SGI-IP27: fix readb/writeb addressing Thomas Bogendoerfer
2019-10-15 12:09 ` [PATCH v10 6/6] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015120953.2597-4-tbogendoerfer@suse.de \
--to=tbogendoerfer@suse.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jakub.kicinski@netronome.com \
--cc=jhogan@kernel.org \
--cc=jslaby@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).