Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
@ 2019-12-04  2:02 Mao Wenan
  2019-12-04  6:35 ` Dan Carpenter
  0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-12-04  2:02 UTC (permalink / raw)
  To: eddie.huang, sean.wang, a.zummo, alexandre.belloni, matthias.bgg
  Cc: linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Mao Wenan, Hulk Robot

rtc->irq is requested by devm_request_threaded_irq,
and request_threaded_irq. IRQs requested with this
function will be automatically freed on driver detach.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/rtc/rtc-mt6397.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 5249fc99fd5f..d6a10111137a 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	return 0;
 
 out_free_irq:
-	free_irq(rtc->irq, rtc);
 	return ret;
 }
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
  2019-12-04  2:02 [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq Mao Wenan
@ 2019-12-04  6:35 ` Dan Carpenter
  2019-12-04  7:28   ` [PATCH v2 " Mao Wenan
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2019-12-04  6:35 UTC (permalink / raw)
  To: Mao Wenan
  Cc: eddie.huang, sean.wang, a.zummo, alexandre.belloni, matthias.bgg,
	linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Hulk Robot

On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..d6a10111137a 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  
>  out_free_irq:
> -	free_irq(rtc->irq, rtc);
>  	return ret;

Please get rid of the error label as well.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
  2019-12-04  6:35 ` Dan Carpenter
@ 2019-12-04  7:28   ` " Mao Wenan
  2019-12-04  8:40     ` Alexandre Belloni
  0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-12-04  7:28 UTC (permalink / raw)
  To: eddie.huang, sean.wang, a.zummo, alexandre.belloni, matthias.bgg,
	dan.carpenter
  Cc: linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Mao Wenan, Hulk Robot

rtc->irq is requested by devm_request_threaded_irq,
and request_threaded_irq. IRQs requested with this
function will be automatically freed on driver detach.
This patch remove unused error label as well.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v2: remove error label as Dan Carpenter suggest.
 drivers/rtc/rtc-mt6397.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 5249fc99fd5f..14f3c4915260 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	rtc->rtc_dev->ops = &mtk_rtc_ops;
 
 	ret = rtc_register_device(rtc->rtc_dev);
-	if (ret)
-		goto out_free_irq;
-
-	return 0;
-
-out_free_irq:
-	free_irq(rtc->irq, rtc);
 	return ret;
 }
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
  2019-12-04  7:28   ` [PATCH v2 " Mao Wenan
@ 2019-12-04  8:40     ` Alexandre Belloni
  2019-12-04  8:42       ` Alexandre Belloni
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2019-12-04  8:40 UTC (permalink / raw)
  To: Mao Wenan
  Cc: eddie.huang, sean.wang, a.zummo, matthias.bgg, dan.carpenter,
	linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Hulk Robot

On 04/12/2019 15:28:26+0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
> This patch remove unused error label as well.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
>  v2: remove error label as Dan Carpenter suggest.
>  drivers/rtc/rtc-mt6397.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..14f3c4915260 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  	rtc->rtc_dev->ops = &mtk_rtc_ops;
>  
>  	ret = rtc_register_device(rtc->rtc_dev);
> -	if (ret)
> -		goto out_free_irq;
> -
> -	return 0;
> -
> -out_free_irq:
> -	free_irq(rtc->irq, rtc);
>  	return ret;

Maybe return rtc_register_device(rtc->rtc_dev); 

>  }
>  
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
  2019-12-04  8:40     ` Alexandre Belloni
@ 2019-12-04  8:42       ` Alexandre Belloni
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2019-12-04  8:42 UTC (permalink / raw)
  To: Mao Wenan
  Cc: eddie.huang, sean.wang, a.zummo, matthias.bgg, dan.carpenter,
	linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Hulk Robot

On 04/12/2019 09:40:38+0100, Alexandre Belloni wrote:
> On 04/12/2019 15:28:26+0800, Mao Wenan wrote:
> > rtc->irq is requested by devm_request_threaded_irq,
> > and request_threaded_irq. IRQs requested with this
> > function will be automatically freed on driver detach.
> > This patch remove unused error label as well.
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Mao Wenan <maowenan@huawei.com>
> > ---
> >  v2: remove error label as Dan Carpenter suggest.
> >  drivers/rtc/rtc-mt6397.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> > index 5249fc99fd5f..14f3c4915260 100644
> > --- a/drivers/rtc/rtc-mt6397.c
> > +++ b/drivers/rtc/rtc-mt6397.c
> > @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> >  	rtc->rtc_dev->ops = &mtk_rtc_ops;
> >  
> >  	ret = rtc_register_device(rtc->rtc_dev);
> > -	if (ret)
> > -		goto out_free_irq;
> > -
> > -	return 0;
> > -
> > -out_free_irq:
> > -	free_irq(rtc->irq, rtc);
> >  	return ret;
> 
> Maybe return rtc_register_device(rtc->rtc_dev); 
> 

By the way, this was already properly submitted here:
https://patchwork.ozlabs.org/patch/1193956/

So I'll apply this one once the merge window ends (it depends on the MFD
pull request, that is why I didn't apply it yet).


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04  2:02 [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq Mao Wenan
2019-12-04  6:35 ` Dan Carpenter
2019-12-04  7:28   ` [PATCH v2 " Mao Wenan
2019-12-04  8:40     ` Alexandre Belloni
2019-12-04  8:42       ` Alexandre Belloni

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git