Re: [PATCH v6 20/20] PM: Switch to use %ptR

From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 20/20] PM: Switch to use %ptR
Date: Tue, 11 Dec 2018 12:53:59 +0100	[thread overview]
Message-ID: <8224399.K2TIF5fxr2@aspire.rjw.lan> (raw)
In-Reply-To: <20181204212330.69515-21-andriy.shevchenko@linux.intel.com>

On Tuesday, December 4, 2018 10:23:30 PM CET Andy Shevchenko wrote:
> Use %ptR instead of open coded variant to print content of
> struct rtc_time in human readable format.
> 
> Cc: linux-pm@vger.kernel.org
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Do you want me to take this patch?

> ---
>  drivers/base/power/trace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
> index 1cda505d6a85..b11f47a1e819 100644
> --- a/drivers/base/power/trace.c
> +++ b/drivers/base/power/trace.c
> @@ -118,9 +118,7 @@ static unsigned int read_magic_time(void)
>  	unsigned int val;
>  
>  	mc146818_get_time(&time);
> -	pr_info("RTC time: %2d:%02d:%02d, date: %02d/%02d/%02d\n",
> -		time.tm_hour, time.tm_min, time.tm_sec,
> -		time.tm_mon + 1, time.tm_mday, time.tm_year % 100);
> +	pr_info("RTC time: %ptRt, date: %ptRd\n", &time, &time);
>  	val = time.tm_year;				/* 100 years */
>  	if (val > 100)
>  		val -= 100;
> 