From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <frank-w@public-files.de>,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"Richard Fontana" <rfontana@redhat.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Eddie Huang" <eddie.huang@mediatek.com>,
linux-rtc@vger.kernel.org,
"René van Dorst" <opensource@vdorst.com>
Subject: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver
Date: Fri, 23 Aug 2019 16:56:13 +0200 [thread overview]
Message-ID: <e8a918ab-3e7a-b487-db77-df28d56518ce@gmail.com> (raw)
In-Reply-To: <trinity-1f82bff1-535e-47cd-9a2f-8faccb56e356-1566562433314@3c-app-gmx-bs11>
On 23/08/2019 14:13, Frank Wunderlich wrote:
> Hi,
>
> this commit breaks mt6323 pmic on BananaPi-R2
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a4872e80ce7d2a1844328176dbf279d0a2b89bdb
>
> resulting in this message in dmesg:
>
> mt6397 1000d000.pwrap:mt6323: unsupported chip: 0x0
> and multiple
> mtk-cpufreq mtk-cpufreq: failed to initialize dvfs info for cpu0
>
> see discussion here:
> http://lists.infradead.org/pipermail/linux-mediatek/2019-August/022505.html
>
> after reverting this one the errors are gone, please provide a fix
are you sure that you provide the correct chip_id here? I saw 0x2023 (if I
remember correctly), while this switch checks for 0x23, 0x91 and 0x97, so I'm
not sure if the problem really lies here. I didn't dig into the code to find out
how the chip_id is created.
Regards,
Matthias
>
> regards Frank
>
>
>> Gesendet: Freitag, 23. August 2019 um 05:45 Uhr
>> Von: "Hsin-Hsiung Wang" <hsin-hsiung.wang@mediatek.com>
>> Betreff: [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver
>>
>> In order to support different types of irq design, we decide to add
>> separate irq drivers for different design and keep mt6397 mfd core
>> simple and reusable to all generations of PMICs so far.
>>
>> Acked-for-mfd-by: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
>> ---
>> drivers/mfd/Makefile | 3 +-
>> drivers/mfd/mt6397-core.c | 146 --------------------------------
>> drivers/mfd/mt6397-irq.c | 181 ++++++++++++++++++++++++++++++++++++++++
>> include/linux/mfd/mt6397/core.h | 9 ++
>> 4 files changed, 192 insertions(+), 147 deletions(-)
>> create mode 100644 drivers/mfd/mt6397-irq.c
>
next prev parent reply other threads:[~2019-08-23 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 3:45 [PATCH v5 00/10] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 01/10] mfd: mt6397: clean up code Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang
2019-08-23 12:13 ` [BUG] " Frank Wunderlich
2019-08-23 14:56 ` Matthias Brugger [this message]
2019-08-23 15:26 ` Frank Wunderlich
2019-08-23 15:42 ` Matthias Brugger
2019-08-23 17:16 ` Aw: " Frank Wunderlich
2019-08-29 6:24 ` Hsin-hsiung Wang
2019-09-19 18:59 ` Frank Wunderlich
2019-09-30 19:44 ` Aw: " Frank Wunderlich
2019-08-23 15:35 ` Frank Wunderlich
2019-08-23 15:53 ` Frank Wunderlich
2019-08-23 14:53 ` Matthias Brugger
2019-08-23 3:45 ` [PATCH v5 03/10] mfd: mt6397: modify suspend/resume behavior Hsin-Hsiung Wang
2019-08-23 15:12 ` Matthias Brugger
2019-08-23 3:45 ` [PATCH v5 04/10] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 05/10] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang
2019-08-28 10:44 ` Mark Brown
2019-08-28 13:13 ` Applied "regulator: Add document for MT6358 regulator" to the regulator tree Mark Brown
2019-08-23 3:45 ` [PATCH v5 06/10] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-12-02 8:06 ` Pi-Hsun Shih
2019-12-06 8:55 ` Hsin-hsiung Wang
2019-08-23 3:45 ` [PATCH v5 07/10] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang
2019-08-28 10:45 ` Mark Brown
2019-08-29 6:09 ` Hsin-hsiung Wang
2019-08-28 13:13 ` Applied "regulator: mt6358: Add support for MT6358 regulator" to the regulator tree Mark Brown
2019-08-23 3:45 ` [PATCH v5 08/10] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 09/10] rtc: mt6397: fix alarm register overwrite Hsin-Hsiung Wang
2019-08-23 15:35 ` Matthias Brugger
2019-08-29 5:34 ` Hsin-hsiung Wang
2019-08-23 3:45 ` [PATCH v5 10/10] rtc: mt6397: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a918ab-3e7a-b487-db77-df28d56518ce@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=opensource@vdorst.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).