From: Mark Brown <broonie@kernel.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, Dmitry Osipenko <digetx@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Kamil Konieczny <k.konieczny@samsung.com>
Subject: Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable()
Date: Tue, 8 Oct 2019 16:48:44 +0100 [thread overview]
Message-ID: <20191008154844.GM4382@sirena.co.uk> (raw)
In-Reply-To: <86b9b4b5-cca5-9052-7c87-c5679dfffff4@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On Tue, Oct 08, 2019 at 03:24:17PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Commit 7f93ff73f7c8 ("opp: core: add regulators enable and disable")
> currently can be safely reverted as all affected users use always-on
> regulators. However IMHO it should be possible to enable always-on
> regulator without side-effects.
With coupled regulators you might have something kicking in because a
change was made on a completely different regulator... If we don't take
account of coupling requirements we'd doubtless have issues with that at
some point.
> When it comes to setting regulator constraints before doing enable
> operation, it also seems to be possible solution but would require
> splitting regulator_set_voltage() operation on two functions:
> - one for setting constraints (before regulator_enable() operation)
> - the other one actually setting voltage (after enable operation)
I don't follow? What would a "constraint" be in this context and how
would it be different to the voltage range you'd set in normal operation?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-08 15:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191008101720eucas1p2e0d1bca6e696848bf689067e05620679@eucas1p2.samsung.com>
2019-10-08 10:17 ` [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable() Marek Szyprowski
2019-10-08 10:17 ` Marek Szyprowski
2019-10-08 11:50 ` Mark Brown
2019-10-08 11:50 ` Mark Brown
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:47 ` Mark Brown
2019-10-08 12:47 ` Mark Brown
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 16:15 ` Mark Brown
2019-10-08 16:15 ` Mark Brown
2019-10-08 17:05 ` Dmitry Osipenko
2019-10-08 17:05 ` Dmitry Osipenko
2019-10-08 17:17 ` Mark Brown
2019-10-08 17:17 ` Mark Brown
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:07 ` Mark Brown
2019-10-08 18:07 ` Mark Brown
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 14:13 ` Mark Brown
2019-10-09 14:13 ` Mark Brown
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 13:55 ` Mark Brown
2019-10-10 13:55 ` Mark Brown
2019-10-17 10:29 ` Marek Szyprowski
2019-10-08 15:48 ` Mark Brown [this message]
2019-10-08 15:48 ` Mark Brown
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:21 ` Mark Brown
2019-10-08 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008154844.GM4382@sirena.co.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=digetx@gmail.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).