From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Kamil Konieczny <k.konieczny@samsung.com>
Subject: Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable()
Date: Thu, 17 Oct 2019 12:29:43 +0200 [thread overview]
Message-ID: <3cc6b317-5fab-ee46-cd27-d3a71b436dfa@samsung.com> (raw)
In-Reply-To: <20191010135507.GS2036@sirena.org.uk>
Hi Mark,
On 10.10.2019 15:55, Mark Brown wrote:
> On Thu, Oct 10, 2019 at 12:19:55PM +0200, Marek Szyprowski wrote:
>> On 09.10.2019 16:13, Mark Brown wrote:
>>> We should revert the enable call, it shouldn't be required, and ideally
>>> the default balancer could be updated to only make configuration changes
>>> if they're actually required which would help avoid triggering any such
>>> things in future if we don't absolutely have to.
>> Okay, Then in case of regulator core - do you accept the initial patch
>> as it indeed forces the default balancer to avoid unnecessary changes,
>> or do you want me to rewrite it to assume min_uV = current_uV for the
>> already enabled regulators during the initial balancing, like suggested
>> by Dmitry?
> Neither, I'm suggesting you make the change above.
I've posted a revert:
https://lkml.org/lkml/2019/10/17/267
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2019-10-17 10:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191008101720eucas1p2e0d1bca6e696848bf689067e05620679@eucas1p2.samsung.com>
2019-10-08 10:17 ` [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable() Marek Szyprowski
2019-10-08 10:17 ` Marek Szyprowski
2019-10-08 11:50 ` Mark Brown
2019-10-08 11:50 ` Mark Brown
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:47 ` Mark Brown
2019-10-08 12:47 ` Mark Brown
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 16:15 ` Mark Brown
2019-10-08 16:15 ` Mark Brown
2019-10-08 17:05 ` Dmitry Osipenko
2019-10-08 17:05 ` Dmitry Osipenko
2019-10-08 17:17 ` Mark Brown
2019-10-08 17:17 ` Mark Brown
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:07 ` Mark Brown
2019-10-08 18:07 ` Mark Brown
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 14:13 ` Mark Brown
2019-10-09 14:13 ` Mark Brown
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 13:55 ` Mark Brown
2019-10-10 13:55 ` Mark Brown
2019-10-17 10:29 ` Marek Szyprowski [this message]
2019-10-08 15:48 ` Mark Brown
2019-10-08 15:48 ` Mark Brown
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:21 ` Mark Brown
2019-10-08 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc6b317-5fab-ee46-cd27-d3a71b436dfa@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).