From: Dmitry Osipenko <digetx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Kamil Konieczny <k.konieczny@samsung.com>
Subject: Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable()
Date: Tue, 8 Oct 2019 20:05:03 +0300 [thread overview]
Message-ID: <4ad890b7-705e-94f9-2e61-1f3a60984c91@gmail.com> (raw)
In-Reply-To: <20191008161535.GN4382@sirena.co.uk>
08.10.2019 19:15, Mark Brown пишет:
> On Tue, Oct 08, 2019 at 06:02:36PM +0300, Dmitry Osipenko wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
Indeed, thanks!
>> That OPP patch caused the same problem for the NVIDIA Tegra20 CPUFreq
>> driver (in-progress) and I resolved it in the coupler's code [0].
>> Perhaps the generic coupler could do the same thing by assuming that
>> min_uV=current_uV until any consumer sets the voltage, i.e. if
>> regulator_check_consumers(min_uV=0) returns min_uV=0.
>
> That sounds like it might just postpone the inevitable - if you set the
> wrong voltage first it might decide to drop down some voltage that
> wasn't expected. There's a bit of a bootstrapping issue. I think it
> would be safer to just say that anything that is within spec won't get
> changed any time we balance, we'd only change things if needed to bring
> them back into spec.
Yes, the case of changing voltage before regulator is enabled seems
won't work as expected.
Maybe it won't hurt to disallow a non always-on regulators to be coupled
until there will be a real user for that case.
next prev parent reply other threads:[~2019-10-08 17:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191008101720eucas1p2e0d1bca6e696848bf689067e05620679@eucas1p2.samsung.com>
2019-10-08 10:17 ` [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable() Marek Szyprowski
2019-10-08 10:17 ` Marek Szyprowski
2019-10-08 11:50 ` Mark Brown
2019-10-08 11:50 ` Mark Brown
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:01 ` Marek Szyprowski
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:06 ` Mark Brown
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:38 ` Marek Szyprowski
2019-10-08 12:47 ` Mark Brown
2019-10-08 12:47 ` Mark Brown
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 13:24 ` Bartlomiej Zolnierkiewicz
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 15:02 ` Dmitry Osipenko
2019-10-08 16:15 ` Mark Brown
2019-10-08 16:15 ` Mark Brown
2019-10-08 17:05 ` Dmitry Osipenko [this message]
2019-10-08 17:05 ` Dmitry Osipenko
2019-10-08 17:17 ` Mark Brown
2019-10-08 17:17 ` Mark Brown
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:00 ` Dmitry Osipenko
2019-10-08 18:07 ` Mark Brown
2019-10-08 18:07 ` Mark Brown
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 10:29 ` Marek Szyprowski
2019-10-09 14:13 ` Mark Brown
2019-10-09 14:13 ` Mark Brown
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 7:29 ` Viresh Kumar
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 10:19 ` Marek Szyprowski
2019-10-10 13:55 ` Mark Brown
2019-10-10 13:55 ` Mark Brown
2019-10-17 10:29 ` Marek Szyprowski
2019-10-08 15:48 ` Mark Brown
2019-10-08 15:48 ` Mark Brown
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:02 ` Bartlomiej Zolnierkiewicz
2019-10-08 16:21 ` Mark Brown
2019-10-08 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad890b7-705e-94f9-2e61-1f3a60984c91@gmail.com \
--to=digetx@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).