[PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

[PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

[Krzysztof Kozlowski]

Remove the simple-bus compatible from a regulators node because its
children do not have any unit addresses.  This fixes DTC warning:

    Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/exynos4210-trats.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 3d791db6095c..cec413ee4490 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -31,8 +31,6 @@
 	};
 
 	regulators {
-		compatible = "simple-bus";
-
 		vemmc_reg: regulator-0 {
 			compatible = "regulator-fixed";
 			regulator-name = "VMEM_VDD_2.8V";
-- 
2.17.1

[RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

[Krzysztof Kozlowski]

Add @0 unit address to 'soc' node match its 'reg' property and silence
DTC warning:

    Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on HW.
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 6721966140f4..ebe089469b5f 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -256,7 +256,7 @@
 		cpu_on = <0xC4000003>;
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.17.1

Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

[Marek Szyprowski]

On 29.06.2020 21:33, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and silence
> DTC warning:
>
>      Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> Not tested on HW.
> ---
>   arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 6721966140f4..ebe089469b5f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -256,7 +256,7 @@
>   		cpu_on = <0xC4000003>;
>   	};
>   
> -	soc: soc {
> +	soc: soc@0 {
>   		compatible = "simple-bus";
>   		#address-cells = <1>;
>   		#size-cells = <1>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

[Krzysztof Kozlowski]

On Mon, Jun 29, 2020 at 09:33:37PM +0200, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and silence
> DTC warning:
> 
>     Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Not tested on HW.
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-

Applied.

Best regards,
Krzysztof

[RFT 3/3] arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7

[Krzysztof Kozlowski]

Add @0 unit address to 'soc' node match its 'reg' property and move the
thermal zones out of 'soc' to main root as it this is usually not a
property of a Soc.

This silences DTC warnings:

    Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
    Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on HW.
---
 arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 300ad7326ea8..f590891efe25 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -83,7 +83,7 @@
 		method = "smc";
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -597,15 +597,6 @@
 			#thermal-sensor-cells = <0>;
 		};
 
-		thermal-zones {
-			atlas_thermal: cluster0-thermal {
-				polling-delay-passive = <0>; /* milliseconds */
-				polling-delay = <0>; /* milliseconds */
-				thermal-sensors = <&tmuctrl_0>;
-				#include "exynos7-trip-points.dtsi"
-			};
-		};
-
 		ufs: ufs@15570000 {
 			compatible = "samsung,exynos7-ufs";
 			reg = <0x15570000 0x100>,  /* 0: HCI standard */
@@ -675,6 +666,15 @@
 		};
 	};
 
+	thermal-zones {
+		atlas_thermal: cluster0-thermal {
+			polling-delay-passive = <0>; /* milliseconds */
+			polling-delay = <0>; /* milliseconds */
+			thermal-sensors = <&tmuctrl_0>;
+			#include "exynos7-trip-points.dtsi"
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13
-- 
2.17.1

Re: [RFT 3/3] arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7

[Krzysztof Kozlowski]

On Mon, Jun 29, 2020 at 09:33:38PM +0200, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and move the
> thermal zones out of 'soc' to main root as it this is usually not a
> property of a Soc.
> 
> This silences DTC warnings:
> 
>     Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>     Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Not tested on HW.
> ---
>  arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------

Applied.

Best regards,
Krzysztof

Re: [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

[Sylwester Nawrocki]

Hi Krzysztof,

On 6/29/20 21:33, Krzysztof Kozlowski wrote:
> Remove the simple-bus compatible from a regulators node because its
> children do not have any unit addresses.  This fixes DTC warning:
> 
>      Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   arch/arm/boot/dts/exynos4210-trats.dts | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 3d791db6095c..cec413ee4490 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -31,8 +31,6 @@
>   	};
>   
>   	regulators {
> -		compatible = "simple-bus";

I think you would also need to remove the 'regulators' node altogether, 
otherwise with your change the subnodes below won't get parsed and the 
regulators will not get registered.

>   		vemmc_reg: regulator-0 {
>   			compatible = "regulator-fixed";
>   			regulator-name = "VMEM_VDD_2.8V";
> 

--
Thanks,
Sylwester

Re: [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

[Krzysztof Kozlowski]

On Mon, Jun 29, 2020 at 09:50:26PM +0200, Sylwester Nawrocki wrote:
> Hi Krzysztof,
> 
> On 6/29/20 21:33, Krzysztof Kozlowski wrote:
> > Remove the simple-bus compatible from a regulators node because its
> > children do not have any unit addresses.  This fixes DTC warning:
> > 
> >      Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >   arch/arm/boot/dts/exynos4210-trats.dts | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> > index 3d791db6095c..cec413ee4490 100644
> > --- a/arch/arm/boot/dts/exynos4210-trats.dts
> > +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> > @@ -31,8 +31,6 @@
> >   	};
> >   	regulators {
> > -		compatible = "simple-bus";
> 
> I think you would also need to remove the 'regulators' node altogether,
> otherwise with your change the subnodes below won't get parsed and the
> regulators will not get registered.

Good point, I actually did not test this patch. Let me recheck and send
a follow up.

Thanks for review!

Best regards,
Krzysztof