linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] ARM: dts: add mmc aliases for Exynos devices
@ 2023-02-27 19:38 Henrik Grimler
  2023-02-27 19:38 ` [PATCH v3 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property Henrik Grimler
  2023-02-27 19:38 ` [PATCH v3 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
  0 siblings, 2 replies; 5+ messages in thread
From: Henrik Grimler @ 2023-02-27 19:38 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, m.szyprowski,
	jenneron, markuss.broks, martin.juecker, virag.david003,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	phone-devel, ~postmarketos/upstreaming
  Cc: Henrik Grimler

It is convenient to have fixed mmcblk numbering of the eMMC and sdcard
so that assigned numbers will not change from boot-to-boot or
depending on if storage devices are actually attached or not.

Anton Bambura has done the work for the chromebooks while I have
looked at the other devices.  On the chromebooks, mmc0 is used for
eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for
sdcard on the other boards, simply because Anton and I had different
preferences.

Also drop mshc aliases while we are at it and instead add mmc
capabilities to the individual device trees (right now they are added
depending on alias index).  I have tested the changes on
exynos4412-odroid-u2 and exynos5422-odroid-xu4: the MMC_CAP_1_8V_DDR
and MMC_CAP_8_BIT_DATA caps are set correctly (meaning they are set
for mshc_0/mmc_0 but not mshc_2/mmc_2) both before and after this
patchset.

---

Changes since v2:
* Set mmc-ddr-1_8v in device trees so that MMC_CAP_1_8V_DDR is set
  also after removal of mshc0 alias.  Issue was pointed out by Krzysztof
  and David.
* Fix whitespace issue in patch 2 which was pointed out by Krzysztof
* Reword commit message of patch 2 after Rob's comment

Changes since v1:
* Move mshc alias cleanup to a separate commit
* Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on
  chromebooks
* Address Krzysztof's review comments:
 - Make changes per device rather than in soc dtsi

Henrik Grimler (2):
  ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property
  ARM: dts: exynos: add mmc aliases

 arch/arm/boot/dts/exynos3250-artik5-eval.dts  |  5 ++++
 arch/arm/boot/dts/exynos3250-artik5.dtsi      | 20 ++++++++++------
 arch/arm/boot/dts/exynos3250-monk.dts         | 20 ++++++++--------
 arch/arm/boot/dts/exynos3250-rinato.dts       | 23 +++++++++----------
 arch/arm/boot/dts/exynos3250.dtsi             |  3 ---
 arch/arm/boot/dts/exynos4210-i9100.dts        | 11 ++++++---
 arch/arm/boot/dts/exynos4210-origen.dts       |  8 ++++++-
 arch/arm/boot/dts/exynos4210-smdkv310.dts     |  4 ++++
 arch/arm/boot/dts/exynos4210-trats.dts        |  9 +++++++-
 .../boot/dts/exynos4210-universal_c210.dts    |  9 +++++++-
 arch/arm/boot/dts/exynos4412-itop-elite.dts   |  4 ++++
 .../boot/dts/exynos4412-itop-scp-core.dtsi    | 17 +++++++++-----
 arch/arm/boot/dts/exynos4412-midas.dtsi       | 20 +++++++++-------
 .../boot/dts/exynos4412-odroid-common.dtsi    | 21 ++++++++++-------
 arch/arm/boot/dts/exynos4412-origen.dts       | 17 +++++++++-----
 arch/arm/boot/dts/exynos4412-p4note.dtsi      | 23 ++++++++++++-------
 arch/arm/boot/dts/exynos4412-smdk4412.dts     |  4 ++++
 arch/arm/boot/dts/exynos4412-tiny4412.dts     |  4 ++++
 arch/arm/boot/dts/exynos4412.dtsi             |  1 -
 arch/arm/boot/dts/exynos5250-arndale.dts      |  6 +++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts     |  3 +++
 arch/arm/boot/dts/exynos5250-snow-common.dtsi |  4 ++++
 arch/arm/boot/dts/exynos5250-spring.dts       |  6 +++++
 arch/arm/boot/dts/exynos5250.dtsi             |  4 ----
 arch/arm/boot/dts/exynos5260-xyref5260.dts    | 16 +++++++++----
 arch/arm/boot/dts/exynos5410-odroidxu.dts     |  3 +++
 arch/arm/boot/dts/exynos5410-smdk5410.dts     |  6 +++++
 arch/arm/boot/dts/exynos5420-arndale-octa.dts |  6 +++++
 .../dts/exynos5420-galaxy-tab-common.dtsi     |  6 +++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    |  4 ++++
 arch/arm/boot/dts/exynos5420-smdk5420.dts     |  6 +++++
 arch/arm/boot/dts/exynos5420.dtsi             |  3 ---
 arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  4 ++++
 .../boot/dts/exynos5422-odroidxu3-common.dtsi |  5 ++++
 arch/arm/boot/dts/exynos5422-samsung-k3g.dts  |  1 +
 arch/arm/boot/dts/exynos5800-peach-pi.dts     |  4 ++++
 36 files changed, 223 insertions(+), 87 deletions(-)


base-commit: 301d3dd05525e3a046f6cfa6ee4dea6a3b7111ee
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-13 20:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-27 19:38 [PATCH v3 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-02-27 19:38 ` [PATCH v3 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property Henrik Grimler
2023-03-12 16:31   ` Krzysztof Kozlowski
2023-03-13 20:28     ` Henrik Grimler
2023-02-27 19:38 ` [PATCH v3 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).