From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops
Date: Mon, 13 Mar 2017 13:55:07 +0900 [thread overview]
Message-ID: <58C6262B.2020000@samsung.com> (raw)
In-Reply-To: <20170311190124.11512-2-krzk@kernel.org>
Hi,
On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote:
> Static struct regulator_ops is not modified so can be made const for
> code safeness.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/regulator/max77693-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/max77693-regulator.c b/drivers/regulator/max77693-regulator.c
> index 3fce67982682..e7000e777292 100644
> --- a/drivers/regulator/max77693-regulator.c
> +++ b/drivers/regulator/max77693-regulator.c
> @@ -150,7 +150,7 @@ static const struct regulator_ops max77693_safeout_ops = {
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> };
>
> -static struct regulator_ops max77693_charger_ops = {
> +static const struct regulator_ops max77693_charger_ops = {
> .is_enabled = regulator_is_enabled_regmap,
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-03-13 4:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170311190141epcas2p2721283aa79819ca89f11815414ae5b4a@epcas2p2.samsung.com>
2017-03-11 19:01 ` [PATCH 1/7] regulator: max1586: Constify regulator_ops Krzysztof Kozlowski
2017-03-11 19:01 ` [PATCH 2/7] regulator: max77693: " Krzysztof Kozlowski
2017-03-13 4:55 ` Chanwoo Choi [this message]
2017-03-13 16:56 ` Applied "regulator: max77693: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01 ` [PATCH 3/7] regulator: max8660: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56 ` Applied "regulator: max8660: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01 ` [PATCH 4/7] regulator: s2mpa01: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56 ` Applied "regulator: s2mpa01: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01 ` [PATCH 5/7] regulator: s2mps11: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56 ` Applied "regulator: s2mps11: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01 ` [PATCH 6/7] regulator: s5m8767: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56 ` Applied "regulator: s5m8767: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01 ` [PATCH 7/7] regulator: s2mpa01: Fix inconsistent indenting Krzysztof Kozlowski
2017-03-13 16:56 ` Applied "regulator: s2mpa01: Fix inconsistent indenting" to the regulator tree Mark Brown
2017-03-13 5:00 ` [PATCH 1/7] regulator: max1586: Constify regulator_ops Chanwoo Choi
2017-03-13 16:56 ` Applied "regulator: max1586: Constify regulator_ops" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58C6262B.2020000@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).