Linux-Samsung-soc Archive on lore.kernel.org
 help / color / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sangbeom Kim <sbkim73@samsung.com>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops
Date: Mon, 13 Mar 2017 14:00:06 +0900
Message-ID: <58C62756.2000800@samsung.com> (raw)
In-Reply-To: <20170311190124.11512-1-krzk@kernel.org>

Dear all,

All patches in this series looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote:
> Static struct regulator_ops is not modified so can be made const for
> code safeness.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/regulator/max1586.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c
> index 2c1228d5796a..6779c2b53674 100644
> --- a/drivers/regulator/max1586.c
> +++ b/drivers/regulator/max1586.c
> @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
>   * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
>   * the set up value.
>   */
> -static struct regulator_ops max1586_v3_ops = {
> +static const struct regulator_ops max1586_v3_ops = {
>  	.get_voltage_sel = max1586_v3_get_voltage_sel,
>  	.set_voltage_sel = max1586_v3_set_voltage_sel,
>  	.list_voltage = regulator_list_voltage_linear,
>  	.map_voltage = regulator_map_voltage_linear,
>  };
>  
> -static struct regulator_ops max1586_v6_ops = {
> +static const struct regulator_ops max1586_v6_ops = {
>  	.get_voltage_sel = max1586_v6_get_voltage_sel,
>  	.set_voltage_sel = max1586_v6_set_voltage_sel,
>  	.list_voltage = regulator_list_voltage_table,
> 

  parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170311190141epcas2p2721283aa79819ca89f11815414ae5b4a@epcas2p2.samsung.com>
2017-03-11 19:01 ` Krzysztof Kozlowski
2017-03-11 19:01   ` [PATCH 2/7] regulator: max77693: " Krzysztof Kozlowski
2017-03-13  4:55     ` Chanwoo Choi
2017-03-13 16:56     ` Applied "regulator: max77693: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01   ` [PATCH 3/7] regulator: max8660: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56     ` Applied "regulator: max8660: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01   ` [PATCH 4/7] regulator: s2mpa01: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56     ` Applied "regulator: s2mpa01: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01   ` [PATCH 5/7] regulator: s2mps11: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56     ` Applied "regulator: s2mps11: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01   ` [PATCH 6/7] regulator: s5m8767: Constify regulator_ops Krzysztof Kozlowski
2017-03-13 16:56     ` Applied "regulator: s5m8767: Constify regulator_ops" to the regulator tree Mark Brown
2017-03-11 19:01   ` [PATCH 7/7] regulator: s2mpa01: Fix inconsistent indenting Krzysztof Kozlowski
2017-03-13 16:56     ` Applied "regulator: s2mpa01: Fix inconsistent indenting" to the regulator tree Mark Brown
2017-03-13  5:00   ` Chanwoo Choi [this message]
2017-03-13 16:56   ` Applied "regulator: max1586: Constify regulator_ops" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58C62756.2000800@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Samsung-soc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-samsung-soc/0 linux-samsung-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-samsung-soc linux-samsung-soc/ https://lore.kernel.org/linux-samsung-soc \
		linux-samsung-soc@vger.kernel.org
	public-inbox-index linux-samsung-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-samsung-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git