[PATCH] scsi: core: fix a typo of coding format

[PATCH] scsi: core: fix a typo of coding format

[qiwuchen55]

From: chenqiwu <chenqiwu@xiaomi.com>

Fix a typo of coding format.

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
 drivers/scsi/scsi_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 610ee41..a89cfaf 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
 	}
 
 	return rtn;
- done:
+done:
 	cmd->scsi_done(cmd);
 	return 0;
 }
-- 
1.9.1

Re: [PATCH] scsi: core: fix a typo of coding format

[Finn Thain]

On Sat, 15 Feb 2020, qiwuchen55@gmail.com wrote:

> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> Fix a typo of coding format.
> 

It isn't a 'typo' as it appears to be a deliberate choice.

git grep '^ [a-z_0-9]+:$' -- drivers/scsi/

I can't find anything in Documentation/process that bans indentation of 
goto labels. Am I missing something? What do you gain?

If there's nothing in the style guide to mandate churn like this patch, 
then we might expect more churn when someone else patches the whitespace 
back in (for consistency, taste, fame and fortune, whatever).

> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
> ---
>  drivers/scsi/scsi_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 610ee41..a89cfaf 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1563,7 +1563,7 @@ static int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
>  	}
>  
>  	return rtn;
> - done:
> +done:
>  	cmd->scsi_done(cmd);
>  	return 0;
>  }
>