From: Michael Schmitz <schmitzmic@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jakub Kicinski <kuba@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Khalid Aziz <khalid@gonehiking.org>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Matt Wang <wwentao@vmware.com>,
Miquel van Smoorenburg <mikevs@xs4all.net>,
Mark Salyzyn <salyzyn@android.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-arch <linux-arch@vger.kernel.org>,
alpha <linux-alpha@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Parisc List <linux-parisc@vger.kernel.org>,
Denis Efremov <efremov@linux.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS
Date: Mon, 27 Jun 2022 20:09:46 +1200 [thread overview]
Message-ID: <1fa7f932-ed3d-974c-dccb-de628191993d@gmail.com> (raw)
In-Reply-To: <CAK8P3a1KKPXr0ews9po_xjmnGYUWf18gBaZYYmnC+DvtxTKLmQ@mail.gmail.com>
Arnd,
Am 26.06.2022 um 20:36 schrieb Arnd Bergmann:
>> There are no platform specific header files other than asm/amigahw.h and
>> asm/mvme147hw.h, currently only holding register address definitions.
>> Would it be OK to add m68k_virt_to_bus() in there if it can't remain in
>> asm/virtconvert.h, Geert?
>
> In that case, I would just leave it under the current name and not change
> m68k at all. I don't like the m68k_virt_to_bus() name because there is
> not anything CPU specific in what it does, and keeping it in a common
> header does nothing to prevent it from being used on other platforms
> either.
Fair enough.
>>>> 32bit powerpc is a different matter though.
>>>
>>> It's similar, but unrelated. The two apple ethernet drivers
>>> (bmac and mace) can again either get changed to use the
>>> dma-mapping interfaces, or get a custom pmac_virt_to_bus()/
>>> pmac_bus_to_virt() helper.
>>
>> Hmmm - I see Finn had done the DMA API conversion on macmace.c which
>> might give some hints on what to do about mace.c ... no idea about
>> bmac.c though. And again, haven't got hardware to test, so custom
>> helpers is it, then.
>
> Ok.
Again, no platform specific headers to shift renamed helpers to, so may
as well keep this as-is.
Cheers,
Michael
>
> Arnd
>
next prev parent reply other threads:[~2022-06-27 8:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 12:57 [PATCH v2 0/3] phase out CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 1/3] scsi: dpt_i2o: drop stale VIRT_TO_BUS dependency Arnd Bergmann
2022-06-21 8:43 ` Hannes Reinecke
2022-06-17 12:57 ` [PATCH v2 2/3] scsi: BusLogic remove bus_to_virt Arnd Bergmann
2022-06-17 14:02 ` Robin Murphy
2022-06-21 8:45 ` Hannes Reinecke
2022-06-21 21:56 ` Khalid Aziz
2022-06-23 14:47 ` Arnd Bergmann
2022-06-24 15:38 ` Khalid Aziz
2022-06-24 15:43 ` Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-18 1:06 ` Michael Schmitz
2022-06-24 9:10 ` Arnd Bergmann
2022-06-26 5:21 ` Michael Schmitz
2022-06-26 8:36 ` Arnd Bergmann
2022-06-27 8:09 ` Michael Schmitz [this message]
2022-06-27 8:26 ` Geert Uytterhoeven
2022-06-27 21:12 ` Michael Schmitz
2022-06-28 3:25 ` Michael Schmitz
2022-06-28 7:03 ` Geert Uytterhoeven
2022-06-28 21:03 ` Michael Schmitz
2022-06-28 21:50 ` Arnd Bergmann
2022-06-28 23:09 ` Michael Schmitz
2022-06-28 23:50 ` Bart Van Assche
2022-06-29 0:01 ` Michael Schmitz
2022-06-29 0:14 ` Michael Schmitz
2022-06-29 6:21 ` Christoph Hellwig
2022-06-30 19:21 ` Michael Schmitz
2022-06-30 8:04 ` David Laight
2022-06-30 9:40 ` Christophe Leroy
2022-06-30 10:32 ` David Laight
2022-06-28 7:08 ` Arnd Bergmann
2022-06-28 21:38 ` Michael Schmitz
2022-06-28 21:55 ` Arnd Bergmann
2022-06-28 23:43 ` Michael Schmitz
2022-06-29 6:25 ` Christoph Hellwig
2022-06-30 19:26 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fa7f932-ed3d-974c-dccb-de628191993d@gmail.com \
--to=schmitzmic@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=efremov@linux.com \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=khalid@gonehiking.org \
--cc=kuba@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=macro@orcam.me.uk \
--cc=mikevs@xs4all.net \
--cc=mpe@ellerman.id.au \
--cc=robin.murphy@arm.com \
--cc=salyzyn@android.com \
--cc=wwentao@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).