From: Robin Murphy <robin.murphy@arm.com>
To: Arnd Bergmann <arnd@kernel.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org,
Miquel van Smoorenburg <mikevs@xs4all.net>,
linux-parisc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
linux-m68k@lists.linux-m68k.org,
Denis Efremov <efremov@linux.com>,
Mark Salyzyn <salyzyn@android.com>,
Christoph Hellwig <hch@infradead.org>,
iommu@lists.linux-foundation.org, Matt Wang <wwentao@vmware.com>,
linux-alpha@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v2 2/3] scsi: BusLogic remove bus_to_virt
Date: Fri, 17 Jun 2022 15:02:27 +0100 [thread overview]
Message-ID: <f5085d38-c596-61d4-befc-9b9f8bb8c11e@arm.com> (raw)
In-Reply-To: <20220617125750.728590-3-arnd@kernel.org>
On 2022-06-17 13:57, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The BusLogic driver is the last remaining driver that relies on the
> deprecated bus_to_virt() function, which in turn only works on a few
> architectures, and is incompatible with both swiotlb and iommu support.
>
> Before commit 391e2f25601e ("[SCSI] BusLogic: Port driver to 64-bit."),
> the driver had a dependency on x86-32, presumably because of this
> problem. However, the change introduced another bug that made it still
> impossible to use the driver on any 64-bit machine.
>
> This was in turn fixed in commit 56f396146af2 ("scsi: BusLogic: Fix
> 64-bit system enumeration error for Buslogic"), 8 years later, which
> shows that there are not a lot of users.
>
> Maciej is still using the driver on 32-bit hardware, and Khalid mentioned
> that the driver works with the device emulation used in VirtualBox
> and VMware. Both of those only emulate it for Windows 2000 and older
> operating systems that did not ship with the better LSI logic driver.
>
> Do a minimum fix that searches through the list of descriptors to find
> one that matches the bus address. This is clearly as inefficient as
> was indicated in the code comment about the lack of a bus_to_virt()
> replacement. A better fix would likely involve changing out the entire
> descriptor allocation for a simpler one, but that would be much
> more invasive.
FWIW, if efficiency *is* a practical concern, even under the current
allocation scheme it looks like there are only 4 actual DMA allocations
to search through. From a quick scan (since it's too hot here not to get
distracted...), if I wanted to optimise this in future I'd probably
remove the semi-redundant allocgrp_* fields from struct blogic_ccb and
hang a dedicated list of the block allocations off the adapter - at that
point the lookup could likely already be more efficient than a
theoretical dma_to_virt() interface would be if it had to go off and
walk an IOMMU pagetable. Then the next question would be whether it's
viable to make a single 32KB allocation rather 4*8KB, so it's no longer
even a list.
For now, though, I agree with the simple change that's clear and easy to
reason about:
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Thanks,
Robin.
> Cc: Maciej W. Rozycki <macro@orcam.me.uk>
> Cc: Matt Wang <wwentao@vmware.com>
> Cc: Khalid Aziz <khalid@gonehiking.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/scsi/BusLogic.c | 27 ++++++++++++++++-----------
> drivers/scsi/Kconfig | 2 +-
> 2 files changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index a897c8f914cf..d057abfcdd5c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2515,12 +2515,26 @@ static int blogic_resultcode(struct blogic_adapter *adapter,
> return (hoststatus << 16) | tgt_status;
> }
>
> +/*
> + * turn the dma address from an inbox into a ccb pointer
> + * This is rather inefficient.
> + */
> +static struct blogic_ccb *
> +blogic_inbox_to_ccb(struct blogic_adapter *adapter, struct blogic_inbox *inbox)
> +{
> + struct blogic_ccb *ccb;
> +
> + for (ccb = adapter->all_ccbs; ccb; ccb = ccb->next_all)
> + if (inbox->ccb == ccb->dma_handle)
> + break;
> +
> + return ccb;
> +}
>
> /*
> blogic_scan_inbox scans the Incoming Mailboxes saving any
> Incoming Mailbox entries for completion processing.
> */
> -
> static void blogic_scan_inbox(struct blogic_adapter *adapter)
> {
> /*
> @@ -2540,16 +2554,7 @@ static void blogic_scan_inbox(struct blogic_adapter *adapter)
> enum blogic_cmplt_code comp_code;
>
> while ((comp_code = next_inbox->comp_code) != BLOGIC_INBOX_FREE) {
> - /*
> - We are only allowed to do this because we limit our
> - architectures we run on to machines where bus_to_virt(
> - actually works. There *needs* to be a dma_addr_to_virt()
> - in the new PCI DMA mapping interface to replace
> - bus_to_virt() or else this code is going to become very
> - innefficient.
> - */
> - struct blogic_ccb *ccb =
> - (struct blogic_ccb *) bus_to_virt(next_inbox->ccb);
> + struct blogic_ccb *ccb = blogic_inbox_to_ccb(adapter, adapter->next_inbox);
> if (comp_code != BLOGIC_CMD_NOTFOUND) {
> if (ccb->status == BLOGIC_CCB_ACTIVE ||
> ccb->status == BLOGIC_CCB_RESET) {
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index cf75588a2587..56bdc08d0b77 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -513,7 +513,7 @@ config SCSI_HPTIOP
>
> config SCSI_BUSLOGIC
> tristate "BusLogic SCSI support"
> - depends on PCI && SCSI && VIRT_TO_BUS
> + depends on PCI && SCSI
> help
> This is support for BusLogic MultiMaster and FlashPoint SCSI Host
> Adapters. Consult the SCSI-HOWTO, available from
next prev parent reply other threads:[~2022-06-17 14:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 12:57 [PATCH v2 0/3] phase out CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 1/3] scsi: dpt_i2o: drop stale VIRT_TO_BUS dependency Arnd Bergmann
2022-06-21 8:43 ` Hannes Reinecke
2022-06-17 12:57 ` [PATCH v2 2/3] scsi: BusLogic remove bus_to_virt Arnd Bergmann
2022-06-17 14:02 ` Robin Murphy [this message]
2022-06-21 8:45 ` Hannes Reinecke
2022-06-21 21:56 ` Khalid Aziz
2022-06-23 14:47 ` Arnd Bergmann
2022-06-24 15:38 ` Khalid Aziz
2022-06-24 15:43 ` Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-18 1:06 ` Michael Schmitz
2022-06-24 9:10 ` Arnd Bergmann
2022-06-26 5:21 ` Michael Schmitz
2022-06-26 8:36 ` Arnd Bergmann
2022-06-27 8:09 ` Michael Schmitz
2022-06-27 8:26 ` Geert Uytterhoeven
2022-06-27 21:12 ` Michael Schmitz
2022-06-28 3:25 ` Michael Schmitz
2022-06-28 7:03 ` Geert Uytterhoeven
2022-06-28 21:03 ` Michael Schmitz
2022-06-28 21:50 ` Arnd Bergmann
2022-06-28 23:09 ` Michael Schmitz
2022-06-28 23:50 ` Bart Van Assche
2022-06-29 0:01 ` Michael Schmitz
2022-06-29 0:14 ` Michael Schmitz
2022-06-29 6:21 ` Christoph Hellwig
2022-06-30 19:21 ` Michael Schmitz
2022-06-30 8:04 ` David Laight
2022-06-30 9:40 ` Christophe Leroy
2022-06-30 10:32 ` David Laight
2022-06-28 7:08 ` Arnd Bergmann
2022-06-28 21:38 ` Michael Schmitz
2022-06-28 21:55 ` Arnd Bergmann
2022-06-28 23:43 ` Michael Schmitz
2022-06-29 6:25 ` Christoph Hellwig
2022-06-30 19:26 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5085d38-c596-61d4-befc-9b9f8bb8c11e@arm.com \
--to=robin.murphy@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=efremov@linux.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=khalid@gonehiking.org \
--cc=kuba@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@orcam.me.uk \
--cc=mikevs@xs4all.net \
--cc=salyzyn@android.com \
--cc=wwentao@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).