linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Jakub Kicinski <kuba@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux-foundation.org,
	Khalid Aziz <khalid@gonehiking.org>,
	"Maciej W . Rozycki" <macro@orcam.me.uk>,
	Matt Wang <wwentao@vmware.com>,
	Miquel van Smoorenburg <mikevs@xs4all.net>,
	Mark Salyzyn <salyzyn@android.com>,
	linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org,
	linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-parisc@vger.kernel.org, Denis Efremov <efremov@linux.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS
Date: Sat, 18 Jun 2022 13:06:40 +1200	[thread overview]
Message-ID: <6ba86afe-bf9f-1aca-7af1-d0d348d75ffc@gmail.com> (raw)
In-Reply-To: <20220617125750.728590-4-arnd@kernel.org>

Arnd,

Am 18.06.2022 um 00:57 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All architecture-independent users of virt_to_bus() and bus_to_virt()
> have been fixed to use the dma mapping interfaces or have been
> removed now.  This means the definitions on most architectures, and the
> CONFIG_VIRT_TO_BUS symbol are now obsolete and can be removed.
>
> The only exceptions to this are a few network and scsi drivers for m68k
> Amiga and VME machines and ppc32 Macintosh. These drivers work correctly
> with the old interfaces and are probably not worth changing.

The Amiga SCSI drivers are all old WD33C93 ones, and replacing 
virt_to_bus by virt_to_phys in the dma_setup() function there would 
cause no functional change at all.

drivers/vme/bridges/vme_ca91cx42.c hasn't been used at all on m68k (it 
is a PCI-to-VME bridge chipset driver that would be needed on 
architectures that natively use a PCI bus). I haven't found anything 
that selects that driver, so not sure it is even still in use??

That would allow you to drop the remaining virt_to_bus define from 
arch/m68k/include/asm/virtconvert.h.

I could submit a patch to convert the Amiga SCSI drivers to use 
virt_to_phys if Geert and the SCSI maintainers think it's worth the churn.

32bit powerpc is a different matter though.

Cheers,

	Michael

  reply	other threads:[~2022-06-18  1:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 12:57 [PATCH v2 0/3] phase out CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 1/3] scsi: dpt_i2o: drop stale VIRT_TO_BUS dependency Arnd Bergmann
2022-06-21  8:43   ` Hannes Reinecke
2022-06-17 12:57 ` [PATCH v2 2/3] scsi: BusLogic remove bus_to_virt Arnd Bergmann
2022-06-17 14:02   ` Robin Murphy
2022-06-21  8:45   ` Hannes Reinecke
2022-06-21 21:56   ` Khalid Aziz
2022-06-23 14:47     ` Arnd Bergmann
2022-06-24 15:38       ` Khalid Aziz
2022-06-24 15:43         ` Arnd Bergmann
2022-06-17 12:57 ` [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS Arnd Bergmann
2022-06-18  1:06   ` Michael Schmitz [this message]
2022-06-24  9:10     ` Arnd Bergmann
2022-06-26  5:21       ` Michael Schmitz
2022-06-26  8:36         ` Arnd Bergmann
2022-06-27  8:09           ` Michael Schmitz
2022-06-27  8:26     ` Geert Uytterhoeven
2022-06-27 21:12       ` Michael Schmitz
2022-06-28  3:25         ` Michael Schmitz
2022-06-28  7:03           ` Geert Uytterhoeven
2022-06-28 21:03             ` Michael Schmitz
2022-06-28 21:50               ` Arnd Bergmann
2022-06-28 23:09                 ` Michael Schmitz
2022-06-28 23:50                   ` Bart Van Assche
2022-06-29  0:01                     ` Michael Schmitz
2022-06-29  0:14                       ` Michael Schmitz
2022-06-29  6:21                   ` Christoph Hellwig
2022-06-30 19:21                     ` Michael Schmitz
2022-06-30  8:04                   ` David Laight
2022-06-30  9:40                     ` Christophe Leroy
2022-06-30 10:32                       ` David Laight
2022-06-28  7:08           ` Arnd Bergmann
2022-06-28 21:38             ` Michael Schmitz
2022-06-28 21:55               ` Arnd Bergmann
2022-06-28 23:43                 ` Michael Schmitz
2022-06-29  6:25               ` Christoph Hellwig
2022-06-30 19:26                 ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ba86afe-bf9f-1aca-7af1-d0d348d75ffc@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=efremov@linux.com \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=khalid@gonehiking.org \
    --cc=kuba@kernel.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m.szyprowski@samsung.com \
    --cc=macro@orcam.me.uk \
    --cc=mikevs@xs4all.net \
    --cc=mpe@ellerman.id.au \
    --cc=robin.murphy@arm.com \
    --cc=salyzyn@android.com \
    --cc=wwentao@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).