Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
* Re: scsi: lpfc: Fix hardlockup in lpfc_abort_handler
       [not found] <d06924929def46d2bfca19a5cf2e7b55@h3c.com>
@ 2019-10-10 17:49 ` James Smart
  0 siblings, 0 replies; only message in thread
From: James Smart @ 2019-10-10 17:49 UTC (permalink / raw)
  To: Zhangguanghui, linux-scsi; +Cc: martin.petersen, James Smart

On 10/10/2019 1:59 AM, Zhangguanghui wrote:
> Hi everyone
> 
> Please refer to the latest patch.
> 
> There is a race deadlock in the function lpfc_abort_handler
> 
> potential deadlocks arising from lock ordering problems.
> 
> It’s the correct order
> 
> spin_unlock(&lpfc_cmd->buf_lock)
> 
> spin_unlock_irqrestore(&phba->hbalock, flags);
> 
> How to solve it ? I think that the patch is reasonable,
> 
> can you help me review and commit this patch, Best regards
> 
> diff --git a/src/lpfc-12.2.0.0/lpfc_scsi.c b/src/lpfc-12.2.0.0/lpfc_scsi.c
> 
> index 3f1375a..19c8505 100644
> 
> --- a/src/lpfc-12.2.0.0/lpfc_scsi.c
> 
> +++ b/src/lpfc-12.2.0.0/lpfc_scsi.c
> 

We confirmed the issue you stated.  We are looking at what you proposed 
and will be adding a patch that will be posted in our next
patch set after we've put it through some regression testing.

-- james


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <d06924929def46d2bfca19a5cf2e7b55@h3c.com>
2019-10-10 17:49 ` scsi: lpfc: Fix hardlockup in lpfc_abort_handler James Smart

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git