From: Igor Stoppa <igor.stoppa@gmail.com> To: Mimi Zohar <zohar@linux.vnet.ibm.com>, Kees Cook <keescook@chromium.org>, Matthew Wilcox <willy@infradead.org>, Dave Chinner <david@fromorbit.com>, James Morris <jmorris@namei.org>, Michal Hocko <mhocko@kernel.org>, kernel-hardening@lists.openwall.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Cc: igor.stoppa@huawei.com, Dave Hansen <dave.hansen@linux.intel.com>, Jonathan Corbet <corbet@lwn.net>, Laura Abbott <labbott@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Masahiro Yamada <yamada.masahiro@socionext.com>, Alexey Dobriyan <adobriyan@gmail.com>, Pekka Enberg <penberg@kernel.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Lihao Liang <lianglihao@huawei.com>, linux-kernel@vger.kernel.org Subject: [PATCH 13/17] prmem: linked list: disable layout randomization Date: Wed, 24 Oct 2018 00:35:00 +0300 Message-ID: <20181023213504.28905-14-igor.stoppa@huawei.com> (raw) In-Reply-To: <20181023213504.28905-1-igor.stoppa@huawei.com> Some of the data structures used in list management are composed by two pointers. Since the kernel is now configured by default to randomize the layout of data structures soleley composed by pointers, this might prevent correct type punning between these structures and their write rare counterpart. It shouldn't be anyway a big loss, in terms of security: with only two fields, there is a 50% chance of guessing correctly the layout. The randomization is disabled only when write rare is enabled. Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com> CC: Kees Cook <keescook@chromium.org> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Andrew Morton <akpm@linux-foundation.org> CC: Masahiro Yamada <yamada.masahiro@socionext.com> CC: Alexey Dobriyan <adobriyan@gmail.com> CC: Pekka Enberg <penberg@kernel.org> CC: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> CC: Lihao Liang <lianglihao@huawei.com> CC: linux-kernel@vger.kernel.org --- include/linux/types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/types.h b/include/linux/types.h index 53609bbdcf0f..a9f6f6515fdc 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -187,12 +187,12 @@ typedef struct { struct list_head { struct list_head *next __aligned(sizeof(void *)); struct list_head *prev __aligned(sizeof(void *)); -} __aligned(sizeof(void *)); +} __no_randomize_layout __aligned(sizeof(void *)); struct hlist_node { struct hlist_node *next __aligned(sizeof(void *)); struct hlist_node **pprev __aligned(sizeof(void *)); -} __aligned(sizeof(void *)); +} __no_randomize_layout __aligned(sizeof(void *)); #else struct list_head { struct list_head *next, *prev; -- 2.17.1
next prev parent reply index Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-23 21:34 [RFC v1 PATCH 00/17] prmem: protected memory Igor Stoppa 2018-10-23 21:34 ` [PATCH 01/17] prmem: linker section for static write rare Igor Stoppa 2018-10-23 21:34 ` [PATCH 02/17] prmem: write rare for static allocation Igor Stoppa 2018-10-25 0:24 ` Dave Hansen 2018-10-29 18:03 ` Igor Stoppa 2018-10-26 9:41 ` Peter Zijlstra 2018-10-29 20:01 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 03/17] prmem: vmalloc support for dynamic allocation Igor Stoppa 2018-10-25 0:26 ` Dave Hansen 2018-10-29 18:07 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 04/17] prmem: " Igor Stoppa 2018-10-23 21:34 ` [PATCH 05/17] prmem: shorthands for write rare on common types Igor Stoppa 2018-10-25 0:28 ` Dave Hansen 2018-10-29 18:12 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 06/17] prmem: test cases for memory protection Igor Stoppa 2018-10-24 3:27 ` Randy Dunlap 2018-10-24 14:24 ` Igor Stoppa 2018-10-25 16:43 ` Dave Hansen 2018-10-29 18:16 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 07/17] prmem: lkdtm tests " Igor Stoppa 2018-10-23 21:34 ` [PATCH 08/17] prmem: struct page: track vmap_area Igor Stoppa 2018-10-24 3:12 ` Matthew Wilcox 2018-10-24 23:01 ` Igor Stoppa 2018-10-25 2:13 ` Matthew Wilcox 2018-10-29 18:21 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 09/17] prmem: hardened usercopy Igor Stoppa 2018-10-29 11:45 ` Chris von Recklinghausen 2018-10-29 18:24 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 10/17] prmem: documentation Igor Stoppa 2018-10-24 3:48 ` Randy Dunlap 2018-10-24 14:30 ` Igor Stoppa 2018-10-24 23:04 ` Mike Rapoport 2018-10-29 19:05 ` Igor Stoppa 2018-10-26 9:26 ` Peter Zijlstra 2018-10-26 10:20 ` Matthew Wilcox 2018-10-29 19:28 ` Igor Stoppa 2018-10-26 10:46 ` Kees Cook 2018-10-28 18:31 ` Peter Zijlstra 2018-10-29 21:04 ` Igor Stoppa 2018-10-30 15:26 ` Peter Zijlstra 2018-10-30 16:37 ` Kees Cook 2018-10-30 17:06 ` Andy Lutomirski 2018-10-30 17:58 ` Matthew Wilcox 2018-10-30 18:03 ` Dave Hansen 2018-10-31 9:18 ` Peter Zijlstra 2018-10-30 18:28 ` Tycho Andersen 2018-10-30 19:20 ` Matthew Wilcox 2018-10-30 20:43 ` Igor Stoppa 2018-10-30 21:02 ` Andy Lutomirski 2018-10-30 21:07 ` Kees Cook 2018-10-30 21:25 ` Igor Stoppa 2018-10-30 22:15 ` Igor Stoppa 2018-10-31 10:11 ` Peter Zijlstra 2018-10-31 20:38 ` Andy Lutomirski 2018-10-31 20:53 ` Andy Lutomirski 2018-10-31 9:45 ` Peter Zijlstra 2018-10-30 21:35 ` Matthew Wilcox 2018-10-30 21:49 ` Igor Stoppa 2018-10-31 4:41 ` Andy Lutomirski 2018-10-31 9:08 ` Igor Stoppa 2018-10-31 19:38 ` Igor Stoppa 2018-10-31 10:02 ` Peter Zijlstra 2018-10-31 20:36 ` Andy Lutomirski 2018-10-31 21:00 ` Peter Zijlstra 2018-10-31 22:57 ` Andy Lutomirski 2018-10-31 23:10 ` Igor Stoppa 2018-10-31 23:19 ` Andy Lutomirski 2018-10-31 23:26 ` Igor Stoppa 2018-11-01 8:21 ` Thomas Gleixner 2018-11-01 15:58 ` Igor Stoppa 2018-11-01 17:08 ` Peter Zijlstra 2018-10-30 18:51 ` Andy Lutomirski 2018-10-30 19:14 ` Kees Cook 2018-10-30 21:25 ` Matthew Wilcox 2018-10-30 21:55 ` Igor Stoppa 2018-10-30 22:08 ` Matthew Wilcox 2018-10-31 9:29 ` Peter Zijlstra 2018-10-30 23:18 ` Nadav Amit 2018-10-31 9:08 ` Peter Zijlstra 2018-11-01 16:31 ` Nadav Amit 2018-11-02 21:11 ` Nadav Amit 2018-10-31 9:36 ` Peter Zijlstra 2018-10-31 11:33 ` Matthew Wilcox 2018-11-13 14:25 ` Igor Stoppa 2018-11-13 17:16 ` Andy Lutomirski 2018-11-13 17:43 ` Nadav Amit 2018-11-13 17:47 ` Andy Lutomirski 2018-11-13 18:06 ` Nadav Amit 2018-11-13 18:31 ` Igor Stoppa 2018-11-13 18:33 ` Igor Stoppa 2018-11-13 18:36 ` Andy Lutomirski 2018-11-13 19:03 ` Igor Stoppa 2018-11-21 16:34 ` Igor Stoppa 2018-11-21 17:36 ` Nadav Amit 2018-11-21 18:01 ` Igor Stoppa 2018-11-21 18:15 ` Andy Lutomirski 2018-11-22 19:27 ` Igor Stoppa 2018-11-22 20:04 ` Matthew Wilcox 2018-11-22 20:53 ` Andy Lutomirski 2018-12-04 12:34 ` Igor Stoppa 2018-11-13 18:48 ` Andy Lutomirski 2018-11-13 19:35 ` Igor Stoppa 2018-11-13 18:26 ` Igor Stoppa 2018-11-13 18:35 ` Andy Lutomirski 2018-11-13 19:01 ` Igor Stoppa 2018-10-31 9:27 ` Igor Stoppa 2018-10-26 11:09 ` Markus Heiser 2018-10-29 19:35 ` Igor Stoppa 2018-10-26 15:05 ` Jonathan Corbet 2018-10-29 19:38 ` Igor Stoppa 2018-10-29 20:35 ` Igor Stoppa 2018-10-23 21:34 ` [PATCH 11/17] prmem: llist: use designated initializer Igor Stoppa 2018-10-23 21:34 ` [PATCH 12/17] prmem: linked list: set alignment Igor Stoppa 2018-10-26 9:31 ` Peter Zijlstra 2018-10-23 21:35 ` Igor Stoppa [this message] 2018-10-24 13:43 ` [PATCH 13/17] prmem: linked list: disable layout randomization Alexey Dobriyan 2018-10-29 19:40 ` Igor Stoppa 2018-10-26 9:32 ` Peter Zijlstra 2018-10-26 10:17 ` Matthew Wilcox 2018-10-30 15:39 ` Peter Zijlstra 2018-10-23 21:35 ` [PATCH 14/17] prmem: llist, hlist, both plain and rcu Igor Stoppa 2018-10-24 11:37 ` Mathieu Desnoyers 2018-10-24 14:03 ` Igor Stoppa 2018-10-24 14:56 ` Tycho Andersen 2018-10-24 22:52 ` Igor Stoppa 2018-10-25 8:11 ` Tycho Andersen 2018-10-28 9:52 ` Steven Rostedt 2018-10-29 19:43 ` Igor Stoppa 2018-10-26 9:38 ` Peter Zijlstra 2018-10-23 21:35 ` [PATCH 15/17] prmem: test cases for prlist and prhlist Igor Stoppa 2018-10-23 21:35 ` [PATCH 16/17] prmem: pratomic-long Igor Stoppa 2018-10-25 0:13 ` Peter Zijlstra 2018-10-29 21:17 ` Igor Stoppa 2018-10-30 15:58 ` Peter Zijlstra 2018-10-30 16:28 ` Will Deacon 2018-10-31 9:10 ` Peter Zijlstra 2018-11-01 3:28 ` Kees Cook 2018-10-23 21:35 ` [PATCH 17/17] prmem: ima: turn the measurements list write rare Igor Stoppa 2018-10-24 23:03 ` [RFC v1 PATCH 00/17] prmem: protected memory Dave Chinner 2018-10-29 19:47 ` Igor Stoppa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181023213504.28905-14-igor.stoppa@huawei.com \ --to=igor.stoppa@gmail.com \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=david@fromorbit.com \ --cc=gregkh@linuxfoundation.org \ --cc=igor.stoppa@huawei.com \ --cc=jmorris@namei.org \ --cc=keescook@chromium.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=labbott@redhat.com \ --cc=lianglihao@huawei.com \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=mhocko@kernel.org \ --cc=paulmck@linux.vnet.ibm.com \ --cc=penberg@kernel.org \ --cc=willy@infradead.org \ --cc=yamada.masahiro@socionext.com \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Security-Module Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \ linux-security-module@vger.kernel.org public-inbox-index linux-security-module Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module AGPL code for this site: git clone https://public-inbox.org/public-inbox.git