[security:next-general 83/85] security/safesetid/lsm.c:17:10: fatal error: asm/syscall.h: No such file or directory

[security:next-general 83/85] security/safesetid/lsm.c:17:10: fatal error: asm/syscall.h: No such file or directory

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
head:   2f87324be7736151bd1f9bf1d63b1eb0401011ba
commit: aeca4e2ca65c1aeacfbe520684e6421719d99417 [83/85] LSM: add SafeSetID module that gates setid calls
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout aeca4e2ca65c1aeacfbe520684e6421719d99417
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

>> security/safesetid/lsm.c:17:10: fatal error: asm/syscall.h: No such file or directory
    #include <asm/syscall.h>
             ^~~~~~~~~~~~~~~
   compilation terminated.

vim +17 security/safesetid/lsm.c

    16	
  > 17	#include <asm/syscall.h>
    18	#include <linux/hashtable.h>
    19	#include <linux/lsm_hooks.h>
    20	#include <linux/module.h>
    21	#include <linux/ptrace.h>
    22	#include <linux/sched/task_stack.h>
    23	#include <linux/security.h>
    24	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48517 bytes --]

[PATCH] LSM: SafeSetID: remove unused include

[mortonm]

From: Micah Morton <mortonm@chromium.org>

The include for asm/syscall.h was needed in a prior version of lsm.c
that checked return values of syscall_get_nr, but since we did away with
that part of the code this include is no longer necessary. Take out this
include since it breaks builds for certain architectures. We no longer
have any arch-specific code in SafeSetID.

Signed-off-by: Micah Morton <mortonm@chromium.org>
---
 security/safesetid/lsm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
index 282a242beb86..cecd38e2ac80 100644
--- a/security/safesetid/lsm.c
+++ b/security/safesetid/lsm.c
@@ -14,7 +14,6 @@
 
 #define pr_fmt(fmt) "SafeSetID: " fmt
 
-#include <asm/syscall.h>
 #include <linux/hashtable.h>
 #include <linux/lsm_hooks.h>
 #include <linux/module.h>
-- 
2.20.1.495.gaa96b0ce6b-goog

Re: [PATCH] LSM: SafeSetID: remove unused include

[James Morris]

On Wed, 30 Jan 2019, mortonm@chromium.org wrote:

> From: Micah Morton <mortonm@chromium.org>
> 
> The include for asm/syscall.h was needed in a prior version of lsm.c
> that checked return values of syscall_get_nr, but since we did away with
> that part of the code this include is no longer necessary. Take out this
> include since it breaks builds for certain architectures. We no longer
> have any arch-specific code in SafeSetID.
> 
> Signed-off-by: Micah Morton <mortonm@chromium.org>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general


> ---
>  security/safesetid/lsm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
> index 282a242beb86..cecd38e2ac80 100644
> --- a/security/safesetid/lsm.c
> +++ b/security/safesetid/lsm.c
> @@ -14,7 +14,6 @@
>  
>  #define pr_fmt(fmt) "SafeSetID: " fmt
>  
> -#include <asm/syscall.h>
>  #include <linux/hashtable.h>
>  #include <linux/lsm_hooks.h>
>  #include <linux/module.h>
> 

-- 
James Morris
<jmorris@namei.org>