From: Arnd Bergmann <arnd@arndb.de>
To: Casey Schaufler <casey@schaufler-ca.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Kees Cook <keescook@chromium.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] smack: include linux/watch_queue.h
Date: Mon, 9 Sep 2019 22:46:25 +0200 [thread overview]
Message-ID: <20190909204631.1076624-1-arnd@arndb.de> (raw)
In some randconfig builds, the lack of an explicit #include
in smack_lsm.c causes a build failure:
security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'
if (n->type == WATCH_TYPE_META)
~^
include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
struct watch_notification;
^
security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
if (n->type == WATCH_TYPE_META)
Fixes: 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
security/smack/smack_lsm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index a15e76489683..5120dd9c6335 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -42,6 +42,7 @@
#include <linux/parser.h>
#include <linux/fs_context.h>
#include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
#include "smack.h"
#define TRANS_TRUE "TRUE"
--
2.20.0
next reply other threads:[~2019-09-09 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 20:46 Arnd Bergmann [this message]
2019-09-10 3:40 ` [PATCH] smack: include linux/watch_queue.h kbuild test robot
2019-09-10 4:02 ` kbuild test robot
2019-09-23 21:50 ` Casey Schaufler
2019-09-24 1:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909204631.1076624-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).