* [PATCH] smack: include linux/watch_queue.h
@ 2019-09-09 20:46 Arnd Bergmann
2019-09-10 3:40 ` kbuild test robot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-09 20:46 UTC (permalink / raw)
To: Casey Schaufler, James Morris, Serge E. Hallyn
Cc: Arnd Bergmann, David Howells, Kees Cook, Al Viro,
linux-security-module, linux-kernel
In some randconfig builds, the lack of an explicit #include
in smack_lsm.c causes a build failure:
security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'
if (n->type == WATCH_TYPE_META)
~^
include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
struct watch_notification;
^
security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
if (n->type == WATCH_TYPE_META)
Fixes: 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
security/smack/smack_lsm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index a15e76489683..5120dd9c6335 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -42,6 +42,7 @@
#include <linux/parser.h>
#include <linux/fs_context.h>
#include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
#include "smack.h"
#define TRANS_TRUE "TRUE"
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] smack: include linux/watch_queue.h
2019-09-09 20:46 [PATCH] smack: include linux/watch_queue.h Arnd Bergmann
@ 2019-09-10 3:40 ` kbuild test robot
2019-09-10 4:02 ` kbuild test robot
2019-09-23 21:50 ` Casey Schaufler
2 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2019-09-10 3:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: kbuild-all, Casey Schaufler, James Morris, Serge E. Hallyn,
Arnd Bergmann, David Howells, Kees Cook, Al Viro,
linux-security-module, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
Hi Arnd,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/smack-include-linux-watch_queue-h/20190910-095704
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> security/smack/smack_lsm.c:45:10: fatal error: linux/watch_queue.h: No such file or directory
#include <linux/watch_queue.h>
^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +45 security/smack/smack_lsm.c
> 45 #include <linux/watch_queue.h>
46 #include "smack.h"
47
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54588 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] smack: include linux/watch_queue.h
2019-09-09 20:46 [PATCH] smack: include linux/watch_queue.h Arnd Bergmann
2019-09-10 3:40 ` kbuild test robot
@ 2019-09-10 4:02 ` kbuild test robot
2019-09-23 21:50 ` Casey Schaufler
2 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2019-09-10 4:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: kbuild-all, Casey Schaufler, James Morris, Serge E. Hallyn,
Arnd Bergmann, David Howells, Kees Cook, Al Viro,
linux-security-module, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
Hi Arnd,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/smack-include-linux-watch_queue-h/20190910-095704
reproduce:
# apt-get install sparse
# sparse version:
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> security/smack/smack_lsm.c:45:11: sparse: error: unable to open 'linux/watch_queue.h'
vim +45 security/smack/smack_lsm.c
> 45 #include <linux/watch_queue.h>
46 #include "smack.h"
47
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69504 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] smack: include linux/watch_queue.h
2019-09-09 20:46 [PATCH] smack: include linux/watch_queue.h Arnd Bergmann
2019-09-10 3:40 ` kbuild test robot
2019-09-10 4:02 ` kbuild test robot
@ 2019-09-23 21:50 ` Casey Schaufler
2019-09-24 1:24 ` Arnd Bergmann
2 siblings, 1 reply; 5+ messages in thread
From: Casey Schaufler @ 2019-09-23 21:50 UTC (permalink / raw)
To: Arnd Bergmann, James Morris, Serge E. Hallyn
Cc: David Howells, Kees Cook, Al Viro, linux-security-module, linux-kernel
On 9/9/2019 1:46 PM, Arnd Bergmann wrote:
> In some randconfig builds, the lack of an explicit #include
> in smack_lsm.c causes a build failure:
What tree/branch are you working with? I don't see this.
>
> security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'
> if (n->type == WATCH_TYPE_META)
> ~^
> include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
> struct watch_notification;
> ^
> security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
> if (n->type == WATCH_TYPE_META)
>
> Fixes: 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> security/smack/smack_lsm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index a15e76489683..5120dd9c6335 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -42,6 +42,7 @@
> #include <linux/parser.h>
> #include <linux/fs_context.h>
> #include <linux/fs_parser.h>
> +#include <linux/watch_queue.h>
> #include "smack.h"
>
> #define TRANS_TRUE "TRUE"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] smack: include linux/watch_queue.h
2019-09-23 21:50 ` Casey Schaufler
@ 2019-09-24 1:24 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-24 1:24 UTC (permalink / raw)
To: Casey Schaufler
Cc: James Morris, Serge E. Hallyn, David Howells, Kees Cook, Al Viro,
LSM List, linux-kernel
On Mon, Sep 23, 2019 at 2:50 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> On 9/9/2019 1:46 PM, Arnd Bergmann wrote:
> > In some randconfig builds, the lack of an explicit #include
> > in smack_lsm.c causes a build failure:
>
> What tree/branch are you working with? I don't see this.
It was in the latest linux-next at the time I posted the patch. It's
possible that
the patch causing the problem got removed in the meantime.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-24 1:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 20:46 [PATCH] smack: include linux/watch_queue.h Arnd Bergmann
2019-09-10 3:40 ` kbuild test robot
2019-09-10 4:02 ` kbuild test robot
2019-09-23 21:50 ` Casey Schaufler
2019-09-24 1:24 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).