* [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
@ 2020-10-15 11:50 Andy Shevchenko
2021-01-02 21:36 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2020-10-15 11:50 UTC (permalink / raw)
To: James Morris, Serge E. Hallyn, linux-security-module; +Cc: Andy Shevchenko
When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
its internal members.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
security/integrity/platform_certs/efi_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
index 18f01f36fe6a..d98260f8402a 100644
--- a/security/integrity/platform_certs/efi_parser.c
+++ b/security/integrity/platform_certs/efi_parser.c
@@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
memcpy(&list, data, sizeof(list));
pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
offs,
- list.signature_type.b, list.signature_list_size,
+ &list.signature_type, list.signature_list_size,
list.signature_header_size, list.signature_size);
lsize = list.signature_list_size;
--
2.28.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2020-10-15 11:50 [PATCH v1] efi: Don't use knowledge about efi_guid_t internals Andy Shevchenko
@ 2021-01-02 21:36 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-01-02 21:36 UTC (permalink / raw)
To: James Morris, Serge E. Hallyn, linux-security-module
On Thu, Oct 15, 2020 at 02:50:28PM +0300, Andy Shevchenko wrote:
> When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> its internal members.
Any comment on this?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> security/integrity/platform_certs/efi_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
> index 18f01f36fe6a..d98260f8402a 100644
> --- a/security/integrity/platform_certs/efi_parser.c
> +++ b/security/integrity/platform_certs/efi_parser.c
> @@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
> memcpy(&list, data, sizeof(list));
> pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
> offs,
> - list.signature_type.b, list.signature_list_size,
> + &list.signature_type, list.signature_list_size,
> list.signature_header_size, list.signature_size);
>
> lsize = list.signature_list_size;
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-08-26 16:37 ` Ard Biesheuvel
@ 2021-08-26 20:27 ` Serge E. Hallyn
0 siblings, 0 replies; 9+ messages in thread
From: Serge E. Hallyn @ 2021-08-26 20:27 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Andy Shevchenko, James Morris, Serge E. Hallyn,
linux-security-module, Mimi Zohar
On Thu, Aug 26, 2021 at 06:37:06PM +0200, Ard Biesheuvel wrote:
> On Thu, 26 Aug 2021 at 17:08, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote:
> > > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> > > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > >
> > > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > > > > > its internal members.
> > > > > >
> > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > >
> > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > > >
> > > > Thanks!
> > > >
> > > > Can we get this applied, please?
> > >
> > > Apologies, this one slipped behind the desk.
> >
> > Do I need to resend it?
> >
>
> No, but I need an ack from James or Serge as it targets security/
It looks correct to me, based on Documentation/core-api/printk-formats.rst
and existing examples.
Reviewed-by: Serge Hallyn <serge@hallyn.com>
thanks
-serge
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-08-26 15:08 ` Andy Shevchenko
@ 2021-08-26 16:37 ` Ard Biesheuvel
2021-08-26 20:27 ` Serge E. Hallyn
0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2021-08-26 16:37 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: James Morris, Serge E. Hallyn, linux-security-module
On Thu, 26 Aug 2021 at 17:08, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote:
> > On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> > > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > >
> > > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > > > > its internal members.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > >
> > > Thanks!
> > >
> > > Can we get this applied, please?
> >
> > Apologies, this one slipped behind the desk.
>
> Do I need to resend it?
>
No, but I need an ack from James or Serge as it targets security/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-06-10 15:05 ` Ard Biesheuvel
@ 2021-08-26 15:08 ` Andy Shevchenko
2021-08-26 16:37 ` Ard Biesheuvel
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-08-26 15:08 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: James Morris, Serge E. Hallyn, linux-security-module
On Thu, Jun 10, 2021 at 05:05:55PM +0200, Ard Biesheuvel wrote:
> On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> > > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > > > its internal members.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Thanks!
> >
> > Can we get this applied, please?
>
> Apologies, this one slipped behind the desk.
Do I need to resend it?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-06-07 17:11 ` Andy Shevchenko
@ 2021-06-10 15:05 ` Ard Biesheuvel
2021-08-26 15:08 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2021-06-10 15:05 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: James Morris, Serge E. Hallyn, linux-security-module
On Mon, 7 Jun 2021 at 19:11, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> > On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > > its internal members.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> Thanks!
>
> Can we get this applied, please?
>
Apologies, this one slipped behind the desk.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-02-09 16:51 ` Ard Biesheuvel
@ 2021-06-07 17:11 ` Andy Shevchenko
2021-06-10 15:05 ` Ard Biesheuvel
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-06-07 17:11 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: James Morris, Serge E. Hallyn, linux-security-module
On Tue, Feb 09, 2021 at 05:51:45PM +0100, Ard Biesheuvel wrote:
> On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> > its internal members.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
Thanks!
Can we get this applied, please?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
2021-02-09 16:45 Andy Shevchenko
@ 2021-02-09 16:51 ` Ard Biesheuvel
2021-06-07 17:11 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2021-02-09 16:51 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: James Morris, Serge E. Hallyn, linux-security-module
On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> its internal members.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> security/integrity/platform_certs/efi_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
> index 18f01f36fe6a..d98260f8402a 100644
> --- a/security/integrity/platform_certs/efi_parser.c
> +++ b/security/integrity/platform_certs/efi_parser.c
> @@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
> memcpy(&list, data, sizeof(list));
> pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
> offs,
> - list.signature_type.b, list.signature_list_size,
> + &list.signature_type, list.signature_list_size,
> list.signature_header_size, list.signature_size);
>
> lsize = list.signature_list_size;
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
@ 2021-02-09 16:45 Andy Shevchenko
2021-02-09 16:51 ` Ard Biesheuvel
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-02-09 16:45 UTC (permalink / raw)
To: James Morris, Serge E. Hallyn, linux-security-module, Ard Biesheuvel
Cc: Andy Shevchenko
When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
its internal members.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
security/integrity/platform_certs/efi_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
index 18f01f36fe6a..d98260f8402a 100644
--- a/security/integrity/platform_certs/efi_parser.c
+++ b/security/integrity/platform_certs/efi_parser.c
@@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
memcpy(&list, data, sizeof(list));
pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
offs,
- list.signature_type.b, list.signature_list_size,
+ &list.signature_type, list.signature_list_size,
list.signature_header_size, list.signature_size);
lsize = list.signature_list_size;
--
2.30.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-08-26 20:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 11:50 [PATCH v1] efi: Don't use knowledge about efi_guid_t internals Andy Shevchenko
2021-01-02 21:36 ` Andy Shevchenko
2021-02-09 16:45 Andy Shevchenko
2021-02-09 16:51 ` Ard Biesheuvel
2021-06-07 17:11 ` Andy Shevchenko
2021-06-10 15:05 ` Ard Biesheuvel
2021-08-26 15:08 ` Andy Shevchenko
2021-08-26 16:37 ` Ard Biesheuvel
2021-08-26 20:27 ` Serge E. Hallyn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).