* Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()
[not found] ` <20200622234326.906346-18-christian.brauner@ubuntu.com>
@ 2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 21:17 ` Stafford Horne
2020-06-27 3:10 ` Greentime Hu
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2020-06-25 8:26 UTC (permalink / raw)
To: Christian Brauner
Cc: Rich Felker, Benjamin Herrenschmidt, linux-sh,
Peter Zijlstra (Intel),
Catalin Marinas, linux-mips, James E.J. Bottomley, Max Filippov,
Guo Ren, Matthew Wilcox (Oracle),
H. Peter Anvin, sparclinux, linux-hexagon, linux-riscv,
Vincent Chen, Will Deacon, Thomas Gleixner, Anton Ivanov,
Jonas Bonn, linux-s390, linux-ia64, linux-c6x-dev, Brian Cain,
linux-xtensa, Michael Ellerman, Helge Deller, x86, Russell King,
Ley Foon Tan, Christian Borntraeger, Ingo Molnar,
Geert Uytterhoeven, linux-parisc, Mark Salter, Matt Turner,
linux-snps-arc, uclinux-h8-devel, Fenghua Yu, Albert Ou,
Kees Cook, Jeff Dike, linux-alpha, linux-um, linuxppc-dev,
Aurelien Jacquiot, linux-m68k, linux-csky, Ivan Kokshaysky,
Greentime Hu, Paul Walmsley, Stafford Horne, Stefan Kristiansson,
Guan Xuetao, linux-arm-kernel, Richard Henderson, Chris Zankel,
Michal Simek, Tony Luck, Yoshinori Sato, Nick Hu, Vineet Gupta,
linux-kernel, openrisc, Palmer Dabbelt, Richard Weinberger,
Paul Mackerras, Linus Torvalds, David S. Miller, Al Viro
On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote:
> Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls()
> back simply copy_thread(). It's a simpler name, and doesn't imply that only
> tls is copied here. This finishes an outstanding chunk of internal process
> creation work since we've added clone3().
> [..]
> arch/mips/kernel/process.c | 2 +-
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()
[not found] ` <20200622234326.906346-18-christian.brauner@ubuntu.com>
2020-06-25 8:26 ` [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Thomas Bogendoerfer
@ 2020-06-25 21:17 ` Stafford Horne
2020-07-04 16:10 ` Christian Brauner
2020-06-27 3:10 ` Greentime Hu
2 siblings, 1 reply; 6+ messages in thread
From: Stafford Horne @ 2020-06-25 21:17 UTC (permalink / raw)
To: Christian Brauner
Cc: Rich Felker, Benjamin Herrenschmidt, linux-sh,
Peter Zijlstra (Intel),
Catalin Marinas, linux-mips, James E.J. Bottomley, Max Filippov,
Guo Ren, Matthew Wilcox (Oracle),
H. Peter Anvin, sparclinux, linux-hexagon, linux-riscv,
Vincent Chen, Will Deacon, Anton Ivanov, Jonas Bonn, linux-s390,
linux-ia64, linux-c6x-dev, Brian Cain, linux-xtensa,
Michael Ellerman, Helge Deller, x86, Russell King, Ley Foon Tan,
Christian Borntraeger, Ingo Molnar, Geert Uytterhoeven,
linux-parisc, Mark Salter, linux-csky, Matt Turner,
linux-snps-arc, uclinux-h8-devel, Fenghua Yu, Albert Ou,
Kees Cook, Jeff Dike, linux-alpha, linux-um, linuxppc-dev,
Aurelien Jacquiot, linux-m68k, Thomas Bogendoerfer,
Ivan Kokshaysky, Greentime Hu, Paul Walmsley, Thomas Gleixner,
Stefan Kristiansson, Guan Xuetao, linux-arm-kernel,
Richard Henderson, Chris Zankel, Michal Simek, Tony Luck,
Yoshinori Sato, Nick Hu, Vineet Gupta, linux-kernel, openrisc,
Palmer Dabbelt, Richard Weinberger, Paul Mackerras,
Linus Torvalds, David S. Miller, Al Viro
On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote:
> diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/process.c
> index d7010e72450c..19045a3efb8a 100644
> --- a/arch/openrisc/kernel/process.c
> +++ b/arch/openrisc/kernel/process.c
> @@ -116,7 +116,7 @@ void release_thread(struct task_struct *dead_task)
> extern asmlinkage void ret_from_fork(void);
>
> /*
> - * copy_thread_tls
> + * copy_thread
> * @clone_flags: flags
> * @usp: user stack pointer or fn for kernel thread
> * @arg: arg to fn for kernel thread; always NULL for userspace thread
> @@ -147,7 +147,7 @@ extern asmlinkage void ret_from_fork(void);
> */
>
> int
> -copy_thread_tls(unsigned long clone_flags, unsigned long usp,
> +copy_thread(unsigned long clone_flags, unsigned long usp,
> unsigned long arg, struct task_struct *p, unsigned long tls)
> {
For the OpenRISC bit.
Acked-by: Stafford Horne <shorne@gmail.com>
Also, I would agree with what Kees mentioned about aligning the parameters.
Sure that would be more work but it would be appreciated.
-Stafford
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()
2020-06-25 21:17 ` Stafford Horne
@ 2020-07-04 16:10 ` Christian Brauner
0 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2020-07-04 16:10 UTC (permalink / raw)
To: Stafford Horne, Kees Cook
Cc: Rich Felker, Benjamin Herrenschmidt, linux-sh,
Peter Zijlstra (Intel),
Catalin Marinas, linux-mips, James E.J. Bottomley, Max Filippov,
Guo Ren, Matthew Wilcox (Oracle),
H. Peter Anvin, sparclinux, linux-hexagon, linux-riscv,
Vincent Chen, Will Deacon, Anton Ivanov, Jonas Bonn, linux-s390,
linux-ia64, linux-c6x-dev, Brian Cain, linux-xtensa,
Michael Ellerman, Helge Deller, x86, Russell King, Ley Foon Tan,
Christian Borntraeger, Ingo Molnar, Geert Uytterhoeven,
linux-parisc, Mark Salter, Matt Turner, linux-snps-arc,
uclinux-h8-devel, Fenghua Yu, Albert Ou, linux-csky, Jeff Dike,
linux-alpha, linux-um, linuxppc-dev, Aurelien Jacquiot,
linux-m68k, Thomas Bogendoerfer, Ivan Kokshaysky, Greentime Hu,
Paul Walmsley, Thomas Gleixner, Stefan Kristiansson, Guan Xuetao,
linux-arm-kernel, Richard Henderson, Chris Zankel, Michal Simek,
Tony Luck, Yoshinori Sato, Nick Hu, Vineet Gupta, linux-kernel,
openrisc, Palmer Dabbelt, Richard Weinberger, Paul Mackerras,
Linus Torvalds, David S. Miller, Al Viro
On Fri, Jun 26, 2020 at 06:17:49AM +0900, Stafford Horne wrote:
> On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote:
>
> > diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/process.c
> > index d7010e72450c..19045a3efb8a 100644
> > --- a/arch/openrisc/kernel/process.c
> > +++ b/arch/openrisc/kernel/process.c
> > @@ -116,7 +116,7 @@ void release_thread(struct task_struct *dead_task)
> > extern asmlinkage void ret_from_fork(void);
> >
> > /*
> > - * copy_thread_tls
> > + * copy_thread
> > * @clone_flags: flags
> > * @usp: user stack pointer or fn for kernel thread
> > * @arg: arg to fn for kernel thread; always NULL for userspace thread
> > @@ -147,7 +147,7 @@ extern asmlinkage void ret_from_fork(void);
> > */
> >
> > int
> > -copy_thread_tls(unsigned long clone_flags, unsigned long usp,
> > +copy_thread(unsigned long clone_flags, unsigned long usp,
> > unsigned long arg, struct task_struct *p, unsigned long tls)
> > {
>
> For the OpenRISC bit.
>
> Acked-by: Stafford Horne <shorne@gmail.com>
>
> Also, I would agree with what Kees mentioned about aligning the parameters.
> Sure that would be more work but it would be appreciated.
Sure, this is a mechanical change. I'll update the individual patches to account for that.
Thanks!
Christian
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()
[not found] ` <20200622234326.906346-18-christian.brauner@ubuntu.com>
2020-06-25 8:26 ` [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Thomas Bogendoerfer
2020-06-25 21:17 ` Stafford Horne
@ 2020-06-27 3:10 ` Greentime Hu
2 siblings, 0 replies; 6+ messages in thread
From: Greentime Hu @ 2020-06-27 3:10 UTC (permalink / raw)
To: Christian Brauner
Cc: Rich Felker, Benjamin Herrenschmidt, linux-sh,
Peter Zijlstra (Intel),
Catalin Marinas, linux-mips, James E.J. Bottomley, Max Filippov,
Guo Ren, Matthew Wilcox (Oracle),
H. Peter Anvin, sparclinux, linux-hexagon, linux-riscv,
Vincent Chen, Will Deacon, Thomas Gleixner, Anton Ivanov,
Jonas Bonn, linux-s390, linux-ia64, linux-c6x-dev, Brian Cain,
linux-xtensa, Michael Ellerman, Helge Deller, x86, Russell King,
Ley Foon Tan, Christian Borntraeger, Ingo Molnar,
Geert Uytterhoeven, linux-parisc, Mark Salter, linux-csky,
Matt Turner, linux-snps-arc, uclinux-h8-devel, Fenghua Yu,
Albert Ou, Kees Cook, Jeff Dike, linux-alpha, linux-um,
linuxppc-dev, Aurelien Jacquiot, linux-m68k, Thomas Bogendoerfer,
Ivan Kokshaysky, Al Viro, Paul Walmsley, Stafford Horne,
Stefan Kristiansson, Guan Xuetao, linux-arm-kernel,
Richard Henderson, Chris Zankel, Michal Simek, Tony Luck,
Yoshinori Sato, Nick Hu, Vineet Gupta, Linux Kernel Mailing List,
openrisc, Palmer Dabbelt, Richard Weinberger, Paul Mackerras,
Linus Torvalds, David S. Miller
Christian Brauner <christian.brauner@ubuntu.com> 於 2020年6月23日 週二 上午7:58寫道：
>
> Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls()
> back simply copy_thread(). It's a simpler name, and doesn't imply that only
> tls is copied here. This finishes an outstanding chunk of internal process
> creation work since we've added clone3().
>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Salter <msalter@redhat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Brian Cain <bcain@codeaurora.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Nick Hu <nickhu@andestech.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Cc: Ley Foon Tan <ley.foon.tan@intel.com>
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Rich Felker <dalias@libc.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Guan Xuetao <gxt@pku.edu.cn>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: linux-alpha@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-snps-arc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-c6x-dev@linux-c6x.org
> Cc: linux-csky@vger.kernel.org
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Cc: linux-hexagon@vger.kernel.org
> Cc: linux-ia64@vger.kernel.org
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: linux-mips@vger.kernel.org
> Cc: openrisc@lists.librecores.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-s390@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
> Cc: linux-um@lists.infradead.org
> Cc: linux-xtensa@linux-xtensa.org
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> arch/alpha/kernel/process.c | 2 +-
> arch/arc/kernel/process.c | 2 +-
> arch/arm/kernel/process.c | 2 +-
> arch/arm64/kernel/process.c | 2 +-
> arch/c6x/kernel/process.c | 2 +-
> arch/csky/kernel/process.c | 2 +-
> arch/h8300/kernel/process.c | 2 +-
> arch/hexagon/kernel/process.c | 2 +-
> arch/ia64/kernel/process.c | 4 ++--
> arch/m68k/kernel/process.c | 2 +-
> arch/microblaze/kernel/process.c | 2 +-
> arch/mips/kernel/process.c | 2 +-
> arch/nds32/kernel/process.c | 2 +-
> arch/nios2/kernel/process.c | 2 +-
> arch/openrisc/kernel/process.c | 4 ++--
> arch/parisc/kernel/process.c | 2 +-
> arch/powerpc/kernel/process.c | 2 +-
> arch/riscv/kernel/process.c | 2 +-
> arch/s390/kernel/process.c | 2 +-
> arch/sh/kernel/process_32.c | 2 +-
> arch/sparc/kernel/process.c | 6 +++---
> arch/sparc/kernel/process_32.c | 2 +-
> arch/sparc/kernel/process_64.c | 2 +-
> arch/um/kernel/process.c | 2 +-
> arch/unicore32/kernel/process.c | 2 +-
> arch/x86/kernel/process.c | 2 +-
> arch/x86/kernel/unwind_frame.c | 2 +-
> arch/xtensa/kernel/process.c | 2 +-
> include/linux/sched/task.h | 2 +-
> kernel/fork.c | 2 +-
> 30 files changed, 34 insertions(+), 34 deletions(-)
>
> [...]
> diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
> index 7dbb1bf64165..1020e2c6dcd8 100644
> --- a/arch/nds32/kernel/process.c
> +++ b/arch/nds32/kernel/process.c
> @@ -149,7 +149,7 @@ void flush_thread(void)
> DEFINE_PER_CPU(struct task_struct *, __entry_task);
>
> asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
> -int copy_thread_tls(unsigned long clone_flags, unsigned long stack_start,
> +int copy_thread(unsigned long clone_flags, unsigned long stack_start,
> unsigned long stk_sz, struct task_struct *p,
> unsigned long tls)
> {
Hi Christian, Thank you.
Acked-by: Greentime Hu <green.hu@gmail.com>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 6+ messages in thread