Linux-Sparse Archive on lore.kernel.org
 help / color / Atom feed
* Re: sparse | upgrade to upstream v0.6.2 (!2)
       [not found]   ` <note_184887@salsa.debian.org>
@ 2020-08-01 16:54     ` Luc Van Oostenryck
  0 siblings, 0 replies; 5+ messages in thread
From: Luc Van Oostenryck @ 2020-08-01 16:54 UTC (permalink / raw)
  To: Uwe Kleine-König / sparse; +Cc: linux-sparse

On Sat, Aug 01, 2020 at 06:51:42AM +0000, Uwe Kleine-König wrote:
> Uwe Kleine-König commented:
> 
> 
> What I didn't do compared to your MR is to add the patch "gensel: remove unneeded test/uninitialized warning" to fix a build warning.

I've added a 'maintenance' branch on the official tree: 
  git://git.kernel.org/pub/scm/devel/sparse/sparse.git maint-v0.6.2

which contains a few fixup patches I think the Debian release should have.
It contains, the 'gensel' patch here above (not very important, it just fix
a warning), your patch for sindex.1 (same), the build fix for Hurd and
most importantly it contains a patch for a real bug making sparse crash:
  77f35b796cc8 ("generic: fix missing inlining of generic expression")

Thanks,
-- Luc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sparse | upgrade to upstream v0.6.2 (!2)
       [not found]   ` <note_184882@salsa.debian.org>
@ 2020-08-02 13:29     ` Luc Van Oostenryck
  0 siblings, 0 replies; 5+ messages in thread
From: Luc Van Oostenryck @ 2020-08-02 13:29 UTC (permalink / raw)
  To: Uwe Kleine-König / sparse; +Cc: linux-sparse

For the build failure on X32:
  /usr/include/x86_64-linux-gnux32/gnu/stubs.h:7:12: error: unable to open 'gnu/stubs-32.h'

Sparse should be called with '--arch=x86_64 -mx32' but the error
indicate that '__x86_64__' is not even defined, as if another
architecture was selected. Very strange.
I can't reproduce this here (nor in my old setup, nor in a brand
new reinstall of a x32 chroot).


The output of:
   env CHECK=./sparse ./cgcc -v -no-compile memops.c
should be:
  ./sparse -v --arch=x86_64 <lots of defines for floats> -mx32 --os=linux -gcc-base-dir /usr/lib/gcc/x86_64-linux-gnux32/10/ -multiarch-dir x86_64-linux-gnux32 memops.c

I absolutely don't see what can be wrong. But I wonder why it
happens first or only on memops.c and not on one of the file
listed earlier, for example allocate.c?

-- Luc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sparse | upgrade to upstream v0.6.2 (!2)
       [not found]     ` <note_185156@salsa.debian.org>
@ 2020-08-02 21:09       ` Luc Van Oostenryck
  0 siblings, 0 replies; 5+ messages in thread
From: Luc Van Oostenryck @ 2020-08-02 21:09 UTC (permalink / raw)
  To: Uwe Kleine-König / sparse; +Cc: linux-sparse

On Sun, Aug 02, 2020 at 08:19:46PM +0000, Uwe Kleine-König wrote:
> Uwe Kleine-König commented on a discussion: https://salsa.debian.org/ukleinek/sparse/-/merge_requests/2#note_185156
> 
> It only fails for memops.c because it is only called for that one. See
> https://salsa.debian.org/ukleinek/sparse/-/blob/debian-unstable/debian/rules

Ah yes, OK :)
I thought 'make selfcheck' was called.

-- Luc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sparse | upgrade to upstream v0.6.2 (!2)
       [not found]     ` <note_185155@salsa.debian.org>
@ 2020-08-02 21:30       ` Luc Van Oostenryck
  2020-08-03 14:53         ` Alexey Gladkov
  0 siblings, 1 reply; 5+ messages in thread
From: Luc Van Oostenryck @ 2020-08-02 21:30 UTC (permalink / raw)
  To: Uwe Kleine-König / sparse; +Cc: linux-sparse, Alexey Gladkov

On Sun, Aug 02, 2020 at 08:18:42PM +0000, Uwe Kleine-König wrote:
> Uwe Kleine-König commented on a discussion: https://salsa.debian.org/ukleinek/sparse/-/merge_requests/2#note_185155
> 
> There is still another issue that popped up in the meantime: 
> https://bugs.debian.org/966706

Hmmm, I think that a corner of my mind was silently worried it
will happen.

> The options are:
> 
>  - add a Conflicts: biosquid
>    (this is the ugliest option)
>  - rename sindex to something else
>  - convince the bioquid people to rename their sindex
>  - stop shipping sindex
> 
> For now I will go for "stop shipping sindex", do you have an opinion for a long-term plan?

[+CC to sindex's author]

Not really.
Would it be easy to install it under the name 'sparse-sindex' or
'sparse-index'?

One thing I would like (in some future release) is to split
the sparse package at least in 2:
* one with sparse itself
  - it has no dependencies (except the libc, a compiler compatible
    with gcc and GNU make for the build)
  - maybe cgcc should be included in the package too (which would
    add a dependency on perl)
* one with the others tools
  - but maybe it would even be better to the big ones in their
    own packages with their own dependencies)
But this would not really solve the problem here.

-- Luc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sparse | upgrade to upstream v0.6.2 (!2)
  2020-08-02 21:30       ` Luc Van Oostenryck
@ 2020-08-03 14:53         ` Alexey Gladkov
  0 siblings, 0 replies; 5+ messages in thread
From: Alexey Gladkov @ 2020-08-03 14:53 UTC (permalink / raw)
  To: Luc Van Oostenryck; +Cc: Uwe Kleine-König / sparse, linux-sparse

On Sun, Aug 02, 2020 at 11:30:35PM +0200, Luc Van Oostenryck wrote:
> On Sun, Aug 02, 2020 at 08:18:42PM +0000, Uwe Kleine-König wrote:
> > Uwe Kleine-König commented on a discussion: https://salsa.debian.org/ukleinek/sparse/-/merge_requests/2#note_185155
> > 
> > There is still another issue that popped up in the meantime: 
> > https://bugs.debian.org/966706
> 
> Hmmm, I think that a corner of my mind was silently worried it
> will happen.
> 
> > The options are:
> > 
> >  - add a Conflicts: biosquid
> >    (this is the ugliest option)
> >  - rename sindex to something else
> >  - convince the bioquid people to rename their sindex
> >  - stop shipping sindex
> > 
> > For now I will go for "stop shipping sindex", do you have an opinion for a long-term plan?
> 
> [+CC to sindex's author]
> 
> Not really.
> Would it be easy to install it under the name 'sparse-sindex' or
> 'sparse-index'?
> 
> One thing I would like (in some future release) is to split
> the sparse package at least in 2:
> * one with sparse itself
>   - it has no dependencies (except the libc, a compiler compatible
>     with gcc and GNU make for the build)
>   - maybe cgcc should be included in the package too (which would
>     add a dependency on perl)
> * one with the others tools
>   - but maybe it would even be better to the big ones in their
>     own packages with their own dependencies)
> But this would not really solve the problem here.

Renaming of sindex was an option for me, but since you have a plan
to split the package anyway, then I think it's better to do so. I tried to
use the libsparse.a and it looks like it works fine [1].

I spoke with Oleg Nesterov and he also does not mind moving this utility
to a separate repository.

[1] https://github.com/legionus/sindex

-- 
Rgrds, legion


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <reply-7f2b156a8ad4ece3334e6b9712c2de05@salsa.debian.org>
     [not found] ` <merge_request_28506@salsa.debian.org>
     [not found]   ` <note_184887@salsa.debian.org>
2020-08-01 16:54     ` sparse | upgrade to upstream v0.6.2 (!2) Luc Van Oostenryck
     [not found]   ` <note_184882@salsa.debian.org>
2020-08-02 13:29     ` Luc Van Oostenryck
     [not found]   ` <note_185118@salsa.debian.org>
     [not found]     ` <note_185156@salsa.debian.org>
2020-08-02 21:09       ` Luc Van Oostenryck
     [not found]   ` <note_185002@salsa.debian.org>
     [not found]     ` <note_185155@salsa.debian.org>
2020-08-02 21:30       ` Luc Van Oostenryck
2020-08-03 14:53         ` Alexey Gladkov

Linux-Sparse Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-sparse/0 linux-sparse/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-sparse linux-sparse/ https://lore.kernel.org/linux-sparse \
		linux-sparse@vger.kernel.org
	public-inbox-index linux-sparse

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-sparse


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git