[PATCH] spi/sun6i: Add Master Sample Data Mode for SPI

[PATCH] spi/sun6i: Add Master Sample Data Mode for SPI

[Vinicius Maciel]

In order to work appropriately, some SPI chips, such as
max11043, require SPI master samples the data at the
correct edge.

This patch add Master Sample Data Mode bit in normal sample mode.

Signed-off-by: Vinicius Maciel <viniciusfre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/spi/spi-sun6i.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index e3114832c485..170f4ad407dd 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -43,6 +43,7 @@
 #define SUN6I_TFR_CTL_CS_LEVEL			BIT(7)
 #define SUN6I_TFR_CTL_DHB			BIT(8)
 #define SUN6I_TFR_CTL_FBS			BIT(12)
+#define SUN6I_TFR_CTL_SDM			BIT(13)
 #define SUN6I_TFR_CTL_XCH			BIT(31)
 
 #define SUN6I_INT_CTL_REG		0x10
@@ -342,6 +343,8 @@ static int sun6i_spi_runtime_resume(struct device *dev)
 
 	sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG,
 			SUN6I_GBL_CTL_BUS_ENABLE | SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP);
+        sun6i_spi_write(sspi, SUN6I_TFR_CTL_REG,
+			SUN6I_TFR_CTL_SDM);
 
 	return 0;
 
-- 
2.11.0

Re: [PATCH] spi/sun6i: Add Master Sample Data Mode for SPI

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Mon, Feb 13, 2017 at 09:05:53AM -0300, Vinicius Maciel wrote:
> In order to work appropriately, some SPI chips, such as
> max11043, require SPI master samples the data at the
> correct edge.

As I said on another version of this patch this should really be done by
implementing the SPI modes - there isn't one universal configuration for
SPI devices unfortunately.

Re: [PATCH] spi/sun6i: Add Master Sample Data Mode for SPI

[Vinicius Maciel]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Hi Mark,

Sorry for the mess up. sun6i is a reference to the Allwinner A31 processor
and sun7i is a reference to the Allwinner A20 processor. A31 uses
spi-sun6i.c code, while A20 uses spi-sun4i.c code. Therefore, this is a
different patch.
About your recommedantion, I have to check with Maxine what can be done.

Thanks.

2017-02-13 15:34 GMT-03:00 Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:

> On Mon, Feb 13, 2017 at 09:05:53AM -0300, Vinicius Maciel wrote:
> > In order to work appropriately, some SPI chips, such as
> > max11043, require SPI master samples the data at the
> > correct edge.
>
> As I said on another version of this patch this should really be done by
> implementing the SPI modes - there isn't one universal configuration for
> SPI devices unfortunately.
>

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 1742 bytes --]

Re: [PATCH] spi/sun6i: Add Master Sample Data Mode for SPI

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Mon, Feb 13, 2017 at 04:00:09PM -0300, Vinicius Maciel wrote:
> Hi Mark,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> Sorry for the mess up. sun6i is a reference to the Allwinner A31 processor
> and sun7i is a reference to the Allwinner A20 processor. A31 uses
> spi-sun6i.c code, while A20 uses spi-sun4i.c code. Therefore, this is a
> different patch.
> About your recommedantion, I have to check with Maxine what can be done.

Usually duplicate patches to the two drivers are sent as a series to
make sure it's the same thing being done twice.