From: Serge Semin <fancer.lancer@gmail.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Sean Anderson <seanga2@gmail.com>
Subject: Re: [PATCH 3/3] dt-bindings: Update Synopsis DW apb ssi bindings
Date: Wed, 25 Nov 2020 15:50:51 +0300 [thread overview]
Message-ID: <20201125125051.tx3knfzvezrhyq3a@mobilestation> (raw)
In-Reply-To: <20201119120253.390883-4-damien.lemoal@wdc.com>
Hello Damien,
> [PATCH 3/3] dt-bindings: Update Synopsis DW apb ssi bindings
The patch subject is too uncertain. There is no subsystem name and
what is added to the bindings. I'd suggest something like:
"dt-bindings: spi: dw-apb-ssi: Add Canaan K210 SPI controller"
Then feel free to add
Acked-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
On Thu, Nov 19, 2020 at 09:02:53PM +0900, Damien Le Moal wrote:
> Update the snps,dw-apb-ssi.yaml document to include the compatibility
> string "canaan,k210-spi" compatible string for the Canaan Kendryte K210
> RISC-V SoC DW apb_ssi V4 SPI controller.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 99ed9b416e94..4825157cd92e 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -65,6 +65,8 @@ properties:
> const: baikal,bt1-ssi
> - description: Baikal-T1 System Boot SPI Controller
> const: baikal,bt1-sys-ssi
> + - description: Canaan Kendryte K210 SoS SPI Controller
> + const: canaan,k210-spi
>
> reg:
> minItems: 1
> --
> 2.28.0
>
prev parent reply other threads:[~2020-11-25 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 12:02 [PATCH 0/3] DW apb_ssi V4 support for Kendryte K210 RISC-V SoC Damien Le Moal
2020-11-19 12:02 ` [PATCH 1/3] spi: dw: Add support for 32-bits max xfer size Damien Le Moal
2020-11-25 19:52 ` Serge Semin
2020-11-26 4:55 ` Sean Anderson
2020-11-26 7:23 ` Damien Le Moal
2020-11-19 12:02 ` [PATCH 2/3] spi: dw: Add support for the Canaan K210 SoC SPI Damien Le Moal
2020-11-25 12:52 ` Serge Semin
2020-11-19 12:02 ` [PATCH 3/3] dt-bindings: Update Synopsis DW apb ssi bindings Damien Le Moal
2020-11-25 12:50 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125125051.tx3knfzvezrhyq3a@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=broonie@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).