Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
@ 2021-03-12  5:40 Kuldeep Singh
  2021-03-24 15:24 ` Rob Herring
  2021-04-26 15:09 ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: Kuldeep Singh @ 2021-03-12  5:40 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, linux-spi, devicetree, linux-kernel
  Cc: Han Xu, Kuldeep Singh

Convert the Freescale QSPI binding to DT schema format using json-schema.

Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
 .../bindings/spi/fsl,spi-fsl-qspi.yaml        | 96 +++++++++++++++++++
 .../devicetree/bindings/spi/spi-fsl-qspi.txt  | 66 -------------
 MAINTAINERS                                   |  1 +
 3 files changed, 97 insertions(+), 66 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt

diff --git a/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
new file mode 100644
index 000000000000..e58644558412
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
@@ -0,0 +1,96 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/fsl,spi-fsl-qspi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale Quad Serial Peripheral Interface (QuadSPI)
+
+maintainers:
+  - Han Xu <han.xu@nxp.com>
+
+allOf:
+  - $ref: "spi-controller.yaml#"
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,vf610-qspi
+          - fsl,imx6sx-qspi
+          - fsl,imx7d-qspi
+          - fsl,imx6ul-qspi
+          - fsl,ls1021a-qspi
+          - fsl,ls2080a-qspi
+      - items:
+          - enum:
+              - fsl,ls1043a-qspi
+          - const: fsl,ls1021a-qspi
+      - items:
+          - enum:
+              - fsl,imx8mq-qspi
+          - const: fsl,imx7d-qspi
+
+  reg:
+    items:
+      - description: registers
+      - description: memory mapping
+
+  reg-names:
+    items:
+      - const: QuadSPI
+      - const: QuadSPI-memory
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: SoC SPI qspi_en clock
+      - description: SoC SPI qspi clock
+
+  clock-names:
+    items:
+      - const: qspi_en
+      - const: qspi
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts
+  - clocks
+  - clock-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        spi@1550000 {
+            compatible = "fsl,ls1021a-qspi";
+            reg = <0x0 0x1550000 0x0 0x100000>,
+                  <0x0 0x40000000 0x0 0x10000000>;
+            reg-names = "QuadSPI", "QuadSPI-memory";
+            interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(2)>,
+                     <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(2)>;
+            clock-names = "qspi_en", "qspi";
+
+            flash@0 {
+                compatible = "jedec,spi-nor";
+                spi-max-frequency = <50000000>;
+                reg = <0>;
+                spi-rx-bus-width = <4>;
+                spi-tx-bus-width = <4>;
+            };
+        };
+    };
diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt
deleted file mode 100644
index 69dc5d57b1ef..000000000000
--- a/Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt
+++ /dev/null
@@ -1,66 +0,0 @@
-* Freescale Quad Serial Peripheral Interface(QuadSPI)
-
-Required properties:
-  - compatible : Should be "fsl,vf610-qspi", "fsl,imx6sx-qspi",
-		 "fsl,imx7d-qspi", "fsl,imx6ul-qspi",
-		 "fsl,ls1021a-qspi", "fsl,ls2080a-qspi"
-		 or
-		 "fsl,ls1043a-qspi" followed by "fsl,ls1021a-qspi"
-  - reg : the first contains the register location and length,
-          the second contains the memory mapping address and length
-  - reg-names: Should contain the reg names "QuadSPI" and "QuadSPI-memory"
-  - interrupts : Should contain the interrupt for the device
-  - clocks : The clocks needed by the QuadSPI controller
-  - clock-names : Should contain the name of the clocks: "qspi_en" and "qspi".
-
-Required SPI slave node properties:
-  - reg: There are two buses (A and B) with two chip selects each.
-	 This encodes to which bus and CS the flash is connected:
-		<0>: Bus A, CS 0
-		<1>: Bus A, CS 1
-		<2>: Bus B, CS 0
-		<3>: Bus B, CS 1
-
-Example:
-
-qspi0: quadspi@40044000 {
-	compatible = "fsl,vf610-qspi";
-	reg = <0x40044000 0x1000>, <0x20000000 0x10000000>;
-	reg-names = "QuadSPI", "QuadSPI-memory";
-	interrupts = <0 24 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&clks VF610_CLK_QSPI0_EN>,
-		<&clks VF610_CLK_QSPI0>;
-	clock-names = "qspi_en", "qspi";
-
-	flash0: s25fl128s@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "spansion,s25fl128s", "jedec,spi-nor";
-		spi-max-frequency = <50000000>;
-		reg = <0>;
-	};
-};
-
-Example showing the usage of two SPI NOR devices on bus A:
-
-&qspi2 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_qspi2>;
-	status = "okay";
-
-	flash0: n25q256a@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "micron,n25q256a", "jedec,spi-nor";
-		spi-max-frequency = <29000000>;
-		reg = <0>;
-	};
-
-	flash1: n25q256a@1 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "micron,n25q256a", "jedec,spi-nor";
-		spi-max-frequency = <29000000>;
-		reg = <1>;
-	};
-};
diff --git a/MAINTAINERS b/MAINTAINERS
index d92f85ca831d..23d02459a98d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7161,6 +7161,7 @@ FREESCALE QUAD SPI DRIVER
 M:	Han Xu <han.xu@nxp.com>
 L:	linux-spi@vger.kernel.org
 S:	Maintained
+F:	Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
 F:	drivers/spi/spi-fsl-qspi.c
 
 FREESCALE QUICC ENGINE LIBRARY
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
  2021-03-12  5:40 [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema Kuldeep Singh
@ 2021-03-24 15:24 ` Rob Herring
  2021-04-22 11:09   ` [EXT] " Kuldeep Singh
  2021-04-26 15:09 ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-03-24 15:24 UTC (permalink / raw)
  To: Kuldeep Singh
  Cc: Han Xu, Mark Brown, Rob Herring, linux-kernel, linux-spi, devicetree

On Fri, 12 Mar 2021 11:10:38 +0530, Kuldeep Singh wrote:
> Convert the Freescale QSPI binding to DT schema format using json-schema.
> 
> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> ---
>  .../bindings/spi/fsl,spi-fsl-qspi.yaml        | 96 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-fsl-qspi.txt  | 66 -------------
>  MAINTAINERS                                   |  1 +
>  3 files changed, 97 insertions(+), 66 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
  2021-03-24 15:24 ` Rob Herring
@ 2021-04-22 11:09   ` Kuldeep Singh
  2021-04-22 15:45     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Kuldeep Singh @ 2021-04-22 11:09 UTC (permalink / raw)
  To: Mark Brown
  Cc: Han Xu, Rob Herring, linux-kernel, linux-spi, devicetree, Rob Herring

Hi Mark,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Wednesday, March 24, 2021 8:54 PM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: Han Xu <han.xu@nxp.com>; Mark Brown <broonie@kernel.org>; Rob
> Herring <robh+dt@kernel.org>; linux-kernel@vger.kernel.org; linux-
> spi@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to
> json schema
> 
> Caution: EXT Email
> 
> On Fri, 12 Mar 2021 11:10:38 +0530, Kuldeep Singh wrote:
> > Convert the Freescale QSPI binding to DT schema format using json-schema.
> >
> > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> > ---
> >  .../bindings/spi/fsl,spi-fsl-qspi.yaml        | 96 +++++++++++++++++++
> >  .../devicetree/bindings/spi/spi-fsl-qspi.txt  | 66 -------------
> >  MAINTAINERS                                   |  1 +
> >  3 files changed, 97 insertions(+), 66 deletions(-)  create mode
> > 100644 Documentation/devicetree/bindings/spi/fsl,spi-fsl-qspi.yaml
> >  delete mode 100644
> > Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt
> >
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Apologies for content free pings.
This patch has already been reviewed by Rob and can be accepted if no further changes required.

Regards
Kuldeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
  2021-04-22 11:09   ` [EXT] " Kuldeep Singh
@ 2021-04-22 15:45     ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-04-22 15:45 UTC (permalink / raw)
  To: Kuldeep Singh
  Cc: Han Xu, Rob Herring, linux-kernel, linux-spi, devicetree, Rob Herring


[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Thu, Apr 22, 2021 at 11:09:19AM +0000, Kuldeep Singh wrote:

> Apologies for content free pings.
> This patch has already been reviewed by Rob and can be accepted if no further changes required.

Whenever I complain about content free pings I also point out that
resends are helpful, it's not just don't ping it's also that having a
copy of the patch helps if anything went wrong:

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
  2021-03-12  5:40 [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema Kuldeep Singh
  2021-03-24 15:24 ` Rob Herring
@ 2021-04-26 15:09 ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-04-26 15:09 UTC (permalink / raw)
  To: devicetree, linux-spi, Kuldeep Singh, linux-kernel, Rob Herring
  Cc: Mark Brown, Han Xu

On Fri, 12 Mar 2021 11:10:38 +0530, Kuldeep Singh wrote:
> Convert the Freescale QSPI binding to DT schema format using json-schema.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] dt-bindings: spi: Convert Freescale QSPI binding to json schema
      commit: 9ec2a73f0b09f5a5070a0092f08b1531b2cb0d8d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12  5:40 [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema Kuldeep Singh
2021-03-24 15:24 ` Rob Herring
2021-04-22 11:09   ` [EXT] " Kuldeep Singh
2021-04-22 15:45     ` Mark Brown
2021-04-26 15:09 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git