From: Stefan Roese <sr@denx.de>
To: Mark Brown <broonie@kernel.org>, NeilBrown <neil@brown.name>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-spi@vger.kernel.org,
Sankalp Negi <sankalpnegi2310@gmail.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier
Date: Tue, 5 Feb 2019 07:29:36 +0100 [thread overview]
Message-ID: <46229a39-b337-6180-b745-5bcf32dbc155@denx.de> (raw)
In-Reply-To: <20190204085302.GB23441@sirena.org.uk>
On 04.02.19 09:53, Mark Brown wrote:
> On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote:
>
>> It is extremely common in the kernel for a file to start
>> // SPDX-License-Identifier.....
>
>> and to have that immediately followed by a comment lile:
>
>> /*
>> * .....
>> * ....
>
> Yes, there was a lot of automated conversion AFAICT (and a lot of
> confusion with all this stuff only being documented in random mailing
> list posts for a long time).
>
>> This patch makes this file match much of the rest of the kernel. Why
>> do you want something different?
>
> Like I said because it makes the comments look more like someone
> actually meant to add a C++ comment - it's what the rest of the
> subsystem is doing too.
If nobody objects, I will do this change to C++ comments in the header
with the move out of staging into drivers/spi.
Thanks,
Stefan
prev parent reply other threads:[~2019-02-05 6:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 10:17 [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Stefan Roese
2019-02-01 10:17 ` [PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage Stefan Roese
2019-02-01 10:17 ` [PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset() Stefan Roese
2019-02-01 10:17 ` [PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition Stefan Roese
2019-02-01 10:17 ` [PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes Stefan Roese
2019-02-01 10:17 ` [PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style Stefan Roese
2019-02-01 10:17 ` [PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions Stefan Roese
2019-02-01 10:17 ` [PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values Stefan Roese
2019-02-01 10:17 ` [PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi Stefan Roese
2019-02-03 22:42 ` NeilBrown
2019-02-01 13:03 ` [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Mark Brown
2019-02-03 22:34 ` NeilBrown
2019-02-04 8:53 ` Mark Brown
2019-02-04 23:09 ` NeilBrown
2019-02-05 6:29 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46229a39-b337-6180-b745-5bcf32dbc155@denx.de \
--to=sr@denx.de \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-spi@vger.kernel.org \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).